New issue
Advanced search Search tips

Issue 669910 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature


Sign in to add a comment

Migrate V8 swarming targets to GN

Project Member Reported by machenb...@chromium.org, Nov 30 2016

Issue description

V8 currently uses legacy gyp swarming targets in gn builds, i.e target_name_run equivalents. Instead we should use MB to generate the targets and use the gn data variables to copy test data.

We'll also need an equivalent of
https://cs.chromium.org/chromium/src/testing/buildbot/gn_isolate_map.pyl

And pass the targets to MB.
 
Blocking: v8:5872
Blocking: v8:6584
Blocking: v8:5881
Blocking: 748420
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/41d9e8571419acd3547c9810c55c5516cc4dee79

commit 41d9e8571419acd3547c9810c55c5516cc4dee79
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Nov 20 12:29:12 2017

[build] Update MB fork with upstream changes

This updates the V8 side MB fork with all upstream changes until:
https://chromium.googlesource.com/chromium/src/+/f4d92a15f/tools/mb/mb.py

This includes a required feature for mapping isolate targets to
runtime deps.

Bug:  chromium:669910 
Change-Id: I22244455b22737cfbfc45adef93581ef44cf4151
Reviewed-on: https://chromium-review.googlesource.com/778879
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49487}
[modify] https://crrev.com/41d9e8571419acd3547c9810c55c5516cc4dee79/tools/mb/docs/design_spec.md
[modify] https://crrev.com/41d9e8571419acd3547c9810c55c5516cc4dee79/tools/mb/docs/user_guide.md
[modify] https://crrev.com/41d9e8571419acd3547c9810c55c5516cc4dee79/tools/mb/mb.py
[modify] https://crrev.com/41d9e8571419acd3547c9810c55c5516cc4dee79/tools/mb/mb_unittest.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1f97ac71eb9d5899dbb629b2168097b0de1acb96

commit 1f97ac71eb9d5899dbb629b2168097b0de1acb96
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 21 10:26:06 2017

V8: Refactoring - separate isolate targets from isolate step

We will reuse the isolate targets for passing them to MB.

Bug:  669910 
Change-Id: I7f43d1e72fba1529832424cbcc60d8d55eab906b
Reviewed-on: https://chromium-review.googlesource.com/781699
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/1f97ac71eb9d5899dbb629b2168097b0de1acb96/scripts/slave/README.recipes.md
[modify] https://crrev.com/1f97ac71eb9d5899dbb629b2168097b0de1acb96/scripts/slave/recipe_modules/v8/api.py

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1cd6fd9ff8e88bffa7cbec7131b85ff086dc128c

commit 1cd6fd9ff8e88bffa7cbec7131b85ff086dc128c
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 21 10:25:19 2017

[build] Drop Chromium-specific features from V8's MB fork

V8 passes the command explicitly to each swarming task, hence it's
not necessary to store the command in the isolate.

This drops the Chromium-specific code in MB that creates the
swarming command based on Chromium test features.

This also makes the swarming targets option a no-op to allow
activating it on the infra side without disruption.

Bug:  chromium:669910 
Change-Id: I6cb03f05d034092a25d879d52b4d64952493f55b
Reviewed-on: https://chromium-review.googlesource.com/779148
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49520}
[modify] https://crrev.com/1cd6fd9ff8e88bffa7cbec7131b85ff086dc128c/tools/mb/mb.py
[modify] https://crrev.com/1cd6fd9ff8e88bffa7cbec7131b85ff086dc128c/tools/mb/mb_unittest.py

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 21 2017

Labels: merge-merged-6.3
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bb8f675755c7eb3bddf732050a0ace3634f7f233

commit bb8f675755c7eb3bddf732050a0ace3634f7f233
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 21 10:41:19 2017

Merged: Squashed multiple commits.

Merged: [build] Update MB fork with upstream changes
Revision: 41d9e8571419acd3547c9810c55c5516cc4dee79

Merged: [build] Drop Chromium-specific features from V8's MB fork
Revision: 1cd6fd9ff8e88bffa7cbec7131b85ff086dc128c

BUG= chromium:669910 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=sergiyb@chromium.org

Change-Id: Ic3b4e7ca3aa70ed00dcfa8e26b25f38e047b41ba
Reviewed-on: https://chromium-review.googlesource.com/781722
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.3@{#83}
Cr-Branched-From: 094a7c93dcdcd921de3883ba4674b7e1a0feffbe-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb528a8021e04a029e06eafee50b918bce0-refs/heads/master@{#48432}
[modify] https://crrev.com/bb8f675755c7eb3bddf732050a0ace3634f7f233/tools/mb/docs/design_spec.md
[modify] https://crrev.com/bb8f675755c7eb3bddf732050a0ace3634f7f233/tools/mb/docs/user_guide.md
[modify] https://crrev.com/bb8f675755c7eb3bddf732050a0ace3634f7f233/tools/mb/mb.py
[modify] https://crrev.com/bb8f675755c7eb3bddf732050a0ace3634f7f233/tools/mb/mb_unittest.py

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 21 2017

Labels: merge-merged-6.2
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a93e465bf800c55e338b9eeeb42cbcc466038f35

commit a93e465bf800c55e338b9eeeb42cbcc466038f35
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 21 10:50:56 2017

Merged: Squashed multiple commits.

Merged: [build] Update MB fork with upstream changes
Revision: 41d9e8571419acd3547c9810c55c5516cc4dee79

Merged: [build] Drop Chromium-specific features from V8's MB fork
Revision: 1cd6fd9ff8e88bffa7cbec7131b85ff086dc128c

BUG= chromium:669910 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=sergiyb@chromium.org

Change-Id: I6925724eeb44b7346c6f9f6bb5b9f964bd802e82
Reviewed-on: https://chromium-review.googlesource.com/781723
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.2@{#92}
Cr-Branched-From: efa2ac4129d30c7c72e84c16af3d20b44829f990-refs/heads/6.2.414@{#1}
Cr-Branched-From: a861ebb762a60bf5cc2a274faee3620abfb06311-refs/heads/master@{#47693}
[modify] https://crrev.com/a93e465bf800c55e338b9eeeb42cbcc466038f35/tools/mb/docs/design_spec.md
[modify] https://crrev.com/a93e465bf800c55e338b9eeeb42cbcc466038f35/tools/mb/docs/user_guide.md
[modify] https://crrev.com/a93e465bf800c55e338b9eeeb42cbcc466038f35/tools/mb/mb.py
[modify] https://crrev.com/a93e465bf800c55e338b9eeeb42cbcc466038f35/tools/mb/mb_unittest.py

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/615a399d5ac0f898b08e4b3082c3d3e1222acd48

commit 615a399d5ac0f898b08e4b3082c3d3e1222acd48
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 21 11:04:56 2017

V8: Pass isolated targets to MB

Depends on V8 side:
https://chromium-review.googlesource.com/c/v8/v8/+/779148

Bug:  669910 
Change-Id: I983288be6ed204fabf012fca13fcc775bddd0688
Reviewed-on: https://chromium-review.googlesource.com/781463
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_wrong_results.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc___sim___beta_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mipsel___sim___stable_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_with_build_id.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___msvc.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64___release_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac_GC_Stress.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mips64el___sim___beta_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390___sim___beta_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_gc_stress_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc64___sim.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_asan_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN___concurrent_marking.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel_positional_extra_flags.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_gerrit.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390x___sim___stable_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___verify_csa.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm___builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc64___sim___stable_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc64___sim___beta_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___gyp.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64___debug_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32_ASAN.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___verify_csa.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc___sim___stable_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390x___sim___beta_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_concurrent_marking_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc___sim.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mipsel___sim___beta_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390___sim___stable_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_rel.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_verify_csa_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___noi18n___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390x___sim.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_ubsan_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Linux64_TSAN___release_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___stable_branch___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mips64el___sim___stable_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___arm64___sim___MSAN.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___stable_branch.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___nosnap___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_verify_csa_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___nosnap___shared.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_UBSanVptr.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch___debug.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel_gerrit.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_gc_stress_dbg.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_with_cache.json
[modify] https://crrev.com/615a399d5ac0f898b08e4b3082c3d3e1222acd48/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch.json

Labels: -Pri-2 Pri-1
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/451d0c7633913b10e52f976d985a644047a0c46d

commit 451d0c7633913b10e52f976d985a644047a0c46d
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Mar 26 09:13:43 2018

[build] Add data deps for windows component builds

This adds runtime dependencies for windows component builds to be
isolated with swarming targets.

Documentation for data dependencies:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md#data

Bug:  chromium:669910 
Change-Id: I4817b707e3fbc4cf664be319c4dac4668e37f14a
Reviewed-on: https://chromium-review.googlesource.com/979794
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52208}
[modify] https://crrev.com/451d0c7633913b10e52f976d985a644047a0c46d/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/20ab39e7c9a5faa543db7569fe144ce3e4298852

commit 20ab39e7c9a5faa543db7569fe144ce3e4298852
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Mar 26 09:17:28 2018

[build] Add start-up data deps

Bug:  chromium:669910 
Change-Id: Icf524095299a7d3763eeada853b2e831e39ba1e9
Reviewed-on: https://chromium-review.googlesource.com/979798
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52210}
[modify] https://crrev.com/20ab39e7c9a5faa543db7569fe144ce3e4298852/BUILD.gn

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3dfa955a9bcce87447b0fa19c73dab5c52b4da7b

commit 3dfa955a9bcce87447b0fa19c73dab5c52b4da7b
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Mar 26 10:31:58 2018

[build] Add data deps for tools

Bug:  chromium:669910 
Change-Id: I03f6ef3121af047ea2c4e6b83ed67634f046ce71
Reviewed-on: https://chromium-review.googlesource.com/979796
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52212}
[add] https://crrev.com/3dfa955a9bcce87447b0fa19c73dab5c52b4da7b/infra/mb/gn_isolate_map.pyl
[modify] https://crrev.com/3dfa955a9bcce87447b0fa19c73dab5c52b4da7b/tools/BUILD.gn
[add] https://crrev.com/3dfa955a9bcce87447b0fa19c73dab5c52b4da7b/tools/gcmole/BUILD.gn
[add] https://crrev.com/3dfa955a9bcce87447b0fa19c73dab5c52b4da7b/tools/jsfunfuzz/BUILD.gn

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a39f4452a457b92ca4f2b37329920073e79b36c6

commit a39f4452a457b92ca4f2b37329920073e79b36c6
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Mar 26 12:17:08 2018

[build] Add testrunner data deps

Bug:  chromium:669910 
Change-Id: I35d146bbe265dfdd0059dd8d3ec4fc5ee54bb465
Reviewed-on: https://chromium-review.googlesource.com/979805
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52219}
[modify] https://crrev.com/a39f4452a457b92ca4f2b37329920073e79b36c6/BUILD.gn
[modify] https://crrev.com/a39f4452a457b92ca4f2b37329920073e79b36c6/tools/BUILD.gn
[add] https://crrev.com/a39f4452a457b92ca4f2b37329920073e79b36c6/tools/valgrind/asan/dummy

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5457e24e15716a6c4c2ce5eea57241de4a815185

commit 5457e24e15716a6c4c2ce5eea57241de4a815185
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Mar 26 13:44:58 2018

[build] Add data deps for d8 test suites

Bug:  chromium:669910 
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: Ifb8719a989a4fda48241967271ebe39037643e39
Reviewed-on: https://chromium-review.googlesource.com/980032
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52223}
[modify] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/infra/mb/gn_isolate_map.pyl
[modify] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/BUILD.gn
[add] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/benchmarks/BUILD.gn
[add] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/debugger/BUILD.gn
[add] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/intl/BUILD.gn
[add] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/message/BUILD.gn
[add] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/mjsunit/BUILD.gn
[add] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/mozilla/BUILD.gn
[add] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/preparser/BUILD.gn
[modify] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/test262/BUILD.gn
[add] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/wasm-spec-tests/BUILD.gn
[add] https://crrev.com/5457e24e15716a6c4c2ce5eea57241de4a815185/test/webkit/BUILD.gn

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/94153ee038ec656c601ab72250ec4f0b5f10b044

commit 94153ee038ec656c601ab72250ec4f0b5f10b044
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Mar 26 13:56:43 2018

[build] Add data deps for convenience test targets

Bug:  chromium:669910 
Change-Id: Ib22286cdfff6cd08f68819ad80a93707ff47389f
Reviewed-on: https://chromium-review.googlesource.com/980034
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52224}
[modify] https://crrev.com/94153ee038ec656c601ab72250ec4f0b5f10b044/infra/mb/gn_isolate_map.pyl
[modify] https://crrev.com/94153ee038ec656c601ab72250ec4f0b5f10b044/test/BUILD.gn

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6f52d0157fc3354aaa692b5209cdcf971d9c788a

commit 6f52d0157fc3354aaa692b5209cdcf971d9c788a
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Mar 26 15:05:52 2018

[build] Used data deps from GN

NOTREECHECKS=true

Bug:  chromium:669910 
Change-Id: I16cfbb6bd6aa8eb4bad3289dfe43c1cd33c42f92
Reviewed-on: https://chromium-review.googlesource.com/980336
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52226}
[modify] https://crrev.com/6f52d0157fc3354aaa692b5209cdcf971d9c788a/infra/mb/mb_config.pyl
[modify] https://crrev.com/6f52d0157fc3354aaa692b5209cdcf971d9c788a/tools/mb/mb.py
[modify] https://crrev.com/6f52d0157fc3354aaa692b5209cdcf971d9c788a/tools/mb/mb_unittest.py

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/712b66da8168c36d350f2f7401f11440c8495830

commit 712b66da8168c36d350f2f7401f11440c8495830
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 28 10:35:05 2018

[build] Remove legacy isolate configurations

Bug:  chromium:669910 
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c
Reviewed-on: https://chromium-review.googlesource.com/982630
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52267}
[modify] https://crrev.com/712b66da8168c36d350f2f7401f11440c8495830/BUILD.gn
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/gni/isolate.gni
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/gni/msvs_dependencies.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/src/base.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/src/d8.isolate
[modify] https://crrev.com/712b66da8168c36d350f2f7401f11440c8495830/test/BUILD.gn
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/benchmarks/benchmarks.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/bot_default.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/cctest/cctest.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/cctest/cctest_exe.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/d8_default.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/debugger/debugger.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/default.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/fuzzer/fuzzer.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/inspector/inspector.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/intl/intl.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/message/message.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/mjsunit/mjsunit.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/mkgrokdump/mkgrokdump.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/mozilla/mozilla.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/optimize_for_size.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/perf.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/preparser/preparser.isolate
[modify] https://crrev.com/712b66da8168c36d350f2f7401f11440c8495830/test/test262/BUILD.gn
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/test262/archive.py
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/test262/list.py
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/test262/test262.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/unittests/unittests.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/wasm-spec-tests/wasm-spec-tests.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/test/webkit/webkit.isolate
[modify] https://crrev.com/712b66da8168c36d350f2f7401f11440c8495830/tools/BUILD.gn
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/tools/check-static-initializers.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/tools/gcmole/run-gcmole.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/tools/isolate_driver.py
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/tools/jsfunfuzz/jsfunfuzz.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/tools/run-num-fuzzer.isolate
[delete] https://crrev.com/f85c24fae35f18d323c564864619134cac3443b6/tools/testrunner/testrunner.isolate

Project Member

Comment 21 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/77a71f85c13f24b0adece4219800e4c0620c8e1f

commit 77a71f85c13f24b0adece4219800e4c0620c8e1f
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 28 10:57:28 2018

Revert "[build] Remove legacy isolate configurations"

This reverts commit 712b66da8168c36d350f2f7401f11440c8495830.

Reason for revert:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20builder/builds/32049

Original change's description:
> [build] Remove legacy isolate configurations
> 
> Bug:  chromium:669910 
> Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
> Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c
> Reviewed-on: https://chromium-review.googlesource.com/982630
> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52267}

TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org,jgruber@chromium.org

Change-Id: I1955325b0b419b38d793ab205131de8de08cb50a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:669910 
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/983418
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52268}
[modify] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/BUILD.gn
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/gni/isolate.gni
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/gni/msvs_dependencies.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/src/base.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/src/d8.isolate
[modify] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/BUILD.gn
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/benchmarks/benchmarks.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/bot_default.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/cctest/cctest.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/cctest/cctest_exe.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/d8_default.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/debugger/debugger.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/default.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/fuzzer/fuzzer.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/inspector/inspector.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/intl/intl.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/message/message.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/mjsunit/mjsunit.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/mkgrokdump/mkgrokdump.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/mozilla/mozilla.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/optimize_for_size.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/perf.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/preparser/preparser.isolate
[modify] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/test262/BUILD.gn
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/test262/archive.py
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/test262/list.py
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/test262/test262.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/unittests/unittests.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/wasm-spec-tests/wasm-spec-tests.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/test/webkit/webkit.isolate
[modify] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/tools/BUILD.gn
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/tools/check-static-initializers.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/tools/gcmole/run-gcmole.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/tools/isolate_driver.py
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/tools/jsfunfuzz/jsfunfuzz.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/tools/run-num-fuzzer.isolate
[add] https://crrev.com/77a71f85c13f24b0adece4219800e4c0620c8e1f/tools/testrunner/testrunner.isolate

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d55e98d7f5e1c7ec540eefb2ddbbc0bad5b19534

commit d55e98d7f5e1c7ec540eefb2ddbbc0bad5b19534
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 28 12:28:26 2018

[build] Add missing webkit isolate config

TBR=sergiyb@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Bug:  chromium:669910 
Change-Id: I13ac32f3177677f4cf86602bee4038241933f38e
Reviewed-on: https://chromium-review.googlesource.com/983599
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52271}
[modify] https://crrev.com/d55e98d7f5e1c7ec540eefb2ddbbc0bad5b19534/infra/mb/gn_isolate_map.pyl

Project Member

Comment 24 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b27ee43a0f466003baddd34828e399061cf57e1b

commit b27ee43a0f466003baddd34828e399061cf57e1b
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 28 12:36:55 2018

Reland "[build] Remove legacy isolate configurations"

This is a reland of 712b66da8168c36d350f2f7401f11440c8495830

Breakage is fixed on infra side by:
https://crrev.com/c/983417

Original change's description:
> [build] Remove legacy isolate configurations
>
> Bug:  chromium:669910 
> Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
> Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c
> Reviewed-on: https://chromium-review.googlesource.com/982630
> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52267}

Bug:  chromium:669910 
Change-Id: I6c06a1fe9587206aa4e983befb105327bfec4154
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/983573
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52273}
[modify] https://crrev.com/b27ee43a0f466003baddd34828e399061cf57e1b/BUILD.gn
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/gni/isolate.gni
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/gni/msvs_dependencies.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/src/base.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/src/d8.isolate
[modify] https://crrev.com/b27ee43a0f466003baddd34828e399061cf57e1b/test/BUILD.gn
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/benchmarks/benchmarks.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/bot_default.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/cctest/cctest.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/cctest/cctest_exe.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/d8_default.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/debugger/debugger.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/default.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/fuzzer/fuzzer.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/inspector/inspector.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/intl/intl.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/message/message.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/mjsunit/mjsunit.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/mkgrokdump/mkgrokdump.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/mozilla/mozilla.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/optimize_for_size.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/perf.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/preparser/preparser.isolate
[modify] https://crrev.com/b27ee43a0f466003baddd34828e399061cf57e1b/test/test262/BUILD.gn
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/test262/archive.py
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/test262/list.py
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/test262/test262.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/unittests/unittests.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/wasm-spec-tests/wasm-spec-tests.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/test/webkit/webkit.isolate
[modify] https://crrev.com/b27ee43a0f466003baddd34828e399061cf57e1b/tools/BUILD.gn
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/tools/check-static-initializers.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/tools/gcmole/run-gcmole.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/tools/isolate_driver.py
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/tools/jsfunfuzz/jsfunfuzz.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/tools/run-num-fuzzer.isolate
[delete] https://crrev.com/61195eb6817727f6a6374b8bdf565c285af17cfb/tools/testrunner/testrunner.isolate

Status: Verified (was: Assigned)

Sign in to add a comment