New issue
Advanced search Search tips

Issue 669901 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocked on:
issue 639227



Sign in to add a comment

Add warning message in DevTools when a touch event listener is not passive

Project Member Reported by fbeaufort@chromium.org, Nov 30 2016

Issue description

It would be nice when adding a non passive touch/wheel event listener that DevTools could throw a warning message that would say something like "Hey, if you're not calling preventDefault() later, you might want to pass {passive: true} options. See https://developers.google.com/web/updates/2016/06/passive-event-listeners"
 
Cc: rbyers@chromium.org
What do you think Rick?
Cc: dtapu...@chromium.org tdres...@chromium.org
Components: Platform>DevTools
Components: -Platform>DevTools Platform>DevTools>Mobile
Labels: -Type-Bug Type-Feature
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Owner: pfeldman@chromium.org
Pavel, this sounds like a violation.

Comment 5 by rbyers@chromium.org, Dec 21 2016

Blockedon: 639227
Sorry I missed the question earlier.  dtapuska@ is the expert here.  Personally I think we've realized that outreach on this is largely failing, but that we have a pretty good looking plan to just make touch listeners passive by default.  I think we should wait to see how the intervention in  issue 639227  goes and then re-evaluate.
There's discussion around this for lighthouse here: https://github.com/GoogleChrome/lighthouse/issues/870

I think there is value in encouraging developers to opt in to passive event listeners early, but I'd be fine with waiting until we've seen how the document level passive event listeners intervention goes.

Comment 7 by rbyers@chromium.org, Dec 22 2016

I didn't mean to discourage any work you're already planning here!  I agree there's value in the warning - I'm just no longer convinced it's worth pushing really hard on and potentially risking warning blindness for.  But certainly if it fits in with larger violation/lighthouse plans then yes - let's warn :-)
Status: WontFix (was: Assigned)
As per comment #7.

Sign in to add a comment