Invalid negative values in stats returned by new getStats |
|||
Issue descriptionInvalid values discovered while debugging an integration test and looking at real stats: RTCOutboundRTPStreamStats.roundTripTime = -0.001 ^-- Sample from outbound audio case, but I'm guessing this affects audio and video. RTCMediaStreamTrackStats.echoReturnLoss = -100 RTCMediaStreamTrackStats.echoReturnLossEnhancement = -100 These are default values. Using Optional<T> would prevent RTCStatsCollector from picking up values that have not been set. Discarding values such as these in RTCStatsCollector is also a solution, but not as elegant.
,
Dec 12 2016
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/9a394f0649d39737a791d17e73ad2603e3d162fb commit 9a394f0649d39737a791d17e73ad2603e3d162fb Author: hbos <hbos@webrtc.org> Date: Wed Dec 14 15:58:22 2016 Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value. Due to the Chromium implementation[1] of GetAudioProcesssingStats, echoReturnLoss and echoReturnLossEnhancement could default to -100 when no value was available. This should be improved by using rtc::Optional or AudioProcessorInterface::GetStats being able to return false, but this requires a bunch of refactoring. In the meantime we "blacklist" the value -100 which is a nonsense value anyway. In that case echoReturnLoss[Enhancement] is correctly left undefined. [1] https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_audio_processor_options.cc?sq=package:chromium&dr=C&rcl=1481530670&l=461 BUG= chromium:669877 Review-Url: https://codereview.webrtc.org/2573443002 Cr-Commit-Position: refs/heads/master@{#15611} [modify] https://crrev.com/9a394f0649d39737a791d17e73ad2603e3d162fb/webrtc/api/rtcstatscollector.cc [modify] https://crrev.com/9a394f0649d39737a791d17e73ad2603e3d162fb/webrtc/api/rtcstatscollector_unittest.cc
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96 commit e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96 Author: hbos <hbos@webrtc.org> Date: Thu Dec 15 09:54:29 2016 RTCOutboundRTPStreamStats.roundTripTime: Only report non-negative values. Underlying stats gatherers may otherwise default it to -1. BUG= chromium:669877 , chromium:627816 Review-Url: https://codereview.webrtc.org/2562703007 Cr-Commit-Position: refs/heads/master@{#15625} [modify] https://crrev.com/e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96/webrtc/api/rtcstats_integrationtest.cc [modify] https://crrev.com/e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96/webrtc/api/rtcstatscollector.cc [modify] https://crrev.com/e10e6d1f47bd3e9570b5c91bfe9b9f6015124c96/webrtc/api/rtcstatscollector_unittest.cc
,
Jan 12 2017
Is there any more work expected to be done here?
,
Jan 12 2017
Done with the above CL. |
|||
►
Sign in to add a comment |
|||
Comment 1 by hbos@chromium.org
, Dec 12 2016