New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 669867 link

Starred by 1 user
Status: Verified
Owner:
█ robhogan@chromium.org
Use other robhogan account instead.
Closed: Jan 2017
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ msrchandra@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Text appears chopped at the bottom in "www.emirates.com"

Reported by adha...@etouch.net, Nov 30 2016 
Chrome Version: 57.0.2937.0 Revision 325a49517707810d1abdfb0040e19b7abb5addbe-refs/heads/master@{#434845}-32/64 bit
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

TEST URL:http://www.emirates.com/in/english/#

What steps will reproduce the problem?
(1)Launch chrome and navigate to the above url.
(2)Click on the 'Search' option at the top R.H.S.
(3)Observe the text of 'Search'.(Kindly refer the video)

Actual:Text appears chopped at the bottom.

Expected:Text should not appear chopped at the bottom.

This is a Regression issue broken in M-56,will soon update other info.

Good build:56.0.2906.0
Bad build:56.0.2907.0
Actual.png
7.3 KB View Download
Actual video.mp4
521 KB View Download
Expected video.mp4
701 KB View Download

Comment 1 by msrchandra@chromium.org, Nov 30 2016

Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: robhogan@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2906.0 (Revision: 428890).
Bad build: 56.0.2907.0 (Revision: 429169).

You are probably looking for a change made after 429108 (known good), but no later than 429109 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/bb98274e9983636f2b903b48779b75e54c24429a..b5243ab8c1a95305aff233a6175aa3a1f94d092f

@roboghan -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Adding RB Label as this is a recent Regression. Please remove if not required.

Thank You.

Comment 2 by kavvaru@chromium.org, Dec 7 2016 

Able to reproduce the issue on windows 7 using chrome version 57.0.2943.0.

roboghan@ could you please look into this issue.

Thanks,

Comment 3 by robho...@gmail.com, Dec 7 2016

Status: Started (was: Assigned)
Yup, I'm working on this alright.

Comment 4 by ligim...@chromium.org, Dec 8 2016 

Thanks for the update. M56 is promoted to BETA, it would great to have a fix ASAP.

Comment 5 by tkonch...@chromium.org, Dec 12 2016 

Just to update:

Still able to reproduce the issue on mac 10.11.6 using chrome version 57.0.2949.0
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c6315ec5c5ca31be742ebbe13cfecb43baae21a

commit 6c6315ec5c5ca31be742ebbe13cfecb43baae21a
Author: robhogan <robhogan@gmail.com>
Date: Wed Dec 14 22:30:42 2016

Percent height border-box content should get correct height in percent height cells

"For the purpose of calculating [the minimum height of a row],
descendants of table cells whose height depends on percentages
of their parent cell's height are considered to have an auto
height if they have overflow set to visible or hidden or if
they are replaced elements, and a 0px height if they have not."

This CL does two things re this rule:

- It ensures we respect it for replaced elements, including ones that aren't
  LayoutReplaced or isReplaced() objects. This is covered by the table-percent-
  height-* tests.
- It ensures we always obey it for hidden/visible overflow elements.

The CL also does two other things:

- If the cell doesn't have a specified height then treat it as auto for the
  purposes of calculating percent heights of its children. See bug
  671010 for the discussion that leads to this approach - soon to be specified
  we hope.
  Note that this results in the new behaviour of the form control elements in
  table-percent-height-* tests: they size as they would if they were in auto-
  sized <div>. Again, see  bug 671010 .
  We introduce a 'regression' in the behaviour of radio/select elements when
  percent-sized inside a cell that has no specified height - they now behave
  the same as radio/select elements when inside a div with auto height, they
  get a zero height. This is covered specifically in input-radio-height-inside-auto-container.html.
  It can also be seen in the updates to table-percent-height.html.

- If we've computed the height of a cell's child using the height made available
  by the cell, then be sure to respect content-/border-sizing of the child. We
  were just assuming that children were always content-sized. These are covered
  by the percent-height-border-box-content-* tests and are the main fall-out
  in 669867.

BUG= 669867 ,  671010 

Review-Url: https://codereview.chromium.org/2535173006
Cr-Commit-Position: refs/heads/master@{#438652}

[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/replaced/input-radio-height-inside-auto-container-expected.html
[add] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/replaced/input-radio-height-inside-auto-container.html
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/replaced/table-percent-height-text-controls.html
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/replaced/table-percent-height.html
[add] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-2-expected.txt
[add] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-2.html
[add] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-3-expected.txt
[add] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-3.html
[add] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-expected.html
[add] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell.html
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/linux/fast/table/003-expected.png
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/linux/fast/table/003-expected.txt
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-2-expected.png
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-2-expected.txt
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-4-expected.png
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-4-expected.txt
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug30692-expected.png
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug30692-expected.txt
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/win/fast/replaced/table-percent-height-expected.txt
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/LayoutTests/platform/win/fast/replaced/table-percent-height-text-controls-expected.txt
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/6c6315ec5c5ca31be742ebbe13cfecb43baae21a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Comment 7 by tkonch...@chromium.org, Dec 15 2016

Cc: tkonch...@chromium.org
Labels: TE-Verified-57.0.2952.0 TE-Verified-M57
Tested the same on win10 using chrome version 57.0.2952.2 and mac 10.11.6, Linux using chrome version   57.0.2952.0 - text of "Search" is properly displayed

Please find the screenshot

Fix works as expected
Screen Shot 2016-12-15 at 2.14.21 PM.png
2.8 MB View Download

Comment 8 by tkonch...@chromium.org, Dec 19 2016 

robhogan@, Could you please merge the fix to M56 if no more work is pending here.

Comment 9 by robhogan@chromium.org, Dec 19 2016

Labels: Merge-Request-56

Comment 10 by dimu@chromium.org, Dec 19 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a

commit c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Dec 21 05:39:22 2016

Auto-rebaseline for r438652

https://chromium.googlesource.com/chromium/src/+/6c6315ec5c5ca

BUG= 669867 
TBR=robhogan@gmail.com

Review-Url: https://codereview.chromium.org/2597593002 .
Cr-Commit-Position: refs/heads/master@{#440030}

[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/fast/replaced/table-percent-height-expected.txt
[rename] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/fast/replaced/table-percent-height-text-controls-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla/bugs/bug30692-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla/bugs/bug30692-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/table/003-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/table/003-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla/bugs/bug30692-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla/bugs/bug30692-expected.txt
[delete] https://crrev.com/a269989828bab0ea0cbe9bdec02c4ea2609c1ea9/third_party/WebKit/LayoutTests/platform/mac/fast/replaced/table-percent-height-expected.txt
[delete] https://crrev.com/a269989828bab0ea0cbe9bdec02c4ea2609c1ea9/third_party/WebKit/LayoutTests/platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac/fast/table/003-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac/fast/table/003-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac/fast/table/split-table-section-before-anonymous-block-2-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac/fast/table/split-table-section-before-anonymous-block-2-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac/fast/table/split-table-section-before-anonymous-block-4-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac/fast/table/split-table-section-before-anonymous-block-4-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/win/fast/table/003-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/win/fast/table/003-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/win/fast/table/split-table-section-before-anonymous-block-2-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/win/fast/table/split-table-section-before-anonymous-block-2-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/win/fast/table/split-table-section-before-anonymous-block-4-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/win/fast/table/split-table-section-before-anonymous-block-4-expected.txt
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug30692-expected.png
[modify] https://crrev.com/c9658bbb02f7f6958064bdd2ad8fd8bbb91c771a/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug30692-expected.txt
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 22 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58eb404753d8ee142e02b9695a84c2c6c24f88ea

commit 58eb404753d8ee142e02b9695a84c2c6c24f88ea
Author: Robert Hogan <robhogan@gmail.com>
Date: Thu Dec 22 13:36:51 2016

Percent height border-box content should get correct height in percent height cells

"For the purpose of calculating [the minimum height of a row],
descendants of table cells whose height depends on percentages
of their parent cell's height are considered to have an auto
height if they have overflow set to visible or hidden or if
they are replaced elements, and a 0px height if they have not."

This CL does two things re this rule:

- It ensures we respect it for replaced elements, including ones that aren't
  LayoutReplaced or isReplaced() objects. This is covered by the table-percent-
  height-* tests.
- It ensures we always obey it for hidden/visible overflow elements.

The CL also does two other things:

- If the cell doesn't have a specified height then treat it as auto for the
  purposes of calculating percent heights of its children. See bug
  671010 for the discussion that leads to this approach - soon to be specified
  we hope.
  Note that this results in the new behaviour of the form control elements in
  table-percent-height-* tests: they size as they would if they were in auto-
  sized <div>. Again, see  bug 671010 .
  We introduce a 'regression' in the behaviour of radio/select elements when
  percent-sized inside a cell that has no specified height - they now behave
  the same as radio/select elements when inside a div with auto height, they
  get a zero height. This is covered specifically in input-radio-height-inside-auto-container.html.
  It can also be seen in the updates to table-percent-height.html.

- If we've computed the height of a cell's child using the height made available
  by the cell, then be sure to respect content-/border-sizing of the child. We
  were just assuming that children were always content-sized. These are covered
  by the percent-height-border-box-content-* tests and are the main fall-out
  in 669867.

BUG= 669867 ,  671010 

Review-Url: https://codereview.chromium.org/2535173006
Cr-Commit-Position: refs/heads/master@{#438652}
(cherry picked from commit 6c6315ec5c5ca31be742ebbe13cfecb43baae21a)

Review-Url: https://codereview.chromium.org/2599043002 .
Cr-Commit-Position: refs/branch-heads/2924@{#596}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/replaced/input-radio-height-inside-auto-container-expected.html
[add] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/replaced/input-radio-height-inside-auto-container.html
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/replaced/table-percent-height-text-controls.html
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/replaced/table-percent-height.html
[add] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-2-expected.txt
[add] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-2.html
[add] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-3-expected.txt
[add] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-3.html
[add] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell-expected.html
[add] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/fast/table/percent-height-border-box-content-in-cell.html
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/platform/linux/fast/table/003-expected.txt
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-2-expected.png
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-2-expected.txt
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-4-expected.png
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-4-expected.txt
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug30692-expected.txt
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/platform/win/fast/replaced/table-percent-height-expected.txt
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/LayoutTests/platform/win/fast/replaced/table-percent-height-text-controls-expected.txt
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/58eb404753d8ee142e02b9695a84c2c6c24f88ea/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Comment 13 by kavvaru@chromium.org, Jan 2 2017

Labels: TE-Verified-M56 TE-Verified-56.0.2924.47
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.12.1 using chrome version 56.0.2924.47.Text of search box is properly displayed.
Please find the attached screen shot for the same.

Adding TE-Verified labels.

Thanks,
669867.png
1023 KB View Download

Comment 14 by e...@chromium.org, Jan 3 2017

Status: Verified (was: Started)
►

Sign in to add a comment