New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669852 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression: Wrong View site info bubble is seen instead of origin bubble for 'Google Docs' page.

Reported by rk...@etouch.net, Nov 30 2016

Issue description

Chrome Version: 57.0.2936.0 Revision 325a49517707810d1abdfb0040e19b7abb5addbe-refs/heads/master@{#434845}
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS) 

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://apps and click on 'Google Docs'
(2) Click on View site info bubble immediately and observe.

Actual: Wrong View site info bubble is seen (i.e. You are viewing extension page) instead of origin bubble.

Expected: Origin bubble should seen.

This is a regression issue, broken in 'M-56', will soon update the other info:

Good build: 56.0.2902.0
Bad Build: 56.0.2906.0
 
Actual_Bubble.mp4
317 KB View Download
Expected_Bubble.mp4
385 KB View Download
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: xidac...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2902.0 (Revision: 427892).
Bad build: 56.0.2906.0 (Revision: 428890).

You are probably looking for a change made after 428812 (known good), but no later than 428813 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/85f388c9b9ac82da747bbefe195724916cdb7900..2f98b6bb35e391918dd1e57ad42b289fc6940bdf

@xidachen -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Adding RB Label as this is a recent Regression. Please remove if not required.

Thank You.
Owner: rdevlin....@chromium.org
rdevlin@
The suspected CL is a reland of your original CL here: https://codereview.chromium.org/2452773002/

Could you please have a look.
Cc: f...@chromium.org creis@chromium.org
This actually doesn't look wrong to me.

If you look closely at both videos, in the "actual" one, the user clicks the site info bubble while the page is pointing to an extension page.  In the "expected" one, the extension page url flashes but the user doesn't click until redirected to docs.google.com (and then ultimately to the sign in page).  I think this is WAI, but +felt@ and creis@ for their opinions.

Comment 4 by creis@chromium.org, Dec 2 2016

Cc: emilyschechter@chromium.org nasko@chromium.org
Components: UI>Security UI>Browser>Navigation
Comment 3: I agree.  In both videos, the bubble displays information about the URL that was present at the time of the click.  That's how it should behave.

However, I do wonder if we should be dismissing the bubble if a new commit happens while it's showing.  That would avoid showing stale info that no longer corresponds to the current page.

felt@ is OOO.  emilyschechter@, do you have thoughts about that or know who to loop in?
Cc: -f...@chromium.org lgar...@chromium.org mea...@chromium.org
Adding +meacer and +lgarron to triage. Dismissing or updating the bubble sounds reasonable, I think.
Status: WontFix (was: Assigned)
I agree with #3 and #4 that the initial contents of the bubble look correct in both the actual and expected cases. Current stable version also exhibits same behavior so there doesn't seem to be a regression here.

Filed bug 670787 to hide or update the bubble on a new commit and wontfixing this.  (msrchandra, rkote: Let us know if we are missing anything)
Components: -UI>Browser>Bubbles -UI>Security UI>Browser>Bubbles>PageInfo

Sign in to add a comment