indexeddb_perf should not use deprecated memory.MemoryMetric |
|||||||
Issue descriptionSomehow I missed this on my search for clients of the old memory.MemoryMetric some time ago. The context is that we would like to remove that metric, and switch benchmarks to use the new TBMv2 tracing based solutions instead. It looks like both: - indexeddb_perf - storage.indexeddb_endure still make use of memory.MemoryMetric. Christopher, you are listed as owner of these benchmarks, would it be possible to remove those now? I see that there is already a: - storage.indexeddb_endure_tracing that _does_ use the tracing based approach. Is this one able to replace the other two?
,
Dec 13 2016
+jsbell can you provide any input about this benchmarks?
,
Dec 13 2016
,
Feb 14 2017
jsbell@ & dmurph@ - any thoughts about these benchmarks? Is it OK to remove the following? - indexeddb_perf - storage.indexeddb_endure
,
Feb 15 2017
I think it's still valuable to use the results reported in storage.indexeddb_endure. We can get rid of indexeddb_perf I think.
,
Feb 15 2017
We can probably do some work to also report the results from storage.indexeddb_endure in storage.indexeddb_endure_tracing.
,
Feb 20 2017
Thanks! Do let us know if you need any advice on how to upgrade your metric.
,
Mar 13 2017
I've sent out https://codereview.chromium.org/2746903003/ for review to remove indexeddb_perf. What metrics are you missing to migrate into storage.indexeddb_endure_tracing?
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02094452c1bef7590bc74c11f1bf977f53979429 commit 02094452c1bef7590bc74c11f1bf977f53979429 Author: perezju <perezju@chromium.org> Date: Tue Mar 14 10:26:12 2017 [tools/perf] Remove indexeddb_perf benchmark It has been superseded by storage.indexeddb_endure_tracing BUG= 669832 Review-Url: https://codereview.chromium.org/2746903003 Cr-Commit-Position: refs/heads/master@{#456666} [modify] https://crrev.com/02094452c1bef7590bc74c11f1bf977f53979429/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/02094452c1bef7590bc74c11f1bf977f53979429/testing/buildbot/chromium.perf.json [modify] https://crrev.com/02094452c1bef7590bc74c11f1bf977f53979429/tools/perf/benchmarks/indexeddb_perf.py
,
Mar 31 2017
Hi all, I just noticed #9 change was not reflected in PGO profiling scripts which are failing now. Those failures are probably silently ignored in your builds and went unnoticed. See https://chromium.googlesource.com/chromium/src/+/master/build/win/run_pgo_profiling_benchmarks.py and https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipe_modules/pgo/api.py
,
Mar 31 2017
Would it be enough to replace there 'indexeddb_perf' with 'storage.indexeddb_endure_tracing'? I'll fire up a CL to do that.
,
Mar 31 2017
CLs went out for review: https://codereview.chromium.org/2788643003/ https://chromium-review.googlesource.com/c/464767/
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b8d3e9460b771a757adfc985fa4d1d19bd2d55c commit 2b8d3e9460b771a757adfc985fa4d1d19bd2d55c Author: perezju <perezju@chromium.org> Date: Mon Apr 03 09:33:49 2017 [tools/perf] Remove remaining references to indexeddb_perf benchmark Benchmark does not exist any more. BUG= 669832 Review-Url: https://codereview.chromium.org/2788643003 Cr-Commit-Position: refs/heads/master@{#461393} [modify] https://crrev.com/2b8d3e9460b771a757adfc985fa4d1d19bd2d55c/build/win/run_pgo_profiling_benchmarks.py [modify] https://crrev.com/2b8d3e9460b771a757adfc985fa4d1d19bd2d55c/tools/auto_bisect/test_data/closed.json [modify] https://crrev.com/2b8d3e9460b771a757adfc985fa4d1d19bd2d55c/tools/perf/docs/perf_bot_sheriffing.md
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bcecde5341a48f99d6fb5708e509735468b005b0 commit bcecde5341a48f99d6fb5708e509735468b005b0 Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Tue Apr 04 08:41:22 2017 [pgo] Replace indexeddb_perf with storage.indexeddb_endure_tracing The indexeddb_perf has been removed. Bug:669832 Change-Id: If35614652d1f0e54f22d2f239addb6fffcaf33c0 Reviewed-on: https://chromium-review.googlesource.com/464767 Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/bcecde5341a48f99d6fb5708e509735468b005b0/scripts/slave/recipe_modules/pgo/api.py
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bcecde5341a48f99d6fb5708e509735468b005b0 commit bcecde5341a48f99d6fb5708e509735468b005b0 Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Tue Apr 04 08:41:22 2017 [pgo] Replace indexeddb_perf with storage.indexeddb_endure_tracing The indexeddb_perf has been removed. Bug:669832 Change-Id: If35614652d1f0e54f22d2f239addb6fffcaf33c0 Reviewed-on: https://chromium-review.googlesource.com/464767 Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/bcecde5341a48f99d6fb5708e509735468b005b0/scripts/slave/recipe_modules/pgo/api.py
,
Aug 30 2017
Hey, checking back on this again. Are you still missing some metrics from "storage.indexeddb_endure" which are not reported by "storage.indexeddb_endure_tracing"? We would like to remove the former which is still using a now deprecated version of the memory metric.
,
Aug 30 2017
,
Oct 30 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by perezju@chromium.org
, Nov 30 2016