New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669830 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature



Sign in to add a comment

Run WebRTC iOS simulator tests on Swarming

Project Member Reported by kjellander@chromium.org, Nov 30 2016

Issue description

In https://codereview.chromium.org/2455433002 the Chromium bots were migrated to swarming and it seems quite straight forward since we have a separate iOS recipe.

Right now, rolling chromium_revision in WebRTC DEPS is also blocked on a recent change [2] that made the -u flag become an error (which only happens for non-swarming bots).

[1] https://codereview.webrtc.org/2529293005/
[2] https://chromium.googlesource.com/chromium/src/+/276217cd97923c96f30654e6f459d23983855603

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/47f2f0742652bbad1b209642c7357ac0000469cf

commit 47f2f0742652bbad1b209642c7357ac0000469cf
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Nov 30 12:27:23 2016

WebRTC: Run iOS simulator tests on Swarming

Changes similar to https://codereview.chromium.org/2455433002 
This allows cleaning up the test() method of the
ios recipe module, since all users are using swarming.

BUG= 669830 

Change-Id: I3d95530994fb92af26f04dc0d4f2af0cd23cd381
Reviewed-on: https://chromium-review.googlesource.com/414378
Reviewed-by: smut <smut@google.com>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/47f2f0742652bbad1b209642c7357ac0000469cf/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/47f2f0742652bbad1b209642c7357ac0000469cf/scripts/slave/recipe_modules/ios/test_api.py
[modify] https://crrev.com/47f2f0742652bbad1b209642c7357ac0000469cf/scripts/slave/recipes/webrtc/ios.expected/basic.json
[delete] https://crrev.com/60f62cbe8858bd3a06adcb5e9bf51465b5a5c75b/scripts/slave/recipes/webrtc/ios.expected/infrastructure_failure.json
[modify] https://crrev.com/47f2f0742652bbad1b209642c7357ac0000469cf/scripts/slave/recipes/webrtc/ios.expected/no_tests.json
[delete] https://crrev.com/60f62cbe8858bd3a06adcb5e9bf51465b5a5c75b/scripts/slave/recipes/webrtc/ios.expected/test_failure.json
[modify] https://crrev.com/47f2f0742652bbad1b209642c7357ac0000469cf/scripts/slave/recipes/webrtc/ios.expected/trybot.json
[modify] https://crrev.com/47f2f0742652bbad1b209642c7357ac0000469cf/scripts/slave/recipes/webrtc/ios.py

Comment 2 by s...@google.com, Nov 30 2016

Issue 668301 has been merged into this issue.

Sign in to add a comment