Issue metadata
Sign in to add a comment
|
Regression: Unwanted traces is seen near 'Google Drive' text after closing the devtools window
Reported by
jshan...@etouch.net,
Nov 30 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2936.0 Revision 325a49517707810d1abdfb0040e19b7abb5addbe-refs/heads/master@{#434845} OS: Windows(7,8,10) Steps: 1. Launch Chrome and navigate to https://www.google.com/intl/en/drive/ 2. Click on lock icon and then click on 'Detail' link such that Devtools window is open 3. Now close devtools window and observe near 'Google Drive' text Actual: Unwanted broken focus ring and traces is seen near 'Google Drive' text after closing the devtools window. Expected: Broken focus ring and traces should not be seen near 'Google Drive' text after closing the devtools window. This is regression issue, broken in 'M-56', will soon update the bisect info: Good Build: 56.0.2902.0 Bad Build: 56.0.2904.0 Note: This issue is not seen on Mac and Linux OS.
,
Nov 30 2016
The suspecting cl is almost reverted by this newer one (with some new changes): https://codereview.chromium.org/2517663002/. So I suspect it should be caused by the new change. It is very convenient to identify the problem here. However, I don't have a windows dev machine. sky@, can you find another owner that can look into this? I am happy to discuss with him/her about my changes. My apologize for so many regressions here.
,
Nov 30 2016
Let me make a summary here: https://codereview.chromium.org/2371113003/ is landed before good build: 56.0.2902.0. https://codereview.chromium.org/2451323002 is detected as suspicious cl, this cl is not the same as tot any more, based on this change https://codereview.chromium.org/2517663002/. However it is landed on tot before 57.0.2936.0. So the regression gets bisected on the second cl still exists on the third cl. +albert, can I get a windows dev machine to detect the problem? I feel I should take the owner of this : )
,
Nov 30 2016
Sure. Just put in a request for an additional machine. I'll approve it. That will likely take more time than we want to wait for on this bug though. There used to be a few folks on the team who had Windows workstations for digging into issues like this. oshima@ or skuhne@ might have one.
,
Nov 30 2016
ok. Discussed with skuhne@, I will use his workstation for investigation.
,
Nov 30 2016
Cool. Go ahead and request one for yourself anyway. It's useful to have them around for when we need to dig into things on other platforms
,
Dec 3 2016
,
Jan 2 2017
warx@ - Friendly Ping...!! Could you please have a look into this issue. Thanks...!!
,
Jan 18 2017
Still able to reproduce the issue on Win 10.0 using latest chrome version 57.0.2984.0. @warx: please look into this issue. Thanks!
,
Jan 19 2017
I cannot repro as I cannot see "Detail" link. I guess I should build official chrome. Will investigate it asap.
,
Jan 20 2017
Even with an official chrome build, I can only see "Secure connection Your information (for example, passwords, or credit card numbers) is private when it is sent to this site. Learn more" "Learn more" is a link. If I click it, chrome will open a new tab. So, I still cannot repro by seeing the 'Detail' link.
,
Jan 20 2017
oh, btw, it seems can on longer be reproed on tot or m57, with this change ( issue 646465 ) landed on Nov 22.
,
Jan 20 2017
,
Jan 25 2017
As per comment #12, the issue is no more reproducible as the "Detail" link has been replaced with "Learn more". warx@ - Could you please confirm if this issue can be marked as wontFix? Thanks...!!
,
Jan 25 2017
m57 should be fine, m56 probably will still hit the issue. Sorry I have other higher priority work recently. I don't think this should be a 'wontfix'. 'Learn more' link just hides the bug. It may happen somewhere else.
,
Jan 25 2017
Remove m56 tag. m56 stable release will not have this issue since the CLs for 'learn more' are merged into m56.
,
Jan 25 2017
,
Jan 25 2017
On m56 without 'Learn more' CLs patched, I cannot see the bug. But with https://codereview.chromium.org/2517663002/ (which is landed and changes the suspecious CL) reverted, I can see the bug. So I think this bug should be fixed by https://codereview.chromium.org/2517663002/. For comment 9, I think it cannot happen... First, 'Learn more' is already landed in this version. Second, it should also be fixed by the above CL. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kkaluri@chromium.org
, Nov 30 2016Labels: hasbisect-per-revision
Owner: warx@chromium.org
Status: Assigned (was: Unconfirmed)