New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669795 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted traces is seen near 'Google Drive' text after closing the devtools window

Reported by jshan...@etouch.net, Nov 30 2016

Issue description

Chrome Version: 57.0.2936.0 Revision 325a49517707810d1abdfb0040e19b7abb5addbe-refs/heads/master@{#434845} 
OS: Windows(7,8,10)

Steps:
1. Launch Chrome and navigate to https://www.google.com/intl/en/drive/
2. Click on lock icon and then click on 'Detail' link such that Devtools window is open
3. Now close devtools window and observe near 'Google Drive' text 

Actual: Unwanted broken focus ring and traces is seen near 'Google Drive' text after closing the devtools window.

Expected: Broken focus ring and traces should not be seen near 'Google Drive' text after closing the devtools window.

This is regression issue, broken in 'M-56', will soon update the bisect info:

Good Build: 56.0.2902.0
Bad Build: 56.0.2904.0

Note: This issue is not seen on Mac and Linux OS.
 
Actual_video.mp4
755 KB View Download
Expected_video.mp4
659 KB View Download
Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: warx@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========

Good build : 56.0.2902.0,  Revision Range 427892
Bad build  : 56.0.2904.0,  Revision Range 428574

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/382935dbd3ba549c331873c075b18bdf3b6faffc..c5e551b4da8b4bf7cc8fcfbdff3a052f19619bf3

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/c5e551b4da8b4bf7cc8fcfbdff3a052f19619bf3

From the above CL suspecting the below change
---------------------------
https://codereview.chromium.org/2451323002


warx@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 2 by warx@chromium.org, Nov 30 2016

Cc: sky@chromium.org
The suspecting cl is almost reverted by this newer one (with some new changes): https://codereview.chromium.org/2517663002/. So I suspect it should be caused by the new change. It is very convenient to identify the problem here. However, I don't have a windows dev machine.

sky@, can you find another owner that can look into this? I am happy to discuss with him/her about my changes. My apologize for so many regressions here.

Comment 3 by warx@chromium.org, Nov 30 2016

Cc: abodenha@chromium.org
Let me make a summary here:

https://codereview.chromium.org/2371113003/ is landed before good build: 56.0.2902.0.

https://codereview.chromium.org/2451323002 is detected as suspicious cl, this cl is not the same as tot any more, based on this change https://codereview.chromium.org/2517663002/. However it is landed on tot before 57.0.2936.0.

So the regression gets bisected on the second cl still exists on the third cl.

+albert, can I get a windows dev machine to detect the problem? I feel I should take the owner of this : )
Sure. Just put in a request for an additional machine. I'll approve it. That will likely take more time than we want to wait for on this bug though.

There used to be a few folks on the team who had Windows workstations for digging into issues like this. oshima@ or skuhne@ might have one.

Comment 5 by warx@chromium.org, Nov 30 2016

Status: Started (was: Assigned)
ok. Discussed with skuhne@, I will use his workstation for investigation.
Cool.

Go ahead and request one for yourself anyway. It's useful to have them around for when we need to dig into things on other platforms
Components: -Blink Platform>DevTools
warx@ - Friendly Ping...!!

Could you please have a look into this issue.

Thanks...!!
Cc: rbasuvula@chromium.org
Still able to reproduce the issue on Win 10.0 using latest chrome version 57.0.2984.0.

@warx: please look into this issue.

Thanks!

Comment 10 by warx@chromium.org, Jan 19 2017

I cannot repro as I cannot see "Detail" link. I guess I should build official chrome. Will investigate it asap.

Comment 11 by warx@chromium.org, Jan 20 2017

Even with an official chrome build, I can only see

"Secure connection
Your information (for example, passwords, or credit card numbers) is private when it is sent to this site. Learn more"

"Learn more" is a link. If I click it, chrome will open a new tab.

So, I still cannot repro by seeing the 'Detail' link.

Comment 12 by warx@chromium.org, Jan 20 2017

Cc: -abodenha@chromium.org lgar...@chromium.org
oh, btw, it seems can on longer be reproed on tot or m57, with this change ( issue 646465 ) landed on Nov 22.

Comment 13 by warx@chromium.org, Jan 20 2017

Cc: abodenha@chromium.org
Cc: krajshree@chromium.org
Labels: Needs-Feedback
As per comment #12, the issue is no more reproducible as the "Detail" link has been replaced with "Learn more".

warx@ - Could you please confirm if this issue can be marked as wontFix?

Thanks...!!

Comment 15 by warx@chromium.org, Jan 25 2017

m57 should be fine, m56 probably will still hit the issue. Sorry I have other higher priority work recently.

I don't think this should be a 'wontfix'. 'Learn more' link just hides the bug. It may happen somewhere else.

Comment 16 by warx@chromium.org, Jan 25 2017

Labels: -M-56
Remove m56 tag. m56 stable release will not have this issue since the CLs for 'learn more' are merged into m56.

Comment 17 by warx@chromium.org, Jan 25 2017

Labels: -Pri-1 Pri-3

Comment 18 by warx@chromium.org, Jan 25 2017

Status: WontFix (was: Started)
On m56 without 'Learn more' CLs patched, I cannot see the bug. But with https://codereview.chromium.org/2517663002/ (which is landed and changes the suspecious CL) reverted, I can see the bug.

So I think this bug should be fixed by https://codereview.chromium.org/2517663002/.

For comment 9, I think it cannot happen... First, 'Learn more' is already landed in this version. Second, it should also be fixed by the above CL.


Sign in to add a comment