New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669778 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Focus ring is stuck on previous option even after clicking on any other option in origin info bubble

Reported by jshan...@etouch.net, Nov 30 2016

Issue description

Chrome Version: 57.0.2936.0 (Official Build) 325a49517707810d1abdfb0040e19b7abb5addbe-refs/heads/master@{#434845}-32/64 bit
OS: Windows (7,8,8.1,10),Linux(Ubuntu 14.04 LTS)

Precondition: Enabled Material Design in the rest of the browser's native UI flag from chrome://flags.

Steps:
1. Launch Chrome and navigate to any web page like https://www.google.com/intl/en/chrome/browser/welcome.html
2. Click on lock icon of omnibox and press tab key till focus ring is seen on first permission-'Location' of origin info bubble
3. Now click on any other permission drop down like Camera, Microphone, etc and observe.

Actual: Focus ring is stuck on previous option even after clicking on any other permission

Expected: Focus ring should not get stuck on previous option after clicking on any other permission

This is a regression issue broken in M-55, will soon update the bisect info:

Good Build: 55.0.2846.0
Bad Build: 55.0.2847.0

Note: Above issue is not seen on Mac OS.

 
Actual_video.mp4
582 KB View Download
Expected_video.mp4
559 KB View Download
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2846.0 (Revision: 415833).
Bad build: 55.0.2847.0 (Revision: 416149).

You are probably looking for a change made after 416109 (known good), but no later than 416110 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82..76d2f690c72864d90d77b3157e72b2a8f8cf0f72

@estade -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression.
Thank You.
Cc: ranjitkan@chromium.org pbomm...@chromium.org brajkumar@chromium.org
Adding M-55 stability owners.

Comment 4 by gov...@chromium.org, Nov 30 2016

Cc: dbeam@chromium.org michae...@chromium.org tommycli@chromium.org
We're cutting M55 Stable RC today for release this week. Please let us know ASAP if this is indeed Stable blocker. Thank you.
Labels: -ReleaseBlock-Stable M-57
Please don't mark the bugs which are reported using Material design flags as blockers, Since the feature is behind the flag.

estade@ please correct me if I am wrong, I am removing the stable blocker label.

Comment 6 by est...@chromium.org, Nov 30 2016

Labels: -Pri-1 -Proj-MaterialDesign-WebUI -M-55 Proj-MaterialDesign-NativeUI Pri-2
Owner: shrike@chromium.org
comment 5 is correct
Gentle ping!!

Still we are able to reproduce the issue on Windows 7-with Chrome Latest canary #57.0.2939.0.

Shrike@ Could you please look into this issue.

Thank you.

Comment 8 by hdodda@chromium.org, Jan 16 2017

Gentle ping!!

Still we are able to reproduce the issue on Windows 10 with Chrome Latest canary #57.0.2983.0.

Shrike@ Could you please look into this issue.

Thank you.

Comment 9 by shrike@chromium.org, Jan 16 2017

Owner: pkasting@chromium.org
-> pkasting@ for assignment.
Owner: ellyjo...@chromium.org
Elly has been working on this dialog.
Hm, the difference is because in non-Harmony mode on Linux/Win, this dialog uses MenuButtons instead of Comboboxes. MenuButtons support taking focus on press, and this dialog enables that behavior, but Comboboxes do not. I'm not sure if taking focus on mouse press is actually the right behavior, though... certainly Mac apps do not behave that way.
Status: Started (was: Assigned)
https://codereview.chromium.org/2739893003/
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0edc14c6fae6412feb1fabdef2d7e3372cd86dd

commit a0edc14c6fae6412feb1fabdef2d7e3372cd86dd
Author: ellyjones <ellyjones@chromium.org>
Date: Fri Mar 10 17:20:59 2017

views: make comboboxes request focus when clicked

They should behave this way on non-Mac, even in Harmony mode.

BUG= 669778 

Review-Url: https://codereview.chromium.org/2739893003
Cr-Commit-Position: refs/heads/master@{#456086}

[modify] https://crrev.com/a0edc14c6fae6412feb1fabdef2d7e3372cd86dd/ui/views/controls/combobox/combobox.cc

Status: Fixed (was: Started)

Sign in to add a comment