New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 669774 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Dec 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary traces is seen on 'www.united.com' while scrolling the page.

Reported by dmascare...@etouch.net, Nov 30 2016 
Chrome Version:57.0.2936.0 (Official Build) 325a49517707810d1abdfb0040e19b7abb5addbe-refs/heads/master@{#434845}
OS: Windows (7,8,10),Linux

What steps will reproduce the problem?
1. Launch chrome and navigate to https://www.united.com/ual/en/us/
2. Scroll down the page and observe.

Actual: Unnecessary white line traces beside 'Feedback' button is seen.
Expected: Traces should not be seen.

This is regression issue, broken in 'M 56' and below is manual bisect info:
Good build:56.0.2888.0 
Bad build:56.0.2890.0 

Note: Issue is not seen on Mac OS.
Actual_traces.png
823 KB View Download

Comment 1 by msrchandra@chromium.org, Nov 30 2016

Labels: hasbisect-per-revision
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2888.0 (Revision: 424625).
Bad build: 56.0.2890.0 (Revision: 425218).

You are probably looking for a change made after 424969 (known good), but no later than 424970 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/59e31971365b1085fc53a60f0c8228894869ae49..67c516aaed2486295a98d7f0ff2235b921cd7933

@wangxianzhu -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.

Comment 2 by giol...@gmail.com, Nov 30 2016 

sweetalert same problem.
I think there is a render problem because line height is sometimes very small and sometimes it automatically hides
2016-11-30_14-10-15.png
31.7 KB View Download

Comment 3 by giol...@gmail.com, Nov 30 2016 

My system is win 7 x64
Chrome 54.0.2840.99 m

Comment 4 by wangxianzhu@chromium.org, Nov 30 2016 

giolaza@ thanks for reporting the issue. Based on regression range, it looks a different issue. Can you file another bug (http://crbug.com/new) with steps of reproduction? Thanks.

Comment 5 by wangxianzhu@chromium.org, Nov 30 2016 

giolaza@ please don't mind #4. The issues looks related because you mentioned line height. The m56 regression might be just a exposure of an old issue. Do you have a test page of the issue of sweetalert?

Comment 6 by wangxianzhu@chromium.org, Nov 30 2016 

Reduced test case
ua.html
309 bytes View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4774275d950261bf9ef99c55b326979298b5c558

commit 4774275d950261bf9ef99c55b326979298b5c558
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Dec 01 19:29:57 2016

Revert of Don't expand empty rect during rect mapping (patchset #4 id:60001 of https://codereview.chromium.org/2416693002/ )

Reason for revert:
It changed
  transform->mapRect(enclosingIntRect(rect))
to
  transform->mapRect(FloatRect(enclosingIntRect(rect)))
causing missing enclosingIntRect() after the transform.

We may also need enclosingIntRect for empty rects because even empty
object can have visible filter depending on pixel snapping here.

BUG= 669774 
TEST=paint/invalidation/rotated-subpixel.html

Original issue's description:
> Don't expand empty rect during rect mapping
>
> For example, enclosingIntRect(LayoutRect(0.5, 0.5, 0, 0)) results
> IntRect(0, 0, 1, 1). This causes unnecessary non-empty visual rects
> mapped from empty LayoutRects.
>
> This CL is mainly to reduce the difference between the old path and
> slimmingPaintInvalidation with pixel snapping feature.
>
> Committed: https://crrev.com/67c516aaed2486295a98d7f0ff2235b921cd7933
> Cr-Commit-Position: refs/heads/master@{#424970}

TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2545573002
Cr-Commit-Position: refs/heads/master@{#435677}

[add] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel-expected.png
[add] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel-expected.txt
[add] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel.html
[modify] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/platform/win/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/4774275d950261bf9ef99c55b326979298b5c558/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Comment 8 by wangxianzhu@chromium.org, Dec 1 2016

Labels: Merge-Request-56

Comment 9 by dimu@chromium.org, Dec 2 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 2 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe9b64b273d368f2f0cc8053c75b52346815c2a1

commit fe9b64b273d368f2f0cc8053c75b52346815c2a1
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Dec 02 18:57:18 2016

Revert of Don't expand empty rect during rect mapping (patchset #4 id:60001 of https://codereview.chromium.org/2416693002/ )

Reason for revert:
It changed
  transform->mapRect(enclosingIntRect(rect))
to
  transform->mapRect(FloatRect(enclosingIntRect(rect)))
causing missing enclosingIntRect() after the transform.

We may also need enclosingIntRect for empty rects because even empty
object can have visible filter depending on pixel snapping here.

BUG= 669774 
TEST=paint/invalidation/rotated-subpixel.html

Original issue's description:
> Don't expand empty rect during rect mapping
>
> For example, enclosingIntRect(LayoutRect(0.5, 0.5, 0, 0)) results
> IntRect(0, 0, 1, 1). This causes unnecessary non-empty visual rects
> mapped from empty LayoutRects.
>
> This CL is mainly to reduce the difference between the old path and
> slimmingPaintInvalidation with pixel snapping feature.
>
> Committed: https://crrev.com/67c516aaed2486295a98d7f0ff2235b921cd7933
> Cr-Commit-Position: refs/heads/master@{#424970}

TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2547093002 .

Review-Url: https://codereview.chromium.org/2545573002
Cr-Original-Commit-Position: refs/heads/master@{#435677}
Cr-Commit-Position: refs/branch-heads/2924@{#293}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[add] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel-expected.png
[add] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel-expected.txt
[add] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel.html
[modify] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/platform/win/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/fe9b64b273d368f2f0cc8053c75b52346815c2a1/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Comment 11 by wangxianzhu@chromium.org, Dec 2 2016

Status: Fixed (was: Assigned)
giolaza@gmail.com after investigation, I believe that your reported issue is different. Could you please file another bug (http://crbug.com/new) with steps of reproduction? Thanks.
►

Sign in to add a comment