AnimationHost should have a list of active AnimationPlayers. ElementAnimations shouldn't be a ref-count class.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7592f02242026970af0a6425928e5271a52f79d commit e7592f02242026970af0a6425928e5271a52f79d Author: loyso <loyso@chromium.org> Date: Thu Dec 01 00:48:59 2016 CC Animation: Make AnimationPlayer to be a unit of activation. (Was ElementAnimation previously). It allows us to avoid inconsistencies in UpdateActivation process and ElementAnimation's data. Removes redundant last_tick_time_. As a result, ElementAnimation should become a lightweight passive object which holds per-Element animation data. BUG= 669755 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2538973002 Cr-Commit-Position: refs/heads/master@{#435503} [modify] https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d/cc/animation/animation_host.cc [modify] https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d/cc/animation/animation_host.h [modify] https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d/cc/animation/animation_player.cc [modify] https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d/cc/animation/animation_player.h [modify] https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d/cc/animation/element_animations.cc [modify] https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d/cc/animation/element_animations.h [modify] https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d/cc/test/layer_tree_test.cc [modify] https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d/cc/trees/layer_tree_host_unittest_animation.cc
Update: We can leave ElementAnimations as a ref-count class. We will want to store a reference to it one day. scoped_refptr<cc::ElementAnimations> blink::ElementAnimations::m_compositorElementAnimations for example.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a90a138797c24f8e19811717962f66b67388d97b commit a90a138797c24f8e19811717962f66b67388d97b Author: loyso <loyso@chromium.org> Date: Wed Dec 07 02:07:21 2016 CC Animation: Rename Active Players to Ticking Players. To avoid confusion with active/pending trees in LTH and tree activation process. BUG= 669755 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2554773002 Cr-Commit-Position: refs/heads/master@{#436834} [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/animation/animation_host.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/animation/animation_host.h [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/animation/animation_player.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/animation/animation_player.h [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/animation/element_animations.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/animation/element_animations.h [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/blink/web_layer_impl.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/blink/web_layer_impl.h [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/layers/layer.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/layers/layer.h [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/test/animation_timelines_test_common.h [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/test/layer_tree_test.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/trees/layer_tree_host_in_process.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/cc/trees/mutator_host.h [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/third_party/WebKit/public/platform/WebLayer.h [modify] https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b/ui/compositor/layer_animator_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Dec 1 2016