New issue
Advanced search Search tips

Issue 669731 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

update-w3c-deps: Crash by web-platform-tests/domxapth/xml_xpath_tests.xml

Project Member Reported by tkent@chromium.org, Nov 30 2016

Issue description

What steps will reproduce the problem?
(1) Enable domxpath/xml_xpath_tests.xml in LayoutTests/W3CImportExpectations
(2) run "update-w3c-deps wpt"

What is the expected result?
The command succeeds.

What happens instead?
The command fails.

# err>   scanning wpt/domxpath/...
# err> Traceback (most recent call last):
# err>   File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/import-w3c-tests", line 35, in <module>
# err>     sys.exit(test_importer.main(sys.argv[1:], sys.stdout, sys.stderr))
# err>   File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 99, in main
# err>     test_importer.do_import()
# err>   File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 167, in do_import
# err>     self.find_importable_tests()
# err>   File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 246, in find_importable_tests
# err>     test_parser = TestParser(fullpath, self.host)
# err>   File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py", line 47, in __init__
# err>     self.load_file(filename)
# err>   File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py", line 52, in load_file
# err>     doc = BeautifulSoup(self.filesystem.read_binary_file(filename).decode("utf-8"))
# err>   File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1519, in __init__
# err>     BeautifulStoneSoup.__init__(self, *args, **kwargs)
# err>   File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1144, in __init__
# err>     self._feed(isHTML=isHTML)
# err>   File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1186, in _feed
# err>     SGMLParser.feed(self, markup)
# err>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/sgmllib.py", line 104, in feed
# err>     self.goahead(0)
# err>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/sgmllib.py", line 143, in goahead
# err>     k = self.parse_endtag(i)
# err>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/sgmllib.py", line 320, in parse_endtag
# err>     self.finish_endtag(tag)
# err>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/sgmllib.py", line 358, in finish_endtag
# err>     method = getattr(self, 'end_' + tag)
# err> UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 5: ordinal not in range(128)


Please use labels and text to provide additional information.

xml_xpath_tests.xml is a data file for the test xml_xpath_runner.html.  It is encoded in UTF-8, but it has no XML encoding declaration.

 

Comment 1 by tkent@chromium.org, Nov 30 2016

Status: WontFix (was: Untriaged)
I was wrong.  xml_xpath_test.xml wasn't a culprit.  001.html and 002.html have wrong charset values.

Sign in to add a comment