Issue 669705 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	jamescook@chromium.org
Closed:	Dec 2016
Cc:	█ roc...@chromium.org sky@chromium.org mustash-bugs@google.com
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
Proj-Mustash-Mash VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Chrome crashes when run with --mash --mash (twice)

Project Member Reported by jamescook@chromium.org, Nov 29 2016

Issue description

I hit this problem when running on device with /etc/chrome_dev.conf containing --mash and a dbus-send command to restart chrome that also included --mash.

You can repro on Linux desktop:
 out/Default/chrome --user-data-dir=/tmp/empty --mash --mash

[5656:5656:1129/152438:FATAL:screen_locker.cc(392)] Check failed: g_screen_lock_observer. 
#0 0x7f212f17e59e base::debug::StackTrace::StackTrace()
#1 0x7f212f1a032a logging::LogMessage::~LogMessage()
#2 0x7f21301c125e chromeos::ScreenLocker::ShutDownClass()
#3 0x7f21300fe270 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun()
#4 0x7f212cac9042 content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
#5 0x7f212cacba37 content::BrowserMainRunnerImpl::Shutdown()
#6 0x7f212cac4779 content::BrowserMain()
#7 0x7f212d22cf93 content::ContentMainRunnerImpl::Run()
#8 0x7f212d22ba10 content::ContentMain()
#9 0x7f212fd5d173 ChromeMain
#10 0x7f21263d2f45 __libc_start_main
#11 0x7f212fd5d011 <unknown>

It looks like Chrome is trying to shut itself down immediately after launch.

In theory we should never have duplicate --mash command line flags, but this behavior is different than other flags (most other ones can be doubled with no effect).

Maybe this code should remove all instances of --mash from the command line, not just the first?

https://cs.chromium.org/chromium/src/chrome/app/mash/mash_runner.cc?q=%22--mash%22&sq=package:chromium&dr=C&l=109

Comment 1 by jamescook@chromium.org, Dec 1 2016

Status: Started (was: Assigned)

CL out for review: https://codereview.chromium.org/2545633002

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e498622015dd9b7355fc941c1e5837ff104ac9e2

commit e498622015dd9b7355fc941c1e5837ff104ac9e2
Author: jamescook <jamescook@chromium.org>
Date: Thu Dec 01 18:37:30 2016

Tolerate more than one copy of the --mash command line switch

It's common to add --mash to the /etc/chrome_dev.conf when working on a
Chrome OS device. However, that can lead to two copies of --mash if you run
an autotest on the device that also passes --mash. This makes Chrome crash.

Ignore duplicate --mash flags.

BUG= 669705 
TEST=Run chrome --mash --mash, doesn't crash.

Review-Url: https://codereview.chromium.org/2545633002
Cr-Commit-Position: refs/heads/master@{#435655}

[modify] https://crrev.com/e498622015dd9b7355fc941c1e5837ff104ac9e2/chrome/app/mash/mash_runner.cc