Allow paused download to resume from download home |
||||
Issue descriptionCurrently when resuming a download from download home, chrome need to know the notification ID so that it will not post a new notification.
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/927312747a47d9aef1b08217f590c6b83c13e174 commit 927312747a47d9aef1b08217f590c6b83c13e174 Author: qinmin <qinmin@chromium.org> Date: Wed Nov 30 15:35:35 2016 Add paused download into SharedPreferences When download is manually paused, currently it is not stored in SharedPreferences. This is reasonable if download can only be resumed from the notification. However, with download home, resuming a paused download will require Chrome to know the notification Id. This CL stores the paused download into SharedPreferences. So that the notification Id can be retrieved when resuming a download from download Home. BUG= 669702 Review-Url: https://codereview.chromium.org/2542483002 Cr-Commit-Position: refs/heads/master@{#435266} [modify] https://crrev.com/927312747a47d9aef1b08217f590c6b83c13e174/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/927312747a47d9aef1b08217f590c6b83c13e174/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java [modify] https://crrev.com/927312747a47d9aef1b08217f590c6b83c13e174/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java [modify] https://crrev.com/927312747a47d9aef1b08217f590c6b83c13e174/chrome/android/junit/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntryTest.java
,
Nov 30 2016
Are we targeting for M56 or M57?
,
Nov 30 2016
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06274d14c37bebbf2e5c4acf9b0bce24ca7f2c17 commit 06274d14c37bebbf2e5c4acf9b0bce24ca7f2c17 Author: qinmin <qinmin@chromium.org> Date: Thu Dec 01 17:34:39 2016 Remove unnecessary extra field from download notification intent Chrome stores those information in SharedPreferences for all downloads now. So there is no need to keep those extra fields. BUG= 669702 Review-Url: https://codereview.chromium.org/2544633003 Cr-Commit-Position: refs/heads/master@{#435639} [modify] https://crrev.com/06274d14c37bebbf2e5c4acf9b0bce24ca7f2c17/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
,
Jan 3 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by qin...@chromium.org
, Nov 29 2016