New issue
Advanced search Search tips

Issue 669678 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 828176



Sign in to add a comment

Detect H264 slices of the same frame in VEAUnittest

Project Member Reported by emir...@chromium.org, Nov 29 2016

Issue description

Currently, we treat every IDR/NonIDR slice coming from encoded H264 data as a new frame in VideoEncodeAcceleratorUnittest. This may not be the case, i.e. Mac and Win, and we needs checks like H264Decoder::IsNewPrimaryCodedPicture() to determine if we are in a new frame.

https://cs.chromium.org/chromium/src/media/gpu/video_encode_accelerator_unittest.cc?rcl=0&l=640
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e80ab729b5fbe7b6ee7cf44551b0412a2e03f51f

commit e80ab729b5fbe7b6ee7cf44551b0412a2e03f51f
Author: emircan <emircan@chromium.org>
Date: Thu Feb 16 20:27:49 2017

Detect H264 slices of the same frame in VEAUnittest

This CL adds checks similar to H264Decoder::IsNewPrimaryCodedPicture() to
determine if the given H264 slice belongs to a new frame. On Mac and Win,
we can have multiple slices per frame and this causes problems.

Note that after this fix, I will add this test to chromium.gpu.fyi Mac bots.
Windows will follow when bots get upgraded to Win 8.1.

BUG= 669678 
TEST=Tested VEAUnittest on Macbook Air 2013.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2538883002
Cr-Commit-Position: refs/heads/master@{#451086}

[modify] https://crrev.com/e80ab729b5fbe7b6ee7cf44551b0412a2e03f51f/media/gpu/BUILD.gn
[modify] https://crrev.com/e80ab729b5fbe7b6ee7cf44551b0412a2e03f51f/media/gpu/h264_decoder.cc
[modify] https://crrev.com/e80ab729b5fbe7b6ee7cf44551b0412a2e03f51f/media/gpu/h264_decoder.h
[modify] https://crrev.com/e80ab729b5fbe7b6ee7cf44551b0412a2e03f51f/media/gpu/video_encode_accelerator_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43364fb75871b5f530f4a63d8f78fe7a3134efbb

commit 43364fb75871b5f530f4a63d8f78fe7a3134efbb
Author: kcwu <kcwu@chromium.org>
Date: Mon Feb 20 07:22:34 2017

Revert of Detect H264 slices of the same frame in VEAUnittest (patchset #6 id:140001 of https://codereview.chromium.org/2538883002/ )

Reason for revert:
This CL breaks many CTS/GTS tests.  crbug.com/694094 

Original issue's description:
> Detect H264 slices of the same frame in VEAUnittest
>
> This CL adds checks similar to H264Decoder::IsNewPrimaryCodedPicture() to
> determine if the given H264 slice belongs to a new frame. On Mac and Win,
> we can have multiple slices per frame and this causes problems.
>
> Note that after this fix, I will add this test to chromium.gpu.fyi Mac bots.
> Windows will follow when bots get upgraded to Win 8.1.
>
> BUG= 669678 
> TEST=Tested VEAUnittest on Macbook Air 2013.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2538883002
> Cr-Commit-Position: refs/heads/master@{#451086}
> Committed: https://chromium.googlesource.com/chromium/src/+/e80ab729b5fbe7b6ee7cf44551b0412a2e03f51f

TBR=posciak@chromium.org,wuchengli@chromium.org,emircan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 694094 

Review-Url: https://codereview.chromium.org/2707793002
Cr-Commit-Position: refs/heads/master@{#451575}

[modify] https://crrev.com/43364fb75871b5f530f4a63d8f78fe7a3134efbb/media/gpu/BUILD.gn
[modify] https://crrev.com/43364fb75871b5f530f4a63d8f78fe7a3134efbb/media/gpu/h264_decoder.cc
[modify] https://crrev.com/43364fb75871b5f530f4a63d8f78fe7a3134efbb/media/gpu/h264_decoder.h
[modify] https://crrev.com/43364fb75871b5f530f4a63d8f78fe7a3134efbb/media/gpu/video_encode_accelerator_unittest.cc

Status: Started (was: Fixed)
Blocking: 828176
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e43ad9814b8a1eda2416af7b73e15b44ad0ff400

commit e43ad9814b8a1eda2416af7b73e15b44ad0ff400
Author: Emircan Uysaler <emircan@chromium.org>
Date: Thu Apr 05 22:32:09 2018

Detect H264 slices of the same frame in VEAUnittest

This CL is based on https://codereview.chromium.org/2538883002/.

This CL adds checks similar to H264Decoder::IsNewPrimaryCodedPicture() to
determine if the given H264 slice belongs to a new frame. On Mac and Win,
we can have multiple slices per frame and this causes problems.

Bug:  669678 , 828176
Test: Tested VEAUnittest on MBP 2016.
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4781bacd199ae0545a3f46b37765b126f947b92e
Reviewed-on: https://chromium-review.googlesource.com/991198
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548590}
[modify] https://crrev.com/e43ad9814b8a1eda2416af7b73e15b44ad0ff400/media/gpu/h264_decoder.cc
[modify] https://crrev.com/e43ad9814b8a1eda2416af7b73e15b44ad0ff400/media/gpu/h264_decoder.h
[modify] https://crrev.com/e43ad9814b8a1eda2416af7b73e15b44ad0ff400/media/gpu/video_encode_accelerator_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment