Overlay scrollbars shouldn't expand together |
|||||
Issue descriptionVersion: 57.0.2936.0 OS: ChromeOS What steps will reproduce the problem? (0) Ensure overlay scrollbars are enabled (1) Visit a page with both vertical and horizontal scrolling: e.g. paste this into the URL bar: data:text/html;charset=utf8,<div style="height: 6000px;width:6000px"> (2) Scroll to show the scrollbars (3) Mouse over the vertical scrollbar so that it expands. What is the expected result? The vertical scrollbar only should expand What happens instead? Both scrollbars expand
,
Nov 29 2016
Chao, this one might be a little tricky since you'll have to split up the effect application between the scrollbars.
,
Dec 6 2016
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3 commit 2c3e1700308bc1756a408cfac4b5cfa5f84da0a3 Author: chaopeng <chaopeng@chromium.org> Date: Fri Jan 27 04:46:02 2017 Prevent overlay scrollbars expand or hover together Overlay scrollbars will expand and hover together because we use same state to calculate two scrollbars' animation. In this patch, we separate responsibilities of ScrollbarAnimationControllerThinning. We keep fade in/out animation stills in ScrollbarAnimationControllerThinning and move thinning animation to SingleScrollbarAnimationControllerThinning. BUG= 669677 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2554913002 Cr-Commit-Position: refs/heads/master@{#446594} [modify] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/BUILD.gn [modify] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/input/scrollbar_animation_controller.cc [modify] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/input/scrollbar_animation_controller.h [modify] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/input/scrollbar_animation_controller_linear_fade.h [modify] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/input/scrollbar_animation_controller_thinning.cc [modify] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/input/scrollbar_animation_controller_thinning.h [modify] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/input/scrollbar_animation_controller_thinning_unittest.cc [add] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/input/single_scrollbar_animation_controller_thinning.cc [add] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/input/single_scrollbar_animation_controller_thinning.h [add] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/input/single_scrollbar_animation_controller_thinning_unittest.cc [modify] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/2c3e1700308bc1756a408cfac4b5cfa5f84da0a3/cc/trees/layer_tree_host_impl_unittest.cc
,
Jan 27 2017
,
Apr 17 2017
,
May 9 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bokan@chromium.org
, Nov 29 2016Status: Assigned (was: Untriaged)