New issue
Advanced search Search tips

Issue 669675 link

Starred by 4 users
Status: WontFix
Owner:
chaopeng@chromium.org
Closed: Apr 2017
Cc:
sahel@chromium.org
tbuck...@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 307091



Sign in to add a comment

Overlay scrollbar stroke width should be 1 physical pixel thick

Project Member Reported by bokan@chromium.org, Nov 29 2016 
Version: 57.0.2936.0
OS: ChromeOS

What steps will reproduce the problem?
(1) Ensure overlay scrollbars are turned on
(2) Visit https://material.io/
(3) Scroll to show the scrollbar over a dark area, mouse over to expand

What is the expected result?
The stroke outline on the scrollbar should be 1 physical pixel wide.

What happens instead?
On a Pixel or hiDPI device where devicePixelRatio == 2, the stroke is 2 physical pixels (1 DIP).

Comment 1 by bokan@chromium.org, Nov 29 2016

Owner: sahel@chromium.org
Status: Assigned (was: Available)
This one's also in https://cs.chromium.org/chromium/src/ui/native_theme/native_theme_aura.cc?q=NativeThemeAura&sq=package:chromium&l=222

I suspect you'll have to either set the stroke width to be divided by the devicePixelRatio (not sure how to get that from there, perhaps the skCanvas has that info) or the SkPaint has some kind of "hairline" or specific way to stroke in physical pixels.

Comment 2 by bokan@chromium.org, Dec 8 2016

Cc: sahel@chromium.org
Owner: bokan@chromium.org
Actually, I'll take this since I'll be mucking about with scrollbar painting for  issue 669670

Comment 3 by chaopeng@chromium.org, Mar 30 2017

Owner: chaopeng@chromium.org
Status: Started (was: Assigned)

Comment 4 by chaopeng@chromium.org, Apr 3 2017 

I think we already using 1 physical pixel.
Screenshot 2017-04-03 at 10.32.01 AM.png
2.7 MB View Download

Comment 5 by bokan@chromium.org, Apr 3 2017

Status: WontFix (was: Started)
Thanks for checking - screenshot does show 1 physical pixel. Not sure how I concluded it was 2 last time I tried this but lets move on.
►

Sign in to add a comment