Overlay scrollbars should be flush with window edge |
|||||||||||||
Issue descriptionVersion: 57.0.2936.0 OS: ChromeOS What steps will reproduce the problem? (1) Ensure overlay scrollbars are turned on (2) Visit https://material.io/ (3) Scroll to show the scrollbars over a dark area What is the expected result? There should be no stroke on the right side of the scrollbar
,
Dec 8 2016
Actually, I'll take this since I'll be mucking about with scrollbar painting for issue 669670
,
Mar 15 2017
Is this screenshot meet the expectation?
,
Mar 15 2017
Yes. Can we apply the same treatment for top/bottom edge as well ? I forgot to add that in the bug.
,
Mar 15 2017
sgabriel@, sorry, I do not get it. Do you mean no right, top and bottom strokes for right vertical scrollbar? No left, top and bottom strokes for right vertical scrollbar. No left, right and bottom strokes for bottom horizontal scrollbar.
,
Mar 15 2017
Sorry I mean what that the top stroke goes "under" the chrome ui when scrolled all the way up. The bottom Chrome goes "out of the window" when scrolled all the way down (and if no horizontal scrollbar is present). For horizontal, this applies to the left stroke and white stroke. See visual attached for the right aligned, scrolled all the way up vertical scrollbar.
,
Mar 20 2017
sgabriel@ should all scrollbars looks like this or only the root scrollbar?
,
Mar 20 2017
Sorry not sure what's root scrollbar and what's not. Can you explain ?
,
Mar 20 2017
I mean the scrollbars for root frame/window and others are scrollbars for div, iframe. Here is the look of scrollbars for div https://jsfiddle.net/90hxrv80/
,
Mar 20 2017
Thanks. They should follow the same pattern if possible so they should go -1px out of the top/down/etc.. of the div/iframe when all the way up/down/etc...
,
Mar 22 2017
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/609da81d151f9eb3bcc94852f10e4ebb649a5bed commit 609da81d151f9eb3bcc94852f10e4ebb649a5bed Author: chaopeng <chaopeng@chromium.org> Date: Wed Mar 29 23:00:55 2017 Overlay scrollbars flush with window edge In this patch, remove right stroke for vertical scrollbar, remove bottom stroke for horizontal scrollbar and flip the scrollbar canvas to remove left stroke for left vertical scrollbar. BUG=669673 Review-Url: https://codereview.chromium.org/2763373002 Cr-Commit-Position: refs/heads/master@{#460565} [modify] https://crrev.com/609da81d151f9eb3bcc94852f10e4ebb649a5bed/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp [modify] https://crrev.com/609da81d151f9eb3bcc94852f10e4ebb649a5bed/ui/native_theme/native_theme_aura.cc
,
Mar 29 2017
,
May 9 2017
Attached screenshot from https://material.io/ website on TOT 9534.0.0, 60.0.3092.0 Comparing with comparison.png attached in c#6, looks like this is still an issue. Reopening the bug. Please close if it is WAI.
,
May 9 2017
We do not flush the top and bottom edge for vertical scrollbar because it will cause re-paint.
,
May 9 2017
Note: we could do this on the compositor without a repaint by adjusting the scrollbar limits but we can't do that for M59. I do think we'll want that eventually though.
,
May 10 2017
In that case, let's leave this open.
,
Aug 2 2017
This would be nice to do as a polish fixup but isn't blocking shipping.
,
Aug 2 2017
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by bokan@chromium.org
, Nov 29 2016Status: Assigned (was: Available)