New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 669650 link

Starred by 1 user
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: Feb 2018
Cc:
dtapu...@chromium.org
█ chongz@chromium.org
█ dtoybo...@gmail.com
garykac@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 662011


Sign in to add a comment

Map AKEYCODE_KANA (218) to "KanjiMode"

Project Member Reported by chongz@chromium.org, Nov 29 2016 
Current spec maps AKEYCODE_KANA to "KanaMode", however according to https://github.com/w3c/uievents-key/issues/30 we might want to change the spec.

This bug depends on the spec issue.

Comment 1 by chongz@chromium.org, Jan 11 2018

Cc: chongz@chromium.org
Labels: Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: ExternalDependency)
The spec has been updated to map KEYCODE_KANA => "KanjiMode":
https://w3c.github.io/uievents-key/#key-KanjiMode

Should be a good first bug.

Comment 2 by chongz@chromium.org, Jan 11 2018

Summary: Map AKEYCODE_KANA (218) to "KanjiMode" (was: Wait for spec: Map AKEYCODE_KANA (218) to "KanjiMode")

Comment 3 by dtapu...@chromium.org, Feb 14 2018

Owner: dtapu...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41a76cf2c07c9a4d00b2e8aeea413ea74850204e

commit 41a76cf2c07c9a4d00b2e8aeea413ea74850204e
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Feb 15 14:35:22 2018

Fix incorrect code for DOMKey on Android.

Add missing DVR mapping.
Fix Kana mode mapping.

BUG= 669647 , 669650 

Change-Id: Id6437ed1dae804108dfcad0dbe36feff04dea4ac
Reviewed-on: https://chromium-review.googlesource.com/919425
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537012}
[modify] https://crrev.com/41a76cf2c07c9a4d00b2e8aeea413ea74850204e/ui/events/keycodes/keyboard_code_conversion_android.cc

Comment 5 by dtapu...@chromium.org, Feb 15 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment