New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669647 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 662011



Sign in to add a comment

AKEYCODE_DVR should produce keyboard events with DomKey::DVR

Project Member Reported by chongz@chromium.org, Nov 29 2016

Issue description

Version: 57.0.2937.0
OS: Android 6.0.0, Nexus 7

What steps will reproduce the problem?
(1) On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html
(2) Run command "adb shell input keyevent 173"
(3) Verify generated events

What is the expected result?
Produces keydown/keyup with expected key.

What happens instead?
No keyboard events.

Firefox 50:
Produces keydown/keyup with 'Unidentified' key (the key value should be fixed in Firefox 53).

Also we need to go through the spec to verify other key-codes:
https://w3c.github.io/uievents-key/

 

Comment 2 by chongz@chromium.org, Jan 11 2018

Cc: chongz@chromium.org
Owner: ----
Status: Available (was: Assigned)
Un-assigning myself. Regarding the bug it seems that we can simply update our code to match the spreadsheet in #1.
Owner: dtapu...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41a76cf2c07c9a4d00b2e8aeea413ea74850204e

commit 41a76cf2c07c9a4d00b2e8aeea413ea74850204e
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Feb 15 14:35:22 2018

Fix incorrect code for DOMKey on Android.

Add missing DVR mapping.
Fix Kana mode mapping.

BUG= 669647 , 669650 

Change-Id: Id6437ed1dae804108dfcad0dbe36feff04dea4ac
Reviewed-on: https://chromium-review.googlesource.com/919425
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537012}
[modify] https://crrev.com/41a76cf2c07c9a4d00b2e8aeea413ea74850204e/ui/events/keycodes/keyboard_code_conversion_android.cc

Status: Fixed (was: Assigned)

Sign in to add a comment