New issue
Advanced search Search tips

Issue 669643 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

webkit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Project Member Reported by apaci...@chromium.org, Nov 29 2016

Issue description

webkit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Type: build-failure

Builders failed on: 
- WebKit Android (Nexus4): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29


21:33:32.735 21262 worker/0 printing/css2.1/page-break-before-001.html passed
21:33:32.739 21262 worker/0 svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg started
21:33:33.033 21263 worker/1 images/optimize-contrast-image.html output stderr lines:
21:33:33.033 21263   [6565:6565:1129/053331:289539638:ERROR:base_paths_android.cc(43)] Not implemented reached in bool base::PathProviderAndroid(int, base::FilePath*)
21:33:33.075 21263 "/b/c/b/WebKit_Android__Nexus4_/src/out/Release/image_diff --diff /tmp/tmpUaDR95/actual.png /tmp/tmpUaDR95/expected.png /tmp/tmpUaDR95/diff.png" took 0.04s
21:33:33.081 21263 "/usr/bin/wdiff --start-delete=##WDIFF_DEL## --end-delete=##WDIFF_END## --start-insert=##WDIFF_ADD## --end-insert=##WDIFF_END## /b/rr/tmpS1qnck/w/layout-test-results/images/optimize-contrast-image-expected.txt /b/rr/tmpS1qnck/w/layout-test-results/images/optimize-contrast-image-actual.txt" took 0.00s
21:33:33.138 21263 "ruby -I /b/c/b/WebKit_Android__Nexus4_/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch /b/c/b/WebKit_Android__Nexus4_/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/prettify.rb /b/rr/tmpS1qnck/w/layout-test-results/images/optimize-contrast-image-diff.txt" took 0.06s
21:33:33.139 21263 worker/1 images/optimize-contrast-image.html failed:
21:33:33.139 21263 worker/1  text diff
21:33:33.139 21263 worker/1  image diff
21:33:33.142 21263 worker/1 images/paletted-png-with-color-profile.html started
21:33:33.309 21264 worker/2 storage/domstorage/localstorage/simple-usage.html output stderr lines:
21:33:33.309 21264   [6511:6511:1129/053331:289731639:ERROR:base_paths_android.cc(43)] Not implemented reached in bool base::PathProviderAndroid(int, base::FilePath*)
21:33:33.315 21264 "/usr/bin/wdiff --start-delete=##WDIFF_DEL## --end-delete=##WDIFF_END## --start-insert=##WDIFF_ADD## --end-insert=##WDIFF_END## /b/rr/tmpS1qnck/w/layout-test-results/storage/domstorage/localstorage/simple-usage-expected.txt /b/rr/tmpS1qnck/w/layout-test-results/storage/domstorage/localstorage/simple-usage-actual.txt" took 0.01s
21:33:33.371 21264 "ruby -I /b/c/b/WebKit_Android__Nexus4_/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch /b/c/b/WebKit_Android__Nexus4_/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/prettify.rb /b/rr/tmpS1qnck/w/layout-test-results/storage/domstorage/localstorage/simple-usage-diff.txt" took 0.06s
21:33:33.372 19320 [160/197] storage/domstorage/localstorage/simple-usage.html failed unexpectedly (text diff, -expected.png was missing)
21:33:33.371 21264 worker/2 storage/domstorage/localstorage/simple-usage.html failed:
21:33:33.371 21264 worker/2  text diff
21:33:33.371 21264 worker/2  -expected.png was missing
21:33:33.375 21264 worker/2 svg/animations/animate-update-crash.xhtml started
21:33:33.528 21262 worker/0 svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg output stderr lines:
21:33:33.528 21262   [7487:7487:1129/053332:293059037:ERROR:base_paths_android.cc(43)] Not implemented reached in bool base::PathProviderAndroid(int, base::FilePath*)
21:33:33.528 21262   [7487:7487:1129/053332:293365187:ERROR:shell_android.cc(72)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): $RCSfile: coords-dom-02-f.svg,v $
21:33:33.553 21262 "/b/c/b/WebKit_Android__Nexus4_/src/out/Release/image_diff --diff /tmp/tmpOYgZkk/actual.png /tmp/tmpOYgZkk/expected.png /tmp/tmpOYgZkk/diff.png" took 0.02s
21:33:33.559 21262 "/usr/bin/wdiff --start-delete=##WDIFF_DEL## --end-delete=##WDIFF_END## --start-insert=##WDIFF_ADD## --end-insert=##WDIFF_END## /b/rr/tmpS1qnck/w/layout-test-results/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt /b/rr/tmpS1qnck/w/layout-test-results/svg/W3C-SVG-1.1-SE/coords-dom-02-f-actual.txt" took 0.00s
21:33:33.616 21262 "ruby -I /b/c/b/WebKit_Android__Nexus4_/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch /b/c/b/WebKit_Android__Nexus4_/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/prettify.rb /b/rr/tmpS1qnck/w/layout-test-results/svg/W3C-SVG-1.1-SE/coords-dom-02-f-diff.txt" took 0.06s
21:33:33.619 19320 [161/197] svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg failed unexpectedly (text diff, image diff)
21:33:33.617 21262 worker/0 svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg failed:
21:33:33.617 21262 worker/0  text diff
21:33:33.617 21262 worker/0  image diff
 
Owner: apaci...@chromium.org
Owner: fmalita@chromium.org
Status: Assigned (was: Available)
fmalita -- it looks like you've committed the changes to the test expectations here; this test is failing, showing SVG output in the render tree, but the test expectations have been changed to remove everything but the .

Your note in https://codereview.chromium.org/2530263002 suggests that this is some of the 'fallout' that was expected, so assigning to you to clean up :)

(The diff, which doesn't show up in rietveld, was

 layer at (0,0) size 480x360
   LayoutView at (0,0) size 480x360
 layer at (0,0) size 480x360
-  LayoutSVGRoot {svg} at (0,0) size 480x360
-    LayoutSVGHiddenContainer {defs} at (0,0) size 0x0
-    LayoutSVGContainer {g} at (160,140) size 160x80
-      LayoutSVGContainer {g} at (-60,-20) size 160x80 [transform={m=((1.00,0.00)(0.00,1.00)) t=(220.00,160.00)}]
-        LayoutSVGContainer {g} at (-60,-20) size 160x80
-          LayoutSVGEllipse {circle} at (-40,-40) size 80x80 [transform={m=((2.00,0.00)(0.00,1.00)) t=(20.00,20.00)}] [fill={[type=SOLID] [color=#FF0000]}] [cx=0.00] [cy=0.00] [r=40.00]
-        LayoutSVGContainer {g} at (-40,-40) size 80x80 [transform={m=((2.00,0.00)(0.00,1.00)) t=(20.00,20.00)}]
-          LayoutSVGEllipse {circle} at (-40,-40) size 80x80 [fill={[type=SOLID] [color=#00FF00]}] [cx=0.00] [cy=0.00] [r=40.00]
-    LayoutSVGContainer {g} at (10,311) size 231x36
-      LayoutSVGText {text} at (10,311) size 231x36 contains 1 chunk(s)
-        LayoutSVGInlineText {#text} at (10,311) size 231x36
-          chunk 1 text run 1 at (10.00,340.00) startOffset 0 endOffset 16 width 231.00: "$Revision: 1.7 $"
-    LayoutSVGRect {rect} at (1,1) size 478x358 [stroke={[type=SOLID] [color=#000000]}] [x=1.00] [y=1.00] [width=478.00] [height=358.00]
+  LayoutBlockFlow {HTML} at (0,0) size 480x360
+    LayoutBlockFlow {BODY} at (8,8) size 464x344

which is exactly the opposite of what the test is producing)

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2FW3C-SVG-1.1-SE%2Fcoords-dom-02-f.svg

The first recorded failure on android_blink_rel was on 10/31. The first recorded flakiness on Nexus 4 was on 11/24. The actual first failure/flakiness may be earlier than the dates because of expired old results.

When the test fails, the output is totally invalidate. It seems that the test finishes running before it's fully run. Looks like a layout test infrastructure issue.

Comment 4 by battre@chromium.org, Nov 30 2016

Labels: -Sheriff-Chromium
Assigned bug --> taking this out of the sheriff queue.
I concur with wangxianzhu@: the test is just flaky, and has been this way for a while.

Looks like we're updating style from a script without any synchronization with the test harness.  I'll take a stab at deflaking.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0e1286887eb8da26ce82e12291484fb76a537d6

commit a0e1286887eb8da26ce82e12291484fb76a537d6
Author: fmalita <fmalita@chromium.org>
Date: Wed Nov 30 19:27:54 2016

Attempt to deflake coords-dom-02-f.svg

The test is currently changing style without synchronizing with the
harness. This CL is trying to addres that, speculatively.

BUG= 669643 
R=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2540173002
Cr-Commit-Position: refs/heads/master@{#435375}

[modify] https://crrev.com/a0e1286887eb8da26ce82e12291484fb76a537d6/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg

Comment 7 by carl...@google.com, Dec 5 2016

Sheriff update: this test was flaky today. When it failed the expectation seemed very off from the actual output (for instance, an SVG was output but none were expected).

A few failed builds:
- https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/57758
- https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/57763
- https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/57762

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d50db3921f3bfb7cadc50e8b5c863accaba6402d

commit d50db3921f3bfb7cadc50e8b5c863accaba6402d
Author: fmalita <fmalita@chromium.org>
Date: Tue Dec 13 14:22:33 2016

Rebaseline coords-dom-02-f.svg (Android)

We've reverted the bad rebaseline for this test, but still need to
update the results for SK_ANALYTIC_AA.

BUG= 669643 
TBR=liyuqian@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2571803002
Cr-Commit-Position: refs/heads/master@{#438162}

[modify] https://crrev.com/d50db3921f3bfb7cadc50e8b5c863accaba6402d/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png

Status: Fixed (was: Assigned)
The last few builds look good, I think we can finally close this.

Sign in to add a comment