New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669631 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Files in ChromeOS Downloads folder are not shown in ARC++

Project Member Reported by sdantul...@chromium.org, Nov 29 2016

Issue description

Google Chrome	56.0.2924.9 (Official Build) dev (64-bit)
Revision	0
Platform	9000.10.0 (Official Build) dev-channel samus

What steps will reproduce the problem?
1. Download some images to Files app /Downloads folder
2. Install Gmail (https://play.google.com/store/apps/details?id=com.google.android.gm&hl=en)
3. Open Gmail, start composing new mail and try to attach some files
4. Install ES File Explorer app (https://play.google.com/store/apps/details?id=com.estrongs.android.pop&hl=en) and open Downloads folder 

What is the expected result?
Files should be available in ARC++ apps

What happens instead?
Files are not available.

Also reproduced on minnie, cyan
 
Owner: nya@chromium.org
Cc: gkihumba@chromium.org
Cc: dchan@chromium.org twreid@chromium.org
+feature owner 
+tpm 
+morning planners
Cc: bhthompson@chromium.org
Labels: ReleaseBlock-Dev
Not being able to access files seems like a reason to block dev on ARC++ boards.

WDYT tpms?

Comment 6 by gkihumba@google.com, Nov 30 2016

Is this only seen with ES file explorer? What about other file management apps?
Not specific to one app. None of the ARC++ apps can access files from Downloads folder.

Comment 8 by gkihumba@google.com, Nov 30 2016

Status: Assigned (was: Untriaged)

Comment 9 by nya@chromium.org, Nov 30 2016

Status: Started (was: Assigned)
It is because M56 branch for Android is not cut yet.

For b/32103402 I submitted changes to both Chrome OS and Android. Android change depends on Chrome OS change. Unfortunately Chrome OS change did not make it to Chrome OS M56 branch cut, but Android change is currently included because we still use ToT Android image for M56.

Possible solutions are:
1. Correctly cut Android M56 branch at the same point as Chrome OS M56 branch.
2. Cherry-pick my Chrome OS change to M56 branch.
3. Roll-back my Android change on ToT.

I hoped (1) is done soon, but it's almost two weeks since the branch cut date. I'm also requesting merge approval for (2) in b/32103402 but I got no response for a week.

Comment 10 by nya@chromium.org, Nov 30 2016

Hm, I was not accurate; it seems mnc-dr-arc-m56 branch already exists at this moment, but it contains my Android change (which depends on missing Chrome OS change). Assuming that we are not going to align Chrome OS / Android branch cut point in M56, remaining solutions are:

2. Cherry-pick my Chrome OS change to M56 branch.
3. Roll-back my Android change on M56 branch.
Actually  you are still right, it looks like the place we define what branch for the PFQ to pull from has moved and is duplicated, so a change went in to point at the new branch but we appear to be uprevving on the old branch.

https://chromium-review.googlesource.com/#/c/414617/ should fix that if everything else is set up. 

Comment 12 Deleted

Comment 13 by nya@chromium.org, Nov 30 2016

At this moment, release-R56-9000.B does NOT contain my Chrome OS change, but mnc-dr-arc-m56 contains my Android change. So even after we start buliding Chrome OS M56 with mnc-dr-arc-m56 Android, this issue will continue.

If we will forcibly reset mnc-dr-arc-m56 branch to the same timing as release-R56-9000.B it should be fine, but I guess we won't. Then we still need to do either (2) or (3) in #10.

I would say which ever you feel is most appropriate, consider the merge of either solution approved. 

Comment 15 by nya@chromium.org, Nov 30 2016

Sure, I'll go with (2).

Comment 16 by nya@chromium.org, Nov 30 2016

Cherry-pick has been done. I tried to build Chrome OS M56 locally, but it did not finish before I left office today. I will try verification tomorrow.

Comment 17 by nnagpal@google.com, Nov 30 2016

Cc: hsiangc@chromium.org nnag...@chromium.org rohi...@chromium.org vsu...@chromium.org avkodipelli@chromium.org
dhaddock@ please verify that this fix landed and working as intended, thanks.
gkihumba@ Issue exists. Fix is not yet available in today's M56 build 9000.11.0, 56.0.2924.11. 

Comment 20 by dchan@google.com, Nov 30 2016

Status: Fixed (was: Started)
test are now passing.
https://cros-goldeneye.corp.google.com/chromeos/console/listBuild?
milestone=57#/details

Comment 21 by dchan@google.com, Nov 30 2016

+sdantuluri to do a bit more testing before mark as verify
Status: Started (was: Fixed)
wait, there hasn't been a new M56 build yet.

https://cros-goldeneye.corp.google.com/chromeos/console/listBuild?milestone=56#/
the next one would be 9pm today.

Comment 23 by nya@chromium.org, Dec 1 2016

Verified that Downloads is working on M56 branch, after cros_workon start chromeos-cheets-scripts.

I assume next bot run will uprev ebuild, am I right?

You mean the android container? It should be updating itself on a regular basis now. 
Verified fix on ChromeOS  9000.12.0, 56.0.2924.12 samus, minnie, cyan
Status: Fixed (was: Started)
Marking as fixed.
Status: Verified (was: Fixed)
Marking verified (from comment #25)
Labels: -ReleaseBlock-Dev

Sign in to add a comment