Issue metadata
Sign in to add a comment
|
Files in ChromeOS Downloads folder are not shown in ARC++ |
||||||||||||||||||||
Issue descriptionGoogle Chrome 56.0.2924.9 (Official Build) dev (64-bit) Revision 0 Platform 9000.10.0 (Official Build) dev-channel samus What steps will reproduce the problem? 1. Download some images to Files app /Downloads folder 2. Install Gmail (https://play.google.com/store/apps/details?id=com.google.android.gm&hl=en) 3. Open Gmail, start composing new mail and try to attach some files 4. Install ES File Explorer app (https://play.google.com/store/apps/details?id=com.estrongs.android.pop&hl=en) and open Downloads folder What is the expected result? Files should be available in ARC++ apps What happens instead? Files are not available. Also reproduced on minnie, cyan
,
Nov 29 2016
,
Nov 29 2016
,
Nov 29 2016
+feature owner +tpm +morning planners
,
Nov 30 2016
Not being able to access files seems like a reason to block dev on ARC++ boards. WDYT tpms?
,
Nov 30 2016
Is this only seen with ES file explorer? What about other file management apps?
,
Nov 30 2016
Not specific to one app. None of the ARC++ apps can access files from Downloads folder.
,
Nov 30 2016
,
Nov 30 2016
It is because M56 branch for Android is not cut yet. For b/32103402 I submitted changes to both Chrome OS and Android. Android change depends on Chrome OS change. Unfortunately Chrome OS change did not make it to Chrome OS M56 branch cut, but Android change is currently included because we still use ToT Android image for M56. Possible solutions are: 1. Correctly cut Android M56 branch at the same point as Chrome OS M56 branch. 2. Cherry-pick my Chrome OS change to M56 branch. 3. Roll-back my Android change on ToT. I hoped (1) is done soon, but it's almost two weeks since the branch cut date. I'm also requesting merge approval for (2) in b/32103402 but I got no response for a week.
,
Nov 30 2016
Hm, I was not accurate; it seems mnc-dr-arc-m56 branch already exists at this moment, but it contains my Android change (which depends on missing Chrome OS change). Assuming that we are not going to align Chrome OS / Android branch cut point in M56, remaining solutions are: 2. Cherry-pick my Chrome OS change to M56 branch. 3. Roll-back my Android change on M56 branch.
,
Nov 30 2016
Actually you are still right, it looks like the place we define what branch for the PFQ to pull from has moved and is duplicated, so a change went in to point at the new branch but we appear to be uprevving on the old branch. https://chromium-review.googlesource.com/#/c/414617/ should fix that if everything else is set up.
,
Nov 30 2016
At this moment, release-R56-9000.B does NOT contain my Chrome OS change, but mnc-dr-arc-m56 contains my Android change. So even after we start buliding Chrome OS M56 with mnc-dr-arc-m56 Android, this issue will continue. If we will forcibly reset mnc-dr-arc-m56 branch to the same timing as release-R56-9000.B it should be fine, but I guess we won't. Then we still need to do either (2) or (3) in #10.
,
Nov 30 2016
I would say which ever you feel is most appropriate, consider the merge of either solution approved.
,
Nov 30 2016
Sure, I'll go with (2).
,
Nov 30 2016
Cherry-pick has been done. I tried to build Chrome OS M56 locally, but it did not finish before I left office today. I will try verification tomorrow.
,
Nov 30 2016
,
Nov 30 2016
dhaddock@ please verify that this fix landed and working as intended, thanks.
,
Nov 30 2016
gkihumba@ Issue exists. Fix is not yet available in today's M56 build 9000.11.0, 56.0.2924.11.
,
Nov 30 2016
test are now passing. https://cros-goldeneye.corp.google.com/chromeos/console/listBuild? milestone=57#/details
,
Nov 30 2016
+sdantuluri to do a bit more testing before mark as verify
,
Dec 1 2016
wait, there hasn't been a new M56 build yet. https://cros-goldeneye.corp.google.com/chromeos/console/listBuild?milestone=56#/ the next one would be 9pm today.
,
Dec 1 2016
Verified that Downloads is working on M56 branch, after cros_workon start chromeos-cheets-scripts. I assume next bot run will uprev ebuild, am I right?
,
Dec 1 2016
You mean the android container? It should be updating itself on a regular basis now.
,
Dec 1 2016
Verified fix on ChromeOS 9000.12.0, 56.0.2924.12 samus, minnie, cyan
,
Dec 1 2016
Marking as fixed.
,
Dec 1 2016
Marking verified (from comment #25)
,
Dec 1 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dhadd...@chromium.org
, Nov 29 2016