New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 669629 link

Starred by 1 user
Status: Fixed
Owner:
sanfin@chromium.org
Closed: May 2017
Cc:
█ s...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 635567



Sign in to add a comment

Remove lint suppression of UseCompoundDrawables in chromecast/internal/android/prebuilt

Project Member Reported by sanfin@chromium.org, Nov 29 2016 
https://codereview.chromium.org/2537873002/ will suppress a warning in Chromecast internal code that causes a crash in lint for an unknown reason. The file in question is legacy code that will soon be deleted, so when that removal is complete, the lint suppression should be reverted.
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/064434bb26e0cf8c916b11ecd988041bdb1f1c40

commit 064434bb26e0cf8c916b11ecd988041bdb1f1c40
Author: Simeon Anfinrud <sanfin@chromium.org>
Date: Tue May 09 17:14:41 2017

Revert "[Chromecast] Suppress a crashing lint warning."

This reverts commit 477db25e38327a2891aa3c02e1b112d0308f9306.

Chromecast internal code no longer uses the files that were
causing the suppressed lint errors, so we can remove these.

BUG= 669629 
TEST=build internal Cast apk

Change-Id: I38d9eb6284788276f7f776f139b9f74c9f2668e5
Reviewed-on: https://chromium-review.googlesource.com/493774
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Michael Case <mikecase@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470361}
[modify] https://crrev.com/064434bb26e0cf8c916b11ecd988041bdb1f1c40/build/android/lint/suppressions.xml

Comment 2 by sanfin@chromium.org, May 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment