New issue
Advanced search Search tips

Issue 669606 link

Starred by 2 users
Status: Assigned
Owner:
tguilbert@chromium.org
Cc:
xhw...@chromium.org
tguilbert@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Extract InitiateScopedSurfaceRequest from the mojo::Renderer interface

Project Member Reported by tguilbert@chromium.org, Nov 29 2016 
Currently, the mojom::Renderer interface is not aligned with the media::Renderer C++ interface. There is an extra InitiateScopedSurfaceRequest() which is only used when setting up a MediaPlayerRenderer.

The MediaPlayerRenderer is only used on Android, and the presence of InitiateScopedSurfaceRequest() leads to some awkward checks for bad message calls for all platforms.

This led to a discussion proposing the addition of a mojo::MediaPlayerRenderer (see https://chromiumcodereview.appspot.com/2530613003/?_ga=1.123982018.997515271.1478567349#msg12
and https://codereview.chromium.org/2539703002/)

This bug tracks the discussion and changes related to cleaning up the mojo::Renderer interface and MojoRendererService implementation.

Comment 1 Deleted

Comment 2 by xhw...@chromium.org, Nov 29 2016

Components: Internals>Media>Mojo
Labels: OS-Android
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2db52064245983d71338e51d330edf256418e81

commit a2db52064245983d71338e51d330edf256418e81
Author: xhwang <xhwang@chromium.org>
Date: Tue Nov 29 22:06:46 2016

media: Add |bad_message_cb_| to MojoRendererService

This helps move the StrongBindingPtr out of MojoRendererService, so that
we can bind MojoRendererService using other type of bindings, e.g.
mojo::Binding.

When we do use MojoRendererService::Create(), which uses
mojo::StrongBinding, now the StrongBindingPtr isimplicitly owned by the
MojoRendererService through the |bad_message_cb_|.

BUG= 604912 ,669606
TEST=Covered by media_mojo_unittests

Review-Url: https://codereview.chromium.org/2539703002
Cr-Commit-Position: refs/heads/master@{#435088}

[modify] https://crrev.com/a2db52064245983d71338e51d330edf256418e81/media/mojo/clients/mojo_renderer_unittest.cc
[modify] https://crrev.com/a2db52064245983d71338e51d330edf256418e81/media/mojo/services/mojo_renderer_service.cc
[modify] https://crrev.com/a2db52064245983d71338e51d330edf256418e81/media/mojo/services/mojo_renderer_service.h
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by xhw...@chromium.org, Dec 11 2017

Owner: tguilbert@chromium.org
Status: Assigned (was: Untriaged)
tguilbert@: Is this something we still want to do?
►

Sign in to add a comment