New issue
Advanced search Search tips

Issue 669594 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

WebVR: VRDisplay.requestAnimationFrame callbacks are receiving a very large timestamp

Project Member Reported by bajones@chromium.org, Nov 29 2016

Issue description

The timestamp provided to VRDisplay.requestAnimationFrame appears to be multiplied by 1000.
 

Comment 1 by klausw@chromium.org, Nov 29 2016

Cc: klausw@chromium.org
This is an externally visible API, Javascript code is getting wrong arguments to the WebVR variant of the rAF callback in violation of the spec. Fixing this ASAP is important, we don't want developers to start writing code which expects the mis-scaled values that would then break when it gets fixed later.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/769c85525581f5f39cdc1d207b2254d35cb106f3

commit 769c85525581f5f39cdc1d207b2254d35cb106f3
Author: bajones <bajones@chromium.org>
Date: Wed Nov 30 07:53:27 2016

Adjust the timestamp for VRDisplay.requestAnimationFrame calls

Previously timestamps had their origin incorrectly adjusted and were multiplied
by 1000.

BUG= 669594 

Review-Url: https://codereview.chromium.org/2533383002
Cr-Commit-Position: refs/heads/master@{#435143}

[modify] https://crrev.com/769c85525581f5f39cdc1d207b2254d35cb106f3/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/769c85525581f5f39cdc1d207b2254d35cb106f3/third_party/WebKit/Source/modules/vr/VRDisplay.h

Labels: Merge-Request-56

Comment 4 by dimu@chromium.org, Nov 30 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c063abec095c1a725dacc4cc976a971650df023d

commit c063abec095c1a725dacc4cc976a971650df023d
Author: Brandon Jones <bajones@chromium.org>
Date: Wed Nov 30 17:44:07 2016

Adjust the timestamp for VRDisplay.requestAnimationFrame calls

Previously timestamps had their origin incorrectly adjusted and were multiplied
by 1000.

BUG= 669594 

Review-Url: https://codereview.chromium.org/2533383002
Cr-Commit-Position: refs/heads/master@{#435143}
(cherry picked from commit 769c85525581f5f39cdc1d207b2254d35cb106f3)

Review URL: https://codereview.chromium.org/2544553002 .

Cr-Commit-Position: refs/branch-heads/2924@{#194}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/c063abec095c1a725dacc4cc976a971650df023d/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/c063abec095c1a725dacc4cc976a971650df023d/third_party/WebKit/Source/modules/vr/VRDisplay.h

Status: Fixed (was: Started)
Labels: M-56
Components: Blink>WebXR

Sign in to add a comment