New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669592 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 671375
issue 684849



Sign in to add a comment

Paper ripple animations are often janky

Project Member Reported by zelidrag@chromium.org, Nov 29 2016

Issue description

Chrome Version       : 56.0.2920.0
OS Version: 8992.1.0

What steps will reproduce the problem?
1. Open chrome:md-settings on a touch-enabled Chromebook (i.e. Pixel)
2. Find a radio button controls on the page
3. Touch radio button controls back and forth

What is the expected result?

Touch driven ripple animations should always end.

What happens instead of that?

In 30% of cases, ripple animations are unfinished - left half way through. See attachments.


UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 8992.1.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2920.0 Safari/537.36



 
Screenshot 2016-11-29 at 10.45.41 AM.png
216 KB View Download
Screenshot 2016-11-29 at 10.45.34 AM.png
203 KB View Download
Labels: -M-57 Proj-MaterialDesign-WebUI Hotlist-MD-Settings-General
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)
I can repro - @dbeam, any suggestions who could look at this?

Comment 2 by dbeam@chromium.org, Nov 29 2016

Summary: Radio buttons in chrome://md-settings often don't complete ripple animations (was: Radio buttons in http://md-settings often don't complete ripple animations)

Comment 3 by dbeam@chromium.org, Nov 29 2016

there have been touch-specific issues that have cropped up lately, but I can't tell the particular issue from your screenshots.

i'll try on my canary pixel
it seems to me that the ring might represent control focus and maybe not ripple animation at all.

it's strange that it's inconsistently appearing when using touch.
Blocking: 671375
Is this actually OS=Chrome specific, or just more noticeable on slower CrOS systems?

Blocking: 684849
Cc: tbuck...@chromium.org egarciad@chromium.org steve...@chromium.org bettes@chromium.org
As discussed offline, there is a patch by egarciad@ here:

https://github.com/PolymerElements/paper-ripple/tree/fast-ripple

I have tested it on a couple of slow Chrome OS devices and there is a definite noticeable improvement in smoothness.

There are two major artifacts that will be worked on:

1. Once a button has rippled, hiding then showing the button will cause the ripple to show again when the button is shown.
* e.g. expand Languages and input > Spell check, toggle English on and off, then unexpand/expand the section.
* On Chrome OS, expand/unexpand WiFi networks, then disable/enable WiFi. The expand button will ripple when it is shown.

2. Double-click (or two rapid clicks?) causes the ripple to persist and not disappear.

There are a couple minor visual artifacts with the new ripple that need UX feedback (i.e. it's not clear that the new behavior is bad, just different):

3. The ripples are faster, closer to .5 seconds than 1 second.

4. The ripple is more subtle / translucent.

dbeam@ - You also mentioned some artifacts that you noticed, is there anything you noticed that I missed?

Comment 9 by dbeam@chromium.org, Feb 14 2017

Labels: OS-Linux OS-Mac OS-Windows

Comment 10 by dbeam@chromium.org, Feb 17 2017

Status: Started (was: Assigned)
Summary: Paper ripple animations are often janky (was: Radio buttons in chrome://md-settings often don't complete ripple animations)

Comment 13 by dbeam@chromium.org, Feb 24 2017

Status: Fixed (was: Started)
stevenjb@: can you try this soon?
Status: Verified (was: Fixed)

Sign in to add a comment