New issue
Advanced search Search tips

Issue 669584 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 668021
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Polymer PRESUBMIT.py broken.

Project Member Reported by dpa...@chromium.org, Nov 29 2016

Issue description

While trying to roll a Polymer element to a newer version, I hit this error when running "git cl upload"

Running presubmit upload checks ...
Traceback (most recent call last):
  File "/usr/local/google/home/dpapad/programs/depot_tools/git_cl.py", line 5415, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/dpapad/programs/depot_tools/git_cl.py", line 5397, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/dpapad/programs/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/dpapad/programs/depot_tools/git_cl.py", line 4213, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/usr/local/google/home/dpapad/programs/depot_tools/git_cl.py", line 1596, in CMDUpload
    change=change)
  File "/usr/local/google/home/dpapad/programs/depot_tools/git_cl.py", line 1540, in RunHook
    gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
  File "/usr/local/google/home/dpapad/programs/depot_tools/presubmit_support.py", line 1247, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/home/dpapad/programs/depot_tools/presubmit_support.py", line 1157, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 53, in CheckChangeOnUpload
  File "<string>", line 20, in _CheckBowerDependencies
TypeError: AffectedFiles() got an unexpected keyword argument 'include_dirs'

After investigating the AffectedFiles() API has been recently modified, and the "input_dirs" parameter does not exist anymore, see https://codereview.chromium.org/2394043002/diff/60001/presubmit_support.py.
 

Comment 1 by dbeam@chromium.org, Nov 29 2016

Mergedinto: 668021
Status: Duplicate (was: Untriaged)

Sign in to add a comment