VALIDATE_CACHE request for subresources on network error
Reported by
bmau...@fb.com,
Nov 29 2016
|
|||||||
Issue descriptionVersion: Chrome 54 OS: mac I was on a flakey internet connection trying to load Facebook. The page timed out loading after 30 seconds. A little bit later the page reloaded itself (maybe because chrome detected I had internet connectivity) and I noticed that both the page and all subresoruces used VALIDATE_CACHE. I've attached a net-internals log of this. I believe this is the NetErrorHelper discussed in the reload reloaded doc. Kenji -- It'd be great if we could fully kill any reasons why subresources might be revalidated (eg this, location.reload
,
Nov 30 2016
Toyoshima-san, is this something you can work on? If not, could you assign to the owner of the network error reloading code and provide guidance? Thanks.
,
Nov 30 2016
,
Nov 30 2016
Thanks. Let me investigate this.
,
Dec 1 2016
OK, I have a fix now. NetErrorHelper directly calls WebFrame::reload() interface, instead of asking NavigationController to reload. Thus, its behavior wasn't changed when I modified the NavigationController. I checked other use cases, but this seems to be only the case that calls WebFrame::reload() directory outside Blink. I will send a patch for review soon.
,
Dec 1 2016
> but this seems to be only the case this isn't true. I'd file another meta bug to track other use cases.
,
Dec 1 2016
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e702f8d9772ebd56c5a75186841d98222861dae3 commit e702f8d9772ebd56c5a75186841d98222861dae3 Author: toyoshim <toyoshim@chromium.org> Date: Fri Dec 02 08:23:32 2016 Reload Reloaded: Use ReloadMainResource even on recovering from offline blink::WebFrameLoadType::Reload re-validates all resources, but blink::WebFrameLoadType::ReloadMainResource only re-validates the main document. Recently NavigationController was modified to use ReloadMainResource instead of Reload. When chrome is offline, NetErrorHelper monitors network state, and reload a page when it gets online. Since NetErrorHelper does not use NavigationController, but calls WebFrame::reload() interface, it still uses traditional reload type, Reload. Let replace it with ReloadMainResource as we did for reloads through the NavigationController. BUG= 669580 Review-Url: https://codereview.chromium.org/2538423002 Cr-Commit-Position: refs/heads/master@{#435886} [modify] https://crrev.com/e702f8d9772ebd56c5a75186841d98222861dae3/chrome/renderer/net/net_error_helper.cc [modify] https://crrev.com/e702f8d9772ebd56c5a75186841d98222861dae3/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
,
Dec 2 2016
OK, this is fixed on the trunk. Will reach to stable at version 57. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by manoranj...@chromium.org
, Nov 29 2016