Handle H264 rotation switches when rendering frames in WebMediaPlayerMS |
||||
Issue descriptionThis is chrome bug to reflect the reported webrtc bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=6768 When H264 HW encoder is used on Android, front and back camera has different rotation information. We need to handle rotation changes while rendering in WebMediaPlayerMS.
,
Nov 30 2016
,
Dec 1 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2e9191663644c1acc9163d5072907617909721f commit e2e9191663644c1acc9163d5072907617909721f Author: emircan <emircan@chromium.org> Date: Fri Dec 02 19:08:56 2016 Reset WebMediaPlayerMS video layer on rotation change Incoming video stream's rotation might change during the session, i.e. when the remote client changes between front/back camera. This CL adds checks to find when rotation changes and resets cc_blink::WebLayerImpl with the updated rotation information. BUG= 669573 , webrtc:6768 TEST=Added RotationChange unittest. Tested H264 AppRTC call between Nexus 5 and Linux while changing front/back camera. Review-Url: https://codereview.chromium.org/2536893002 Cr-Commit-Position: refs/heads/master@{#435113} (cherry picked from commit f79979ea2cff435564fe96a89b24533855f77213) NOTRY=true NOPRESUBMIT=true TBR=qiangchen@chromium.org,mcasas@chromium.org Review-Url: https://codereview.chromium.org/2547773003 Cr-Commit-Position: refs/branch-heads/2924@{#294} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/e2e9191663644c1acc9163d5072907617909721f/content/renderer/media/webmediaplayer_ms.cc [modify] https://crrev.com/e2e9191663644c1acc9163d5072907617909721f/content/renderer/media/webmediaplayer_ms.h [modify] https://crrev.com/e2e9191663644c1acc9163d5072907617909721f/content/renderer/media/webmediaplayer_ms_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by emir...@chromium.org
, Nov 30 2016