New issue
Advanced search Search tips

Issue 669566 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add ubsan_no_recover_hack to missing ubsan builders

Project Member Reported by infe...@chromium.org, Nov 29 2016

Issue description

https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?rcl=0&l=1416

'ubsan_release_bot': [
      'ubsan', 'release_bot',
    ],

    'ubsan_vptr_edge_release_bot': [
      'ubsan_vptr', 'edge', 'release_bot',
    ],

 

Comment 1 by mmoroz@google.com, Nov 30 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a50c295543d07efaedd8534d117f3860a3df52e8

commit a50c295543d07efaedd8534d117f3860a3df52e8
Author: mmoroz <mmoroz@chromium.org>
Date: Wed Nov 30 17:35:36 2016

Add ubsan_no_recover_hack to missing ubsan builders.

R=inferno@chromium.org, ochang@chromium.org, phajdan.jr@chromium.org
BUG= 669566 

Review-Url: https://codereview.chromium.org/2538103002
Cr-Commit-Position: refs/heads/master@{#435317}

[modify] https://crrev.com/a50c295543d07efaedd8534d117f3860a3df52e8/tools/mb/mb_config.pyl

Comment 4 by mmoroz@chromium.org, Nov 30 2016

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/587155a2669951ced6f9e9c2db8d9ee09abcd670

commit 587155a2669951ced6f9e9c2db8d9ee09abcd670
Author: inferno <inferno@chromium.org>
Date: Tue Dec 13 06:07:02 2016

Revert of Add ubsan_no_recover_hack to missing ubsan builders. (patchset #1 id:1 of https://codereview.chromium.org/2538103002/ )

Reason for revert:
UBSan is noisy and can't be enabled for explicit crash behavior on builders. On ClusterFuzz, it will be still enabled to create testcases.

BUG= 673488 

Original issue's description:
> Add ubsan_no_recover_hack to missing ubsan builders.
>
> R=inferno@chromium.org, ochang@chromium.org, phajdan.jr@chromium.org
> BUG= 669566 
>
> Committed: https://crrev.com/a50c295543d07efaedd8534d117f3860a3df52e8
> Cr-Commit-Position: refs/heads/master@{#435317}

TBR=ochang@chromium.org,phajdan.jr@chromium.org,mmoroz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 669566 

Review-Url: https://codereview.chromium.org/2568883003
Cr-Commit-Position: refs/heads/master@{#438074}

[modify] https://crrev.com/587155a2669951ced6f9e9c2db8d9ee09abcd670/tools/mb/mb_config.pyl

Sign in to add a comment