New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669565 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

chrome_public_test_apk on Android failing on chromium.linux/Android Tests (dbg)

Project Member Reported by apaci...@chromium.org, Nov 29 2016

Issue description

chrome_public_test_apk on Android failing on chromium.linux/Android Tests (dbg)

Type: build-failure

Builders failed on: 
- Android Tests (dbg): 
  https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29



 
twellington@: Since you're taking a look at the other ContextualSearchManagerTest test, PTAL for testTapOnRoleIgnored as well. Thanks!
Components: UI>Browser>Mobile>TouchToSearch
Labels: OS-Android
Owner: donnd@chromium.org
Status: Assigned (was: Available)
Donn - can you take this one?

Comment 3 by donnd@chromium.org, Nov 29 2016

Cc: tedc...@chromium.org wnwen@chromium.org
Labels: Pri-1 Type-Bug
Looks like it has nothing to do with the particular test, the test page simply failed to load:

org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testTapOnRoleIgnored (run #1):
junit.framework.AssertionFailedError: Failed to load URL: null, final URL: http://127.0.0.1:36600/chrome/test/data/android/contextualsearch/tap_test.html
	at org.chromium.chrome.test.util.ChromeTabUtils.waitForTabPageLoaded(ChromeTabUtils.java:84)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.startMainActivityFromIntent(ChromeActivityTestCaseBase.java:447)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.startMainActivityWithURL(ChromeActivityTestCaseBase.java:403)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.startMainActivity(ContextualSearchManagerTest.java:261)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.setUp(ChromeActivityTestCaseBase.java:139)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.setUp(ContextualSearchManagerTest.java:122)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Is there a more robust way to load the test page than startMainActivityWithURL, or a way to retry when that fails?
We can add @RetryOnFailure to the test for now.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/178b21a3089c78d3d4dbd3ccdcb7b967959ecf5a

commit 178b21a3089c78d3d4dbd3ccdcb7b967959ecf5a
Author: twellington <twellington@chromium.org>
Date: Tue Nov 29 18:43:32 2016

[Contextual Search] Fix flaky tests

Attempt to fix ContextualSearchManagerTest#testImageControl() by running
calls to the ContextualSearchImageControl on the UI thread. Also add
@RetryOnFailure to #testTapOnRoleIgnored().

BUG= 669405 , 669565 

Review-Url: https://codereview.chromium.org/2534193002
Cr-Commit-Position: refs/heads/master@{#435040}

[modify] https://crrev.com/178b21a3089c78d3d4dbd3ccdcb7b967959ecf5a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 6 by battre@chromium.org, Nov 30 2016

Labels: -Sheriff-Chromium
Looks like this is being taken care of. -> taking this out of the sheriffing queue.

Comment 7 by donnd@chromium.org, Apr 12 2017

Status: Fixed (was: Assigned)

Sign in to add a comment