New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669561 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15.8%-62.5% regression in page_cycler_v2.intl_ja_zh at 434721:434802

Project Member Reported by benhenry@chromium.org, Nov 29 2016

Issue description

See graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 29 2016

Cc: rsesek@chromium.org
Owner: rsesek@chromium.org

=== Auto-CCing suspected CL author rsesek@chromium.org ===

Hi rsesek@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [Mac] Remove NSScreen renderer sandbox warmup.
Author  : rsesek
Commit description:
  
This should no longer be necessary now that the scrollbar animations are
no longer driven by NSAnimation (https://codereview.chromium.org/529103002/).

BUG=306348, 533537 
R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2509273005
Cr-Commit-Position: refs/heads/master@{#434775}
Commit  : 9cf04c9e74a140d91cea9602298cace5b6277a6f
Date    : Mon Nov 28 23:37:44 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@434720  154.882  56.5928  8  good
chromium@434750  147.376  34.028   8  good
chromium@434765  143.792  40.8376  8  good
chromium@434773  148.887  33.4893  8  good
chromium@434774  147.868  30.3215  8  good
chromium@434775  231.801  50.9415  5  bad    <--
chromium@434777  239.397  25.2925  5  bad
chromium@434780  228.404  26.7899  5  bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 669561

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...narod.yandex.ru. page_cycler_v2.intl_hi_ru
Test Metric: timeToFirstContentfulPaint_avg/pcv1-cold/http___narod.yandex.ru_
Relative Change: 47.47%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/1073
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8994639057444018336


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5886443795251200

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by benhenry@google.com, Nov 29 2016

Status: Assigned (was: Untriaged)

Comment 5 by rsesek@chromium.org, Nov 30 2016

Yes, I think this was likely mine. More detailed analysis is in  issue 533537 , but I have a speculative fix: https://codereview.chromium.org/2531163007/.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/028b4899bca8b8150091a11028a342e77ed880a4

commit 028b4899bca8b8150091a11028a342e77ed880a4
Author: rsesek <rsesek@chromium.org>
Date: Wed Nov 30 12:37:37 2016

Permit renderer access to Mach global-name com.apple.lsd.mapdb.

This is an XPC endpoint that provides read access to the LaunchServices
database.

BUG=306348, 533537 , 669561 
R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2531163007
Cr-Commit-Position: refs/heads/master@{#435234}

[modify] https://crrev.com/028b4899bca8b8150091a11028a342e77ed880a4/content/renderer/renderer.sb

Status: Fixed (was: Assigned)
https://chromeperf.appspot.com/group_report?bug_id=669561 shows all regressions have been fixed.

Sign in to add a comment