DCHECK in VariationsService::DoActualFetch |
||
Issue description
Got a DCHECK on !pending_seed_request_ just now. This is on resuming the process after a long sleep under debugger.
I don't see why the same thing wouldn't happen on suspend/resume?
void VariationsService::DoActualFetch() {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(!pending_seed_request_); <<< ASSERT HERE
pending_seed_request_ = net::URLFetcher::Create(0, variations_server_url_,
net::URLFetcher::GET, this);
data_use_measurement::DataUseUserData::AttachToFetcher(
pending_seed_request_.get(),
data_use_measurement::DataUseUserData::VARIATIONS);
pending_seed_request_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
net::LOAD_DO_NOT_SAVE_COOKIES);
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f480d6a78ddefc9339fb90f3318a1c1b583a77c commit 2f480d6a78ddefc9339fb90f3318a1c1b583a77c Author: asvitkine <asvitkine@chromium.org> Date: Mon Feb 06 17:00:19 2017 Fix variations service DCHECK and add LOAD_DO_NOT_SEND_AUTH_DATA. The DCHECK could fire if the fetch timer fires before the previous request finished. This normally shouldn't happen - but could if Chrome was paused (via debugger or machine suspend). Also while changing this code, adds the LOAD_DO_NOT_SEND_AUTH_DATA flag when making the request, which was suggested for UMA and UKM fetches and makes sense here too - since variations server doesn't need that info at all. BUG= 669542 Review-Url: https://codereview.chromium.org/2678783003 Cr-Commit-Position: refs/heads/master@{#448275} [modify] https://crrev.com/2f480d6a78ddefc9339fb90f3318a1c1b583a77c/components/variations/service/variations_service.cc
,
Feb 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, Nov 29 2016