New issue
Advanced search Search tips

Issue 669541 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Consolidate FirstRunGlue, FirstRunGlueImpl and code in FirstRunFlowSequencer

Project Member Reported by asvitk...@chromium.org, Nov 29 2016

Issue description

Consolidate FirstRunGlue, FirstRunGlueImpl and code in FirstRunFlowSequencer.

First, we currently don't make use the indirection set up by FirstRunGlue interface - additionally there's also related code already in FirstRunFlowSequencer that doesn't go through FirstRunGlue - e.g. isFirstRunEulaAccepted() and others.

We should consolidate all of this into one places - maybe FirstRunGlue with static functions.
 
From the original cl interaction, let's first check how the test coverage is for first run.  If these abstractions would allow us to write more/better tests, then let's do that instead of deleting it.
Re: Test coverage, looks like we have the following tests:
  FirstRunFlowSequencerTest.java - unit test that just exercises FirstRunFlowSequencer code
  FirstRunIntegrationTest.java - integration test that simulates sending BACK key on FRE screen to make sure activity is closed

So there's no unit test coverage of FirstRunActivity, which is where FirstRunGlue is used. Though I'm also not sure how much the glue is helpful in writing tests for it - i.e. why would we need to abstract for example isDefaultAccountName() but not other things.

And maybe some of those can be done easier by just subclassing FirstRunActivity - for example a few of those already have methods in FirstRunActivity that just call the glue ones - like didAcceptTermsOfService, openAccountAdder, etc.

I guess the real question is which things we want to have test coverage for and whether the glue as it is implemented now is helpful for testing them or not.

Status: WontFix (was: Assigned)
Looks like FirstRunGlue and FirstRunGlueImpl no longer exist, so this is WontFix as obsolete. Yay for whoever did the cleanup.

Sign in to add a comment