New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669534 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in printing::PrintWebViewHelper::OnMessageReceived

Project Member Reported by ClusterFuzz, Nov 29 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5754609055563776

Fuzzer: cdiehl_peach
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x61100001b7dc
Crash State:
  printing::PrintWebViewHelper::OnMessageReceived
  content::RenderFrameImpl::OnMessageReceived
  content::ChildThreadImpl::OnMessageReceived
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=434678:434769

Minimized Testcase (953.89 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94F1azWt_SdrRZJ4bx0hPi8cmk-13Gl4MWJltieZ7oVD7lci13RzJJ8rMGLadq4yxRUvXpSfJ0l2HRRjAg6y779Mc63DoRk-yE7A7bM-4GphogTaJOYGnigvzajuOsoDrX48HT88d6SXugqp_dPYlHQMO5V89mztxrrza9mSem8JkO-D7Y?testcase_id=5754609055563776

Additional requirements: Requires Gestures

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by och...@chromium.org, Nov 29 2016

Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
thestig, are you the right owner for this? thanks.

Comment 2 by och...@chromium.org, Nov 29 2016

Components: Internals>Printing
Cc: creis@chromium.org nasko@chromium.org lfg@chromium.org
Labels: M-56 Pri-1
Looks like we need to do another follow up after fixing  bug 666616  in r434734.
Status: Started (was: Assigned)
https://codereview.chromium.org/2537973003
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 30 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149f2a418b32edc71ce700e75084fccf2ce6eb2a

commit 149f2a418b32edc71ce700e75084fccf2ce6eb2a
Author: thestig <thestig@chromium.org>
Date: Wed Nov 30 17:52:57 2016

One more check for PrintWebViewHelper validity.

This check should have been in r434734.

BUG= 669534 

Review-Url: https://codereview.chromium.org/2537973003
Cr-Commit-Position: refs/heads/master@{#435323}

[modify] https://crrev.com/149f2a418b32edc71ce700e75084fccf2ce6eb2a/components/printing/renderer/print_web_view_helper.cc

Project Member

Comment 7 by ClusterFuzz, Dec 1 2016

ClusterFuzz has detected this issue as fixed in range 435314:435416.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5754609055563776

Fuzzer: cdiehl_peach
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x61100001b7dc
Crash State:
  printing::PrintWebViewHelper::OnMessageReceived
  content::RenderFrameImpl::OnMessageReceived
  content::ChildThreadImpl::OnMessageReceived
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=434678:434769
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=435314:435416

Minimized Testcase (953.89 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94F1azWt_SdrRZJ4bx0hPi8cmk-13Gl4MWJltieZ7oVD7lci13RzJJ8rMGLadq4yxRUvXpSfJ0l2HRRjAg6y779Mc63DoRk-yE7A7bM-4GphogTaJOYGnigvzajuOsoDrX48HT88d6SXugqp_dPYlHQMO5V89mztxrrza9mSem8JkO-D7Y?testcase_id=5754609055563776

Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Dec 1 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 1 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-56
Now that ClusterFuzz has verified the fix, requesting merge into M56.

Comment 11 by dimu@chromium.org, Dec 1 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
I'll take care of the merge.
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 1 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6e404a5004dc4ac3c9860371f824ba13bcaf5f7

commit a6e404a5004dc4ac3c9860371f824ba13bcaf5f7
Author: Nasko Oskov <nasko@chromium.org>
Date: Thu Dec 01 18:07:52 2016

One more check for PrintWebViewHelper validity.

This check should have been in r434734.

BUG= 669534 

Review-Url: https://codereview.chromium.org/2537973003
Cr-Commit-Position: refs/heads/master@{#435323}
(cherry picked from commit 149f2a418b32edc71ce700e75084fccf2ce6eb2a)

Review URL: https://codereview.chromium.org/2545853002 .

Cr-Commit-Position: refs/branch-heads/2924@{#251}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a6e404a5004dc4ac3c9860371f824ba13bcaf5f7/components/printing/renderer/print_web_view_helper.cc

Labels: -reward-topanel reward-unpaid reward-1500
Congratulations!  The panel has awarded $1,500 for this bug.

Comment 16 by lfg@chromium.org, Dec 12 2016

Re #15: This was found by clusterfuzz. Wrong bug?

Comment 17 by nordi...@gmail.com, Dec 12 2016

This was found by Peach. Looks legit to me. ;-)

Comment 18 by lfg@chromium.org, Dec 12 2016

Re #17: Ah, fair enough, didn't see that :)
Yep - this is running under the Chrome Fuzzer Program (g.co/ChromeBugRewards)
Labels: -reward-unpaid reward-inprocess
Labels: -ReleaseBlock-Beta
Project Member

Comment 22 by sheriffbot@chromium.org, Mar 9 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment