[translate] TranslateRanker mistakenly supresses it's result if enforcement is disabled |
|||||
Issue descriptionThe TranslateRanker always returns a default response if the enforcement flag is not enabled. This responsibility was migrated to the TranslateManager in an earlier refactor and the required TranslateRanker update was missed. This breaks the logging of the ranker response in "ghost" mode (i.e., to capture the rankers output without affecting the user's experience).
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/131e0dc96c8c88fc1fc222442a61fb2704b1795d commit 131e0dc96c8c88fc1fc222442a61fb2704b1795d Author: rogerm <rogerm@chromium.org> Date: Tue Nov 29 19:53:45 2016 [translate] Fix enforcement vs logging for TranslateRanker. The translate ranker enforcement flag was redundantly enforced within the ranker itself, thwarting the TranslateManagers attempts to log the ranker result and enforc (or not) the result. The check in the TranslateRanker should have been removed in the last refactor. BUG= 669528 Review-Url: https://codereview.chromium.org/2533953003 Cr-Commit-Position: refs/heads/master@{#435061} [modify] https://crrev.com/131e0dc96c8c88fc1fc222442a61fb2704b1795d/components/translate/core/browser/translate_ranker.cc
,
Dec 1 2016
,
Dec 1 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 2 2016
M56 Beta promotion is scheduled on Dec 6 & RC cut on Monday, Dec 5 @ 4.00 PM PST.Please ensure to verify the fix and merge your change ASAP so that we could take it for next Release.
,
Dec 2 2016
Verified! Merging...
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5e19ee30ef13c7a28686f16809a582c818dcbce commit f5e19ee30ef13c7a28686f16809a582c818dcbce Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Dec 02 20:18:18 2016 [Merge M56][translate] Fix enforcement vs logging for TranslateRanker. The translate ranker enforcement flag was redundantly enforced within the ranker itself, thwarting the TranslateManagers attempts to log the ranker result and enforc (or not) the result. The check in the TranslateRanker should have been removed in the last refactor. BUG= 669528 Review-Url: https://codereview.chromium.org/2533953003 Cr-Commit-Position: refs/heads/master@{#435061} (cherry picked from commit 131e0dc96c8c88fc1fc222442a61fb2704b1795d) Review URL: https://codereview.chromium.org/2548693003 . Cr-Commit-Position: refs/branch-heads/2924@{#297} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/f5e19ee30ef13c7a28686f16809a582c818dcbce/components/translate/core/browser/translate_ranker.cc
,
Jan 11
You started fixing this bug over two years ago. Are you still working on it? You can update the status to "archived", "wontfix", or "closed". You can remove yourself as owner and change status to "untriaged", but if this is still a real bug, please do not sit on it.
,
Jan 14
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rogerm@chromium.org
, Nov 29 2016