Public Session whitelisting - prompt the user for audioCapture/videoCapture requests |
|||||||||||||
Issue descriptionIn Public Sessions extensions are force installed by admin policy and some of the permissions are granted at install time so the end user has no say on it. audioCapture and videoCapture APIs are dangerous from a security/privacy standpoint therefore we want to give the user a runtime prompt whether to allow such API.
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b040fda5a81f54c4dbab7664f3aaf2099c110b61 commit b040fda5a81f54c4dbab7664f3aaf2099c110b61 Author: isandrk <isandrk@chromium.org> Date: Thu Dec 08 15:03:24 2016 Public Sessions - prompt the user for audioCapture/videoCapture requests In Public Sessions extensions are force installed by admin policy and some of the permissions are granted at install time so the end user has no say on it. audioCapture and videoCapture APIs are dangerous from a security/privacy standpoint therefore we want to give the user a runtime prompt whether to allow such API. Only platform apps (and some built-in whitelisted extensions) support audioCapture[1]/videoCapture[2] manifest permission features therefore this filtering will be limited to platform apps. [1]: https://cs.chromium.org/chromium/src/extensions/common/api/_permission_features.json?rcl=0&l=102 [2]: https://cs.chromium.org/chromium/src/extensions/common/api/_permission_features.json?rcl=0&l=491 BUG= 669521 Review-Url: https://codereview.chromium.org/2532323003 Cr-Commit-Position: refs/heads/master@{#437243} [modify] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/BUILD.gn [modify] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc [modify] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc [add] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/media/public_session_media_access_handler.cc [add] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/media/public_session_media_access_handler.h [modify] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
,
Dec 12 2016
Adding this in privacy component as FYI.
,
Jan 4 2017
,
Feb 1 2017
Which ChromeOS Release/Milestone is this targeted for? @sduraisamy, Do we need to request an Accessibility Review for this?
,
Feb 1 2017
,
Feb 1 2017
,
Feb 1 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 2 2017
@Krishna: This should already be in M-57, right (ie. no backmerge required)?
,
Feb 4 2017
+ Drew I believe manual merge to M57-beta is required as per comment #8
,
Feb 6 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2017
Raj: This is already in M-57, clarified everything with Drew. Crbugs are only for tracking purposes, the real stuff gets done at crrev. I commited this before the branch point, therefore it's in there. Krishna: I don't think this needs an Accessibility Review as this reuses existing functionality and prompts.
,
Feb 7 2017
,
Feb 17 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by isandrk@chromium.org
, Dec 5 2016129 KB
129 KB View Download