New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669521 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 689539



Sign in to add a comment

Public Session whitelisting - prompt the user for audioCapture/videoCapture requests

Project Member Reported by isandrk@chromium.org, Nov 29 2016

Issue description

In Public Sessions extensions are force installed by admin policy and some of the permissions are granted at install time so the end user has no say on it. audioCapture and videoCapture APIs are dangerous from a security/privacy standpoint therefore we want to give the user a runtime prompt whether to allow such API.
 
Added a screenshot showcasing the new functionality.
Screenshot from 2016-12-05 14:00:54.png
129 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b040fda5a81f54c4dbab7664f3aaf2099c110b61

commit b040fda5a81f54c4dbab7664f3aaf2099c110b61
Author: isandrk <isandrk@chromium.org>
Date: Thu Dec 08 15:03:24 2016

Public Sessions - prompt the user for audioCapture/videoCapture requests

In Public Sessions extensions are force installed by admin policy and some of the permissions are granted at install time so the end user has no say on it. audioCapture and videoCapture APIs are dangerous from a security/privacy standpoint therefore we want to give the user a runtime prompt whether to allow such API.

Only platform apps (and some built-in whitelisted extensions) support audioCapture[1]/videoCapture[2] manifest permission features therefore this filtering will be limited to platform apps.

[1]: https://cs.chromium.org/chromium/src/extensions/common/api/_permission_features.json?rcl=0&l=102
[2]: https://cs.chromium.org/chromium/src/extensions/common/api/_permission_features.json?rcl=0&l=491

BUG= 669521 

Review-Url: https://codereview.chromium.org/2532323003
Cr-Commit-Position: refs/heads/master@{#437243}

[modify] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/BUILD.gn
[modify] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
[modify] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[add] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/media/public_session_media_access_handler.cc
[add] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/media/public_session_media_access_handler.h
[modify] https://crrev.com/b040fda5a81f54c4dbab7664f3aaf2099c110b61/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc

Comment 3 by vabr@chromium.org, Dec 12 2016

Components: Privacy
Adding this in privacy component as FYI.
Status: Fixed (was: Started)
Which ChromeOS Release/Milestone is this targeted for?
@sduraisamy,
Do we need to request an Accessibility Review for this?

Labels: M-57
Labels: Merge-Request-57
Project Member

Comment 8 by sheriffbot@chromium.org, Feb 1 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: krishna...@chromium.org
@Krishna: This should already be in M-57, right (ie. no backmerge required)?
Cc: atwilson@chromium.org
Status: Assigned (was: Fixed)
+ Drew

I believe manual merge to M57-beta is required as per comment #8
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 6 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-57
Raj: This is already in M-57, clarified everything with Drew. Crbugs are only for tracking purposes, the real stuff gets done at crrev. I commited this before the branch point, therefore it's in there.

Krishna: I don't think this needs an Accessibility Review as this reuses existing functionality and prompts.
Blockedon: 689539
Status: Fixed (was: Assigned)
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment