New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 669498 link

Starred by 5 users
Status: Fixed
Owner:
█ shanmug...@samsung.com
Last visit > 30 days ago
Closed: Aug 2017
Cc:
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Remove SVGPathElement.getPathSegAtLength

Project Member Reported by f...@opera.com, Nov 29 2016 
This interface should probably have been removed as part of the pathSegList ( issue 539385 ), since it's not very useful without it. (It produces as output an index into the that list of SVGPathSegs.)
It was probably kept around because it (mistakenly) wasn't part of the SVGPathSegDOM counter... I wouldn't expect usage to be high.

The "SVG Paths" draft has a similar method, but with a different name and a slightly different signature: https://svgwg.org/specs/paths/#InterfaceSVGPathElement

Comment 1 by foolip@chromium.org, Feb 16 2017

Blocking: 674593

Comment 2 by foolip@chromium.org, Mar 9 2017

Cc: foolip@chromium.org

Comment 3 by shanmug...@samsung.com, Apr 5 2017 

Should we need to add use counter first and following with Deprecation and Remove ?

Comment 4 by f...@opera.com, Apr 5 2017 

That would be the formal way, yes.

Comment 5 by schenney@chromium.org, Apr 5 2017

Labels: BugSource-Team PaintTeamTriaged-20161129

Comment 6 by shanmug...@samsung.com, Apr 11 2017

Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89b08748a1f0bef747dd1b15f3e80ad9dc70c7b9

commit 89b08748a1f0bef747dd1b15f3e80ad9dc70c7b9
Author: shanmuga.m <shanmuga.m@samsung.com>
Date: Wed Apr 12 07:49:35 2017

Measure SVGPathElement.getPathSegAtLength usage

This interface removed from Spec.
Measuring this usage will be useful to remove this.

BUG= 669498 

Review-Url: https://codereview.chromium.org/2814723002
Cr-Commit-Position: refs/heads/master@{#463948}

[modify] https://crrev.com/89b08748a1f0bef747dd1b15f3e80ad9dc70c7b9/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/89b08748a1f0bef747dd1b15f3e80ad9dc70c7b9/third_party/WebKit/Source/core/svg/SVGPathElement.idl
[modify] https://crrev.com/89b08748a1f0bef747dd1b15f3e80ad9dc70c7b9/tools/metrics/histograms/histograms.xml

Comment 9 by shanmug...@samsung.com, Jul 31 2017

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/689341acba51283b996de1838b1f0faf4e81a4d7

commit 689341acba51283b996de1838b1f0faf4e81a4d7
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Wed Aug 09 10:53:52 2017

Remove SVGPathElement.getPathSegAtLength.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Gc1Aw282beo

Bug:  669498 
Change-Id: If54050a6692806c4002414b6e435412bb4885c10
Reviewed-on: https://chromium-review.googlesource.com/593510
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492939}
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/LayoutTests/fast/dom/non-numeric-values-numeric-parameters.html
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/LayoutTests/svg/css/path-element.html
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-valid-arguments.html
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/LayoutTests/svg/dom/path-queries-pathLength.html
[delete] https://crrev.com/94d7eeddc2025a863910735110d3815e3c9382c2/third_party/WebKit/LayoutTests/svg/dom/script-tests/svgpath-getPathSegAtLength.js
[delete] https://crrev.com/94d7eeddc2025a863910735110d3815e3c9382c2/third_party/WebKit/LayoutTests/svg/dom/svgpath-getPathSegAtLength-expected.txt
[delete] https://crrev.com/94d7eeddc2025a863910735110d3815e3c9382c2/third_party/WebKit/LayoutTests/svg/dom/svgpath-getPathSegAtLength.html
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/Source/core/svg/SVGPathElement.cpp
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/Source/core/svg/SVGPathElement.h
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/Source/core/svg/SVGPathElement.idl
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/Source/core/svg/SVGPathQuery.cpp
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/Source/core/svg/SVGPathQuery.h
[modify] https://crrev.com/689341acba51283b996de1838b1f0faf4e81a4d7/third_party/WebKit/public/platform/web_feature.mojom

Comment 11 by shanmug...@samsung.com, Aug 17 2017

Status: Fixed (was: Started)
►

Sign in to add a comment