Issue 669435 link

Starred by 2 users

Issue metadata

Status:	Assigned
Owner:	kouhei@chromium.org
Cc:	kouhei@chromium.org █ dominicc@chromium.org
Components:	Blink>HTML>Parser
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

ASSERTION FAILED: m_tokenizer

Project Member Reported by battre@chromium.org, Nov 29 2016

Issue description

The ASSERTION FAILED: m_tokenizer error can be found in many browser tests.

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/55136/steps/browser_tests%20on%20Windows-7-SP1/logs/CrSettingsPrefsTest.All
[ RUN      ] CrSettingsPrefsTest.All
[728:3412:1129/021324:INFO:media_foundation_video_encode_accelerator_win.cc(307)] Windows versions earlier than 8 are not supported.
[3980:4852:1129/021327:ERROR:render_process_impl.cc(112)] WebFrame LEAKED 1 TIMES
ASSERTION FAILED: m_tokenizer
Backtrace:
	blink::HTMLDocumentParser::pumpTokenizer [0x1C867703+115]
	blink::HTMLDocumentParser::pumpTokenizerIfPossible [0x1C867DFF+47]
	blink::HTMLDocumentParser::resumeParsingAfterScriptExecution [0x1C8682A6+390]
	blink::HTMLDocumentParser::executeScriptsWaitingForResources [0x1C863E2E+382]
	blink::Document::executeScriptsWaitingForResources [0x1C1ADFC8+56]
	??$Invoke@ABV?$WeakPersistent@VDocument@blink@@@blink@@$$V@?$FunctorTraits@P8Document@blink@@AEXXZX@internal@base@@SAXP8Document@blink@@AEXXZABV?$WeakPersistent@VDocument@blink@@@4@@Z [0x1C1659DE+46]
	??$MakeItSo@ABQ8Document@blink@@AEXXZABV?$WeakPersistent@VDocument@blink@@@2@$$V@?$InvokeHelper@$00X@internal@base@@SAXABQ8Document@blink@@AEXXZABV?$WeakPersistent@VDocument@blink@@@4@@Z [0x1C1665F4+68]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::Document::*)(void),blink::WeakPersistent<blink::Document> >,void __cdecl(void)>::RunImpl<void (__thiscall blink::Document::*const &)(void),std::tuple<blink::WeakPersistent<blink::Do [0x1C166804+52]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::Document::*)(void),blink::WeakPersistent<blink::Document> >,void __cdecl(void)>::Run [0x1C195934+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),1,1> >::Run [0x1895671F+63]
	WTF::Function<void __cdecl(void),1>::operator() [0x189564A8+184]
	blink::TaskHandle::Runner::run [0x189E0A3B+59]
	base::internal::FunctorTraits<void (__thiscall blink::TaskHandle::Runner::*)(blink::TaskHandle const &),void>::Invoke<base::WeakPtr<blink::TaskHandle::Runner> const &,blink::TaskHandle const &> [0x189DE965+37]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall blink::TaskHandle::Runner::*const &)(blink::TaskHandle const &),base::WeakPtr<blink::TaskHandle::Runner> const &,blink::TaskHandle const &> [0x189DEA67+87]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::TaskHandle::Runner::*)(blink::TaskHandle const &),base::WeakPtr<blink::TaskHandle::Runner>,blink::TaskHandle>,void __cdecl(void)>::RunImpl<void (__thiscall blink::TaskHandle::Runner [0x189DEAE3+83]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::TaskHandle::Runner::*)(blink::TaskHandle const &),base::WeakPtr<blink::TaskHandle::Runner>,blink::TaskHandle>,void __cdecl(void)>::Run [0x189DFE04+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A274+68]
	base::debug::TaskAnnotator::RunTask [0x1008A40F+367]
	blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue [0x18DEBF16+1094]
	blink::scheduler::TaskQueueManager::DoWork [0x18DEA641+737]
	base::internal::FunctorTraits<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),void>::Invoke<base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x18DE014D+61]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall blink::scheduler::TaskQueueManager::*const &)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x18DE02A3+83]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::RunImpl<void (__thiscall blink::sc [0x18DE0392+114]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::Run [0x18DEC864+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A274+68]
	base::debug::TaskAnnotator::RunTask [0x1008A40F+367]
	base::MessageLoop::RunTask [0x10104B14+660]
	base::MessageLoop::DeferOrRunPendingTask [0x1010290C+44]
	base::MessageLoop::DoWork [0x10102EF2+242]
	base::MessagePumpDefault::Run [0x1010AD3E+190]
	base::MessageLoop::RunHandler [0x1010480C+444]
	base::RunLoop::Run [0x101B3FD4+52]
	content::RendererMain [0x142A49FE+830]
	content::RunNamedProcessTypeMain [0x146D6147+135]
	content::ContentMainRunnerImpl::Run [0x146D6008+488]
	content::ContentMain [0x146D3F24+100]
	content::LaunchTests [0x03213C7C+556]
	LaunchChromeTests [0x05AE27B3+211]
	main [0x05AE21E9+89]
	invoke_main [0x05AE0ACE+30] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:64)
	__scrt_common_main_seh [0x05AE09D0+336] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253)
	__scrt_common_main [0x05AE087D+13] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:296)
	mainCRTStartup [0x05AE0AE8+8] (f:\ddctools\crtcstartup\src\startup\exe_main.cpp:17)
	BaseThreadInitThunk [0x7667338A+18]
	RtlInitializeExceptionChain [0x77449902+99]
	RtlInitializeExceptionChain [0x774498D5+54]
[4364:2656:1129/021328:ERROR:process_win.cc(135)] Unable to terminate process: Access is denied. (0x5)

CrControlledRadioButtonTest.All
CrExtensionsBrowserTest.ExtensionDetailViewClickableElementsTest
CrExtensionsBrowserTest.ExtensionErrorPageCodeSectionTest
CrExtensionsBrowserTest.ExtensionErrorPageErrorSelectionTest
CrExtensionsBrowserTest.ExtensionItemDeveloperStateTest
CrExtensionsBrowserTest.ExtensionItemList
CrExtensionsBrowserTest.ExtensionItemNormalStateTest
CrExtensionsBrowserTest.ExtensionItemSourceIndicatorTest
CrExtensionsBrowserTest.ExtensionManagerItemOrderTest
CrExtensionsBrowserTest.ExtensionOptionsDialogInteractionTest
CrExtensionsBrowserTest.ExtensionPackDialogInteractionTest
CrExtensionsBrowserTest.ExtensionShortcutInputTest
CrExtensionsBrowserTest.ExtensionShortcutUtilTest
CrExtensionsBrowserTestWithIdQueryParam.ExtensionManagerNavigationToDetailsTest
CrExtensionsBrowserTestWithInstalledExtension.ExtensionServiceProfileSettingsTest
CrExtensionsBrowserTestWithInstalledExtension.ExtensionServiceToggleEnableTest
CrExtensionsBrowserTestWithInstalledExtension.ExtensionServiceToggleIncognitoTest
CrExtensionsBrowserTestWithInstalledExtension.ExtensionServiceUninstallTest
CrExtensionsBrowserTestWithMultipleExtensionTypesInstalled.ExtensionManagerChangePagesTest
CrExtensionsBrowserTestWithMultipleExtensionTypesInstalled.ExtensionManagerItemListVisibilityTest
CrExtensionsBrowserTestWithMultipleExtensionTypesInstalled.ExtensionManagerShowItemsTest
CrSettingsCheckboxTest.All
CrSettingsDefaultBrowserTest.DefaultBrowserPage
CrSettingsDropdownMenuTest.All
CrSettingsExtensionControlledIndicatorTest.All
CrSettingsLanguagesTest.Languages
CrSettingsMenuTest.SettingsMenu
CrSettingsPrefsTest.All
CrSettingsRouteDynamicParametersTest.All
CrSettingsSearchEnginesTest.SearchEngines
CrSettingsToggleButtonTest.All
PDFExtensionTest.EnsureSameOriginRepliesAllowed
PDFExtensionTest.LinkCtrlShiftLeftClick
PDFExtensionTest.LinkShiftMiddleClick
PasswordsAndFormsBrowserTest.uiTests
SettingsAdvancedSubPageBrowserTest.SubPages
SettingsAutofillSectionBrowserTest.CreditCardTests
SettingsHelpPageBrowserTest.Load

On Mac OS a subset fails: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/4212/steps/browser_tests%20on%20Mac-10.11/logs/CrSettingsPrefUtilTest.All

CrControlledButtonTest.All
CrSettingsLanguagesTest.Languages
CrSettingsPrefsTest.All
CrSettingsRouteTest.All
CrSettingsSiteSettingsTest.SiteSettings
SettingsAnimationBrowserTest.Animation

with a less useful stack trace:

0   browser_tests                       0x000000010c9154d3 _ZN4base5debug10StackTraceC1Ev + 19
1   browser_tests                       0x000000010d00a9ca _ZN7content12_GLOBAL__N_1L27DumpStackTraceSignalHandlerEi + 202
2   libsystem_platform.dylib            0x00007fff984e652a _sigtramp + 26
3   ???                                 0x0000000000000000 0x0 + 0
4   CoreFoundation                      0x00007fff91edb1c4 __CFRunLoopServiceMachPort + 212
5   CoreFoundation                      0x00007fff91eda68c __CFRunLoopRun + 1356
6   CoreFoundation                      0x00007fff91ed9ed8 CFRunLoopRunSpecific + 296
7   HIToolbox                           0x00007fff89301935 RunCurrentEventLoopInMode + 235
8   HIToolbox                           0x00007fff8930176f ReceiveNextEventCommon + 432
9   HIToolbox                           0x00007fff893015af _BlockUntilNextEventMatchingListInModeWithFilter + 71
10  AppKit                              0x00007fff923dadf6 _DPSNextEvent + 1067
11  AppKit                              0x00007fff923da226 -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 454
12  browser_tests                       0x000000010ca28580 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64
13  browser_tests                       0x000000010c92eeca _ZN4base3mac15CallWithEHFrameEU13block_pointerFvvE + 10
14  browser_tests                       0x000000010ca284b9 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 169
15  AppKit                              0x00007fff923ced80 -[NSApplication run] + 682
16  browser_tests                       0x000000010c93d77e _ZN4base24MessagePumpNSApplication5DoRunEPNS_11MessagePump8DelegateE + 334
17  browser_tests                       0x000000010c93cdac _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 92
18  browser_tests                       0x000000010c939e9e _ZN4base11MessageLoop10RunHandlerEv + 94
19  browser_tests                       0x000000010c95bc53 _ZN4base7RunLoop3RunEv + 115
20  browser_tests                       0x000000010d0461cf _ZN7content14RunThisRunLoopEPN4base7RunLoopE + 79
21  browser_tests                       0x000000010d04616d _ZN7content14RunMessageLoopEv + 29
22  browser_tests                       0x000000010b06afd8 _ZN16WebUITestHandler13WaitForResultEv + 136
23  browser_tests                       0x000000010b06ac78 _ZN16WebUITestHandler27RunJavaScriptTestWithResultERKNSt3__112basic_stringItN4base20string16_char_traitsENS0_9allocatorItEEEE + 168
24  browser_tests                       0x000000010b184cb1 _ZN16WebUIBrowserTest25RunJavascriptUsingHandlerERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEERK12ScopedVectorIKN4base5ValueEEbbPN7content14RenderViewHostE + 689
25  browser_tests                       0x000000010b18514d _ZN16WebUIBrowserTest18RunJavascriptTestFEbRKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEES8_ + 333
26  browser_tests                       0x000000010b3c6cef _ZN31CrSettingsPrefUtilTest_All_Test19RunTestOnMainThreadEv + 671
27  browser_tests                       0x000000010c9c92b1 _ZN20InProcessBrowserTest23RunTestOnMainThreadLoopEv + 209
28  browser_tests                       0x000000010d00a726 _ZN7content15BrowserTestBase28ProxyRunTestOnMainThreadLoopEv + 278
29  browser_tests                       0x000000010ca2d041 _ZN22ChromeBrowserMainParts25PreMainMessageLoopRunImplEv + 4177
30  browser_tests                       0x000000010ca2beee _ZN22ChromeBrowserMainParts21PreMainMessageLoopRunEv + 62
31  browser_tests                       0x000000010c161933 _ZN7content15BrowserMainLoop21PreMainMessageLoopRunEv + 67
32  browser_tests                       0x000000010c481aa6 _ZN7content17StartupTaskRunner14RunAllTasksNowEv + 38
33  browser_tests                       0x000000010c16015e _ZN7content15BrowserMainLoop18CreateStartupTasksEv + 654
34  browser_tests                       0x000000010c16404b _ZN7content21BrowserMainRunnerImpl10InitializeERKNS_18MainFunctionParamsE + 683
35  browser_tests                       0x000000010c15db44 _ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 100
36  browser_tests                       0x000000010c8fe991 _ZN7content21ContentMainRunnerImpl3RunEv + 497
37  browser_tests                       0x000000010c8fdb56 _ZN7content11ContentMainERKNS_17ContentMainParamsE + 54
38  browser_tests                       0x000000010d00a43e _ZN7content15BrowserTestBase5SetUpEv + 1902
39  browser_tests                       0x000000010c9c8584 _ZN20InProcessBrowserTest5SetUpEv + 340
40  browser_tests                       0x000000010d7014ab _ZN7testing4Test3RunEv + 299
41  browser_tests                       0x000000010d702340 _ZN7testing8TestInfo3RunEv + 576
42  browser_tests                       0x000000010d7029f7 _ZN7testing8TestCase3RunEv + 455
43  browser_tests                       0x000000010d708c27 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 967
44  browser_tests                       0x000000010d708829 _ZN7testing8UnitTest3RunEv + 265
45  browser_tests                       0x000000010c9d8095 _ZN4base9TestSuite3RunEv + 133
46  browser_tests                       0x000000010c90868f _ZN21ChromeTestSuiteRunner12RunTestSuiteEiPPc + 31
47  browser_tests                       0x000000010d0430ee _ZN7content11LaunchTestsEPNS_20TestLauncherDelegateEiiPPc + 302
48  browser_tests                       0x000000010c90861a main + 90
49  libdyld.dylib                       0x00007fff97ab85ad start + 1
50  ???                                 0x0000000000000009 0x0 + 9

Suspected CLs:
Change #35274 https://codereview.chromium.org/2478233002
Change #35275 https://codereview.chromium.org/2536753003
Change #35276 https://codereview.chromium.org/2539683002
Change #35277 https://codereview.chromium.org/2537043002

Comment 1 by battre@chromium.org, Nov 29 2016

Starting a speculative revert.

Comment 2 by battre@chromium.org, Nov 29 2016

Reverted #35277 ("After detach, there's no document to notify parsing is finished") here https://codereview.chromium.org/2538473004/ (sorry, forgot to link this bug)

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acbd50fc4a51624a65c53ec760cff2bec03ae943

commit acbd50fc4a51624a65c53ec760cff2bec03ae943
Author: battre <battre@chromium.org>
Date: Tue Nov 29 11:42:20 2016

Revert of Script blocking resources tracking should be only done by Document::isScriptExecutionReady (patchset #3 id:40001 of https://codereview.chromium.org/2536753003/ )

Reason for revert:
Speculative revert for crbug.com/669435.

BUG=669435

Original issue's description:
> Script blocking resources tracking should be only done by Document::isScriptExecutionReady
>
> Before this CL, we had a duplicated tracking flag
> HTMLScriptRunner::m_hasScriptsWaitingForResources.
>
> This CL removes the flag in HTMLScriptRunner and changes code so it checks
> Document::isScriptExecutionReady() state instead.
>
> This CL also removes a comment referring to HTMLDocumentParser::executeScriptsWaitingForResources
> being called when it hasScriptsWaitingForResources as it should never happen
> and replaces it with a DCHECK
>
> BUG=None
>
> Committed: https://crrev.com/74341a4386cbe0c0b94eba0535fbbbf8d1aff8ea
> Cr-Commit-Position: refs/heads/master@{#434935}

TBR=dominicc@chromium.org,yhirano@chromium.org,kouhei@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2540653002
Cr-Commit-Position: refs/heads/master@{#434960}

[modify] https://crrev.com/acbd50fc4a51624a65c53ec760cff2bec03ae943/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/acbd50fc4a51624a65c53ec760cff2bec03ae943/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp
[modify] https://crrev.com/acbd50fc4a51624a65c53ec760cff2bec03ae943/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.h

Comment 4 by kouhei@chromium.org, Nov 29 2016

Thanks for the revert.

The stack traces are interesting as it is on the synchronous parsing path (which I thought was disabled).

Comment 5 by ajha@chromium.org, Nov 29 2016

Components: Blink>DOM

Comment 6 by dominicc@chromium.org, Nov 30 2016

Owner: kouhei@chromium.org

I am going to revert your revert of #35277 ("After detach, there's no document to notify parsing is finished"), I don't think this is related. That change is just for "view source."

Comment 7 by dominicc@chromium.org, Nov 30 2016

Ah, I see you already did this in https://codereview.chromium.org/2535233002/ . TY.

Comment 8 by tkent@chromium.org, Dec 1 2016

Components: -Blink>DOM Blink>HTML>Parser
Status: Assigned (was: Untriaged)

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b30f9793a39310391ecea42643798877e113fc4

commit 3b30f9793a39310391ecea42643798877e113fc4
Author: kouhei <kouhei@chromium.org>
Date: Fri Dec 02 07:10:29 2016

Reland Script blocking resources tracking should be only done by Document::isScriptExecutionReady"

This reverts commit acbd50fc4a51624a65c53ec760cff2bec03ae943.

Chrome extensions may invoke executeScriptsWaitingForResources() on HTMLDocumentParser before initializing background HTML parser thread.
This CL relands the patch + null check for m_tokenizer.

BUG=669435

Review-Url: https://codereview.chromium.org/2544733002
Cr-Commit-Position: refs/heads/master@{#435874}

[modify] https://crrev.com/3b30f9793a39310391ecea42643798877e113fc4/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/3b30f9793a39310391ecea42643798877e113fc4/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp
[modify] https://crrev.com/3b30f9793a39310391ecea42643798877e113fc4/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.h

►

Issue 669435 link

Issue metadata

ASSERTION FAILED: m_tokenizer

Issue description

Comment 1 by battre@chromium.org, Nov 29 2016

Comment 1 Deleted

Comment 2 by battre@chromium.org, Nov 29 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Nov 29 2016

Comment 3 Deleted

Comment 4 by kouhei@chromium.org, Nov 29 2016

Comment 4 Deleted

Comment 5 by ajha@chromium.org, Nov 29 2016

Comment 5 Deleted

Comment 6 by dominicc@chromium.org, Nov 30 2016

Comment 6 Deleted

Comment 7 by dominicc@chromium.org, Nov 30 2016

Comment 7 Deleted

Comment 8 by tkent@chromium.org, Dec 1 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Dec 2 2016

Comment 9 Deleted

Sign in to add a comment