New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669413 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Regression : ChromeVox(spoken feedback) is Reading without enabling option from Accessibility in Sign-in User

Project Member Reported by mmanchala@chromium.org, Nov 29 2016

Issue description

Version: 56.0.2924.8/9000.9.0 dev-channel Cyan,Candy and Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Make sure that ChromeVox(spoken feedback)  option is not selected from 'Accessibility' at Uber Tray
(2)Now click on 'Sign out' in Uber Tray -> In sign out screen select ChromeVox(spoken feedback) option(from 'Accessibility' at Uber Tray)
(3)Now Sign in -> Observe ChromeVox(spoken feedback) is reading without enabling option(from Accessibility)

Expected: ChromeVox(spoken feedback) should read only after enabling option from Accessibility
Actual: Instead ChromeVox(spoken feedback) is reading

This is Regression Issue as same is working fine in 54.0.2840.101/8743.85.0 stable channel butterfly.
@dmazzoni: Please confirm the Issue

Note : Issue is also seen in M-57 i.e. 57.0.2933.0/9028.0.0 dev-Channel Candy.
 
Actual.jpg
133 KB View Download
Issue is also seen in 56.0.2924.9/9000.10.0 dev-channel Cyan
Labels: Needs-Bisect
I wasn't aware of this bug. Can you bisect?

Labels: -Needs-Bisect
As per comment # 2 verified in M-55 Beta(55.0.2883.64/8872.64.0).Able to reproduce the issue on this build
Labels: -ReleaseBlock-Beta -M-56
Issue not a regression in M56 as was there from M55. Removing ReleaseBlock-Beta label as M55 Beta has been shipping with the issue.
To clarify, because I was confused about the original description:

When you enable Spoken Feedback from the sign-in screen, and then sign into an account, it's supposed to carry forward and keep Spoken Feedback on. What seems to be happening is that Spoken Feedback is staying on in the background somehow, but not for that particular account, so it's talking but not responding to the keyboard, and not showing up as enabled in the uber tray.

We verified that the bug doesn't happen in M54 8743.87.0.  We also double checked the login behavior, which is NOT as described in #5.

When you enable ChromeVox on the login screen and then sign into an existing account, ChromeVox is not enabled for the user.  When you sign out, ChromeVox is still enabled on the login screen.  The reverse is also true: enabling ChromeVox for a user will not enable it for the login screen.
Fix landing now: https://codereview.chromium.org/2597793002

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a878ed97521d84503ccb0d7f77666d45bfd52fa9

commit a878ed97521d84503ccb0d7f77666d45bfd52fa9
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Dec 21 23:31:23 2016

Fix issue with signing in after ChromeVox was enabled in login screen

The call to AccessibilityExtensionLoader::SetProfile from
AccessibilityManager::SetProfile was causing a race condition that left
ChromeVox in a partially-loaded state, i.e. the extension was active but
AccessibilityManager thought it was not.

It turns out this call isn't necessary at all, because it's already
going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref()
either way.

Kevin Chao and I manually tested with this patch and confirmed that this
fixes this specific issue and doesn't cause any new regressions.

BUG= 669413 
TESTED=Try various permutations of signing in and out with ChromeVox off and on
TBR=dtseng@chromium.org

Review-Url: https://codereview.chromium.org/2597793002
Cr-Commit-Position: refs/heads/master@{#440261}

[modify] https://crrev.com/a878ed97521d84503ccb0d7f77666d45bfd52fa9/chrome/browser/chromeos/accessibility/accessibility_manager.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment