"org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testImageControl" is flaky |
||||
Issue description"org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testImageControl" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuY29udGV4dHVhbHNlYXJjaC5Db250ZXh0dWFsU2VhcmNoTWFuYWdlclRlc3QjdGVzdEltYWdlQ29udHJvbAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 29 2016
Here's the native crash:
r0 00000000 r1 0000795e r2 00000006 r3 00000000
r4 aef98980 r5 00000006 r6 aef98930 r7 0000010c
r8 aef97528 r9 aef9799c sl 00000000 fp 0000000a
ip 0000006e sp aef973b0 lr b6c77249 pc b6c788dc
Stack Trace:
RELADDR FUNCTION FILE:LINE
000488dc tgkill+12 /system/lib/libc.so
00047245 pthread_kill+36 /system/lib/libc.so
0001ba3b raise+10 /system/lib/libc.so
000182e5 __libc_android_abort+36 /system/lib/libc.so
00016488 abort+4 /system/lib/libc.so
v------> DebugBreak /b/c/b/Android_arm_Builder__dbg_/src/base/debug/debugger_posix.cc:221
003bb53b base::debug::BreakDebugger()+18 /b/c/b/Android_arm_Builder__dbg_/src/base/debug/debugger_posix.cc:251
003cfebd logging::LogMessage::~LogMessage()+572 /b/c/b/Android_arm_Builder__dbg_/src/base/logging.cc:748
00e8b3c7 cc::SingleThreadProxy::SetNeedsAnimate()+174 /b/c/b/Android_arm_Builder__dbg_/src/cc/trees/single_thread_proxy.cc:158
00e6e797 cc::LayerTreeHostInProcess::SetNeedsAnimate()+12 /b/c/b/Android_arm_Builder__dbg_/src/cc/trees/layer_tree_host_in_process.cc:466
01a835a3 content::CompositorImpl::SetNeedsComposite()+106 /b/c/b/Android_arm_Builder__dbg_/src/content/browser/renderer_host/compositor_impl_android.cc:592
0216dd91 Java_org_chromium_chrome_browser_compositor_CompositorView_nativeSetNeedsComposite+88 /b/c/b/Android_arm_Builder__dbg_/src/out/Debug/gen/chrome/browser/jni_headers/chrome/jni/CompositorView_jni.h:147
012085a7 offset 0xe29000) (void org.chromium.chrome.browser.compositor.CompositorView.nativeSetNeedsComposite(long)+82 /data/app/org.chromium.chrome-1/oat/arm/base.odex
0120a125 offset 0xe29000) (void org.chromium.chrome.browser.compositor.CompositorView.requestRender()+168 /data/app/org.chromium.chrome-1/oat/arm/base.odex
0120f979 offset 0xe29000) (void org.chromium.chrome.browser.compositor.CompositorViewHolder.requestRender()+60 /data/app/org.chromium.chrome-1/oat/arm/base.odex
012240c9 offset 0xe29000) (void org.chromium.chrome.browser.compositor.layouts.LayoutManager.requestUpdate()+92 /data/app/org.chromium.chrome-1/oat/arm/base.odex
01219773 offset 0xe29000) (void org.chromium.chrome.browser.compositor.bottombar.OverlayPanelAnimation.requestUpdate()+94 /data/app/org.chromium.chrome-1/oat/arm/base.odex
0121743b offset 0xe29000) (void org.chromium.chrome.browser.compositor.bottombar.OverlayPanelAnimation.addToAnimation(org.chromium.chrome.browser.compositor.layouts.ChromeAnimation$Animation)+326 /data/app/org.chromium.chrome-1/oat/arm/base.odex
012172ad offset 0xe29000) (void org.chromium.chrome.browser.compositor.bottombar.OverlayPanelAnimation.addToAnimation(org.chromium.chrome.browser.compositor.layouts.ChromeAnimation$Animatable, java.lang.Enum, float, float, long, long, boolean, android.view.animation.Interpolator)+184 /data/app/org.chromium.chrome-1/oat/arm/base.odex
01ca9551 offset 0xe29000) (void org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchImageControl.animateStaticImageVisibility(boolean)+596 /data/app/org.chromium.chrome-1/oat/arm/base.odex
01ca9fa9 offset 0xe29000) (void org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchImageControl.onThumbnailFetched(boolean)+260 /data/app/org.chromium.chrome-1/oat/arm/base.odex
00a995e1 offset 0x5f9000) (void org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testImageControl()+236 ...
It looks like it's throwing an error in cc::SingleThreadProxy::SetNeedsAnimate(), possibly on the DCHECK(task_runner_provider_->IsMainThread());
I'm going to try enclosing calls to CSImageControl methods in run on UI thread blocks in the test.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/178b21a3089c78d3d4dbd3ccdcb7b967959ecf5a commit 178b21a3089c78d3d4dbd3ccdcb7b967959ecf5a Author: twellington <twellington@chromium.org> Date: Tue Nov 29 18:43:32 2016 [Contextual Search] Fix flaky tests Attempt to fix ContextualSearchManagerTest#testImageControl() by running calls to the ContextualSearchImageControl on the UI thread. Also add @RetryOnFailure to #testTapOnRoleIgnored(). BUG= 669405 , 669565 Review-Url: https://codereview.chromium.org/2534193002 Cr-Commit-Position: refs/heads/master@{#435040} [modify] https://crrev.com/178b21a3089c78d3d4dbd3ccdcb7b967959ecf5a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
,
Nov 30 2016
Fix landed, taking this out of the sheriffing queue.
,
Nov 30 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jbudorick@chromium.org
, Nov 29 2016Owner: donnd@chromium.org
Status: Assigned (was: Untriaged)