Issue metadata
Sign in to add a comment
|
Do not double fetch offline page downloads on start up |
||||||||||||||||||||||
Issue descriptionSince offline pages team resolved the initial issue, when offline pages query resulted in empty result before the model was loaded ( issue 668174 , https://codereview.chromium.org/2536573003), our workaround may fetch the pages twice.
,
Feb 1 2017
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64245189bdea8d0ee8496f76b3c4d278610274e9 commit 64245189bdea8d0ee8496f76b3c4d278610274e9 Author: vitaliii <vitaliii@chromium.org> Date: Thu Feb 02 11:59:48 2017 [NTP::Downloads] Do not fetch Offline Pages when their model is loaded. Previously we used to query Offline Pages model both in the constructor and when Offline Page model was loaded. However, after https://codereview.chromium.org/2536573003 if Offline Page model is not loaded, it waits and replies only after it has been loaded, so the fetch in the constructor is now sufficient. This CL removes the fetch from OfflinePageModelLoaded and related tests. BUG= 669404 Review-Url: https://codereview.chromium.org/2667073003 Cr-Commit-Position: refs/heads/master@{#447743} [modify] https://crrev.com/64245189bdea8d0ee8496f76b3c4d278610274e9/chrome/browser/ntp_snippets/download_suggestions_provider.cc [modify] https://crrev.com/64245189bdea8d0ee8496f76b3c4d278610274e9/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
,
Feb 2 2017
,
Feb 20 2017
Requesting to merge the CL from comment #3 to M57. It is needed in order to merge issue 690391 cleanly (which is a bug fix, which would greatly improve user experience).
,
Feb 20 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cdefe6184da5cd4e23d47bd2df7f17cc6d4825b commit 9cdefe6184da5cd4e23d47bd2df7f17cc6d4825b Author: Vitalii Iarko <vitaliii@chromium.org> Date: Mon Feb 20 15:20:23 2017 Merge "[NTP::Downloads] Do not fetch Offline Pages when their model ..." This is a merge of https://codereview.chromium.org/2667073003 into M57 (branch 2987). This CL is needed in order to merge https://codereview.chromium.org/2683383002 ( issue 690391 ) into the same branch. There were no conflicts, it has been tested on two devices + unittests. Original description: Previously we used to query Offline Pages model both in the constructor and when Offline Page model was loaded. However, after https://codereview.chromium.org/2536573003 if Offline Page model is not loaded, it waits and replies only after it has been loaded, so the fetch in the constructor is now sufficient. This CL removes the fetch from OfflinePageModelLoaded and related tests. BUG= 669404 Review-Url: https://codereview.chromium.org/2667073003 Cr-Commit-Position: refs/heads/master@{#447743} (cherry picked from commit 64245189bdea8d0ee8496f76b3c4d278610274e9) Review-Url: https://codereview.chromium.org/2706863002 . Cr-Commit-Position: refs/branch-heads/2987@{#597} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/9cdefe6184da5cd4e23d47bd2df7f17cc6d4825b/chrome/browser/ntp_snippets/download_suggestions_provider.cc [modify] https://crrev.com/9cdefe6184da5cd4e23d47bd2df7f17cc6d4825b/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
,
Mar 2 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fi...@chromium.org
, Dec 14 2016