Issue metadata
Sign in to add a comment
|
Failed steps failed compile for win/linux/mac Stable in official.desktop.continuous |
||||||||||||||||||||
Issue descriptionLink to Builder: ================ https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20stable/builds/1261 Link to Log File: ================= https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20stable/builds/1261/steps/compile/logs/stdio Error from the Log: =================== FAILED: obj/chrome/test/unit_tests/manage_passwords_view_utils_unittest.obj ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/chrome/test/unit_tests/manage_passwords_view_utils_unittest.obj.rsp /c ../../chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc /Foobj/chrome/test/unit_tests/manage_passwords_view_utils_unittest.obj /Fd"obj/chrome/test/unit_tests_cc.pdb" c:\b\build\slave\win_stable\build\src\chrome\browser\ui\passwords\manage_passwords_view_utils_unittest.cc(195): error C2653: 'PasswordTitleType': is not a class or namespace name c:\b\build\slave\win_stable\build\src\chrome\browser\ui\passwords\manage_passwords_view_utils_unittest.cc(195): error C2065: 'SAVE_PASSWORD': undeclared identifier Suspecting the below CL could be a possible root cause: https://chromium.googlesource.com/chromium/src/+/910f52d5209148d0ad1afa8cbfb9360d65fcb00e @vabr: Assigning to you, kindly have a look into it.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4848db843fb777547e7410d223e08198c8680252 commit 4848db843fb777547e7410d223e08198c8680252 Author: vabr <vabr@chromium.org> Date: Tue Nov 29 08:15:11 2016 Revert of Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully (patchset #1 id:1 of https://codereview.chromium.org/2534113002/ ) Reason for revert: Compile failure. BUG= 669394 Original issue's description: > Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully > > GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised > strings for particular IDs contain placeholders, and attempts to access the > vector of offsets corresponding to such placeholders. However, in some > situations (http://crbug.com/658902#c18) the localised string may be empty. > This led to an out-of-bounds access and crash on Android. > > This CL is the smallest change to handle such situation gracefully -- it checks > the length of the vector with offsets and gives up accessing it if it is empty. > This avoids the crash but results in displaying a UI with empty strings. > Ideally, the UI would also be supressed on these occasions, but that is left > for follow-up CLs. The current situation is already an improvement (password > manager is still not very useful, but at least the browser has a chance to > continue). > > The CL also removes the temporary logging put in for the crash investigation. > > BUG=658902 > > Review-Url: https://codereview.chromium.org/2526283002 > Cr-Commit-Position: refs/heads/master@{#434482} > (cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c) > > Committed: https://chromium.googlesource.com/chromium/src/+/910f52d5209148d0ad1afa8cbfb9360d65fcb00e TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=658902 Review-Url: https://codereview.chromium.org/2535183002 Cr-Commit-Position: refs/branch-heads/2883@{#675} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/4848db843fb777547e7410d223e08198c8680252/chrome/browser/ui/passwords/manage_passwords_view_utils.cc [modify] https://crrev.com/4848db843fb777547e7410d223e08198c8680252/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
,
Nov 29 2016
,
Nov 29 2016
Just to update, this is also observed on Linux OS: Build URL: ========== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20stable/builds/1068 Log URL: ======== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20stable/builds/1068/steps/compile/logs/stdio Will monitor next builds since the fix is already available and update accordingly. Thanks.!
,
Nov 29 2016
Same on MAC OS: Build URL: ========== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20stable Log URL: ======== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20stable/builds/1295/steps/compile/logs/stdio Thanks.!
,
Nov 30 2016
Just for the record: The revert from #2 here fixed the compilation. It is just that the builders are awfully slow (multiple hours to build), so the fix could only be confirmed later. By now, the compile error is away. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by vabr@chromium.org
, Nov 29 2016