Chrome Version : 56.0.2914.3
OS Version: OS X 10.12.1
This is invoked via the TabDialogs interface
It's possible, but it's not a straightforward port.
First (easy) step is: https://codereview.chromium.org/2536733005/
But then we need to fix
Undefined symbols for architecture x86_64:
"BrowserView::GetBrowserViewForBrowser(Browser const*)", referenced from:
ManagePasswordsBubbleView::AutoSigninView::AutoSigninView(ManagePasswordsBubbleView*) in libui.a(manage_passwords_bubble_view.o)
ManagePasswordsBubbleView::ShowBubble(content::WebContents*, LocationBarBubbleDelegateView::DisplayReason) in libui.a(manage_passwords_bubble_view.o)
manage_password_bubble_view.cc has dependencies on BrowserView (the views browser), but we need it also able to use a Cocoa browser.
AutoSigninView depends on it for:
void ManagePasswordsBubbleView::AutoSigninView::OnWidgetActivationChanged(
views::Widget* widget, bool active) {
if (active && !timer_.IsRunning())
timer_.Start(FROM_HERE, GetTimeout(), this, &AutoSigninView::OnTimer);
}
void ManagePasswordsBubbleView::AutoSigninView::OnWidgetClosing(
views::Widget* widget) {
observed_browser_.RemoveAll();
}
ManagePasswordsBubbleView::ShowBubble() depends on it for
* finding the anchor -- we have precedence for fixing that
* AddObserver(browser_view->GetLocationBarView()->manage_passwords_icon_view())
* for BubbleIconView's role as a views::WidgetObserver
* for
void BubbleIconView::OnWidgetDestroying(views::Widget* widget) {
widget->RemoveObserver(this);
}
void BubbleIconView::OnWidgetVisibilityChanged(views::Widget* widget,
bool visible) {
// |widget| is a bubble that has just got shown / hidden.
if (!visible)
AnimateInkDrop(views::InkDropState::DEACTIVATED, nullptr /* event */);
}
Comment 1 by tapted@chromium.org
, Dec 12 2016Labels: M-60