New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669386 link

Starred by 11 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Click to hide stories icon is seen missing in news.google.co.in

Project Member Reported by sc00335...@techmahindra.com, Nov 29 2016

Issue description

Version: 57.0.2936.0 dev
OS: Windows, Mac

What steps will reproduce the problem?
(1) Launch chrome and go to https://news.google.co.in/nwshp?hl=en&ei=mCw9WPqyJMTovATKkpLgDQ&ved=0EKkuCAgoAw
(2) Observe for click to hide stories icon under every story.

Expected: Should be able to see Click to hide stories button.
Actual: Instead click to hide stories button is missing.

This is a regression issue broken in M57. Will provide bisect info soon.
 
Labels: ReleaseBlock-Beta
Status: Untriaged (was: Unconfirmed)
Will update Linux behavior once build is available..
Manual Bisect Info:
====================
Good Build: 57.0.2931.0 dev
Bad Build: 57.0.2933.0 dev
Labels: -Needs-Bisect hasbisect-per-revision
Owner: sunyunjia@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2931.0 (Revision: 434310).
Bad build: 57.0.2933.0 (Revision: 434540).

You are probably looking for a change made after 434398 (known good), but no later than 434399 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/d0124d407177d3a9e0763682a791ab17b78394c0..7a880dd75bf766d22cbe4ba79bb168f7ea38c524

@sunyunjia -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.
Labels: OS-Linux
This issue is also seen in Linux latest 57.0.2936.4 dev.

Comment 5 by mustaq@chromium.org, Nov 30 2016

Cc: msrchandra@chromium.org kkaluri@chromium.org sunyunjia@chromium.org nyerramilli@chromium.org
 Issue 669472  has been merged into this issue.

Comment 6 by mustaq@chromium.org, Nov 30 2016

Confirmed that disabling touch events fixes the bug, so this is caused by a recent CL that changes AUTO behavior. We are working on a fix now.
Cc: mustaq@chromium.org dtapu...@chromium.org
 Issue 669869  has been merged into this issue.
Cc: hdodda@chromium.org
 Issue 669780  has been merged into this issue.
 Issue 669789  has been merged into this issue.
 Issue 669813  has been merged into this issue.
Cc: ranjitkan@chromium.org
 Issue 670233  has been merged into this issue.
 Issue 669873  has been merged into this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78171bf829d1ae47b7d7237c08878783a2cdadb5

commit 78171bf829d1ae47b7d7237c08878783a2cdadb5
Author: sunyunjia <sunyunjia@chromium.org>
Date: Fri Dec 02 02:04:55 2016

Reset the default value of touch event flag back to "Auto".

This is a partial revert of issue 2467913002.
https://codereview.chromium.org/2467913002

In the previous patch, we set the default value of touch-event-api as enabled.
However, this may cause troubles due to  http://crbug.com/392584 . Basically
there are still a bunch of websites on which mouse support is broken when the
TouchEvents API is present. So we need to retain the "auto" behavior as the
default. We also keep firing DOM events as before even when the flag says
disabled.

BUG= 644318 ,  669386 , 669132

Review-Url: https://codereview.chromium.org/2531413002
Cr-Commit-Position: refs/heads/master@{#435821}

[modify] https://crrev.com/78171bf829d1ae47b7d7237c08878783a2cdadb5/chrome/app/generated_resources.grd
[modify] https://crrev.com/78171bf829d1ae47b7d7237c08878783a2cdadb5/chrome/browser/about_flags.cc
[modify] https://crrev.com/78171bf829d1ae47b7d7237c08878783a2cdadb5/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
[modify] https://crrev.com/78171bf829d1ae47b7d7237c08878783a2cdadb5/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/78171bf829d1ae47b7d7237c08878783a2cdadb5/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/78171bf829d1ae47b7d7237c08878783a2cdadb5/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/78171bf829d1ae47b7d7237c08878783a2cdadb5/tools/metrics/histograms/histograms.xml

 Issue 670598  has been merged into this issue.
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Comment 17 by ajha@chromium.org, Dec 6 2016

 Issue 671128  has been merged into this issue.
Labels: Hotlist-Input-Dev

Sign in to add a comment