New issue
Advanced search Search tips

Issue 669368 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 669554
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Incorrect device scale factor on device

Project Member Reported by sadrul@chromium.org, Nov 29 2016

Issue description

On a daisy device, when chrome --mash is run, chrome launches in high-dpi mode, even though the device is not high-dpi. Presumably, the window-server/display-manager is computing the scale factor incorrectly on device.
 

Comment 1 by sadrul@chromium.org, Nov 29 2016

Owner: kylec...@chromium.org
Status: Assigned (was: Available)
Ah, I submitted a CL that has a fix for this on a different bug. The reason for the 2x device scale factor on daisy was because the physical size for the internal display was reported as (0, 0). The DPI had a divide by zero and NaN is apparently bigger than 200. The fix doesn't address why we're getting the incorrect physical_size. 
Here's the revision info from the other bug:

https://chromium.googlesource.com/chromium/src.git/+/916f5ba009ff7a858db4e8cc0e348372b74688b7

commit 916f5ba009ff7a858db4e8cc0e348372b74688b7
Author: kylechar <kylechar@chromium.org>
Date: Tue Nov 29 18:28:25 2016

mustash: Fix scale factor for bad physical_size.

On daisy devices the physical_size for display is being reported
incorrectly as (0, 0). Return a standard DPI in this case.

I've filled  crbug.com/669554  for the bad physical_size value.

BUG= 669554 

Review-Url: https://codereview.chromium.org/2539843002
Cr-Commit-Position: refs/heads/master@{#435037}

[modify] https://crrev.com/916f5ba009ff7a858db4e8cc0e348372b74688b7/services/ui/display/platform_screen_ozone.cc
Mergedinto: 669554
Status: Duplicate (was: Assigned)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment