Issue metadata
Sign in to add a comment
|
Frameset border not redrawn during window resize.
Reported by
mike.e.p...@gmail.com,
Nov 29 2016
|
||||||||||||||||||||||
Issue description
Chrome Version : Version 54.0.2840.99 m
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
Safari:
Firefox: OK 50.0.1
IE: OK 11.0.9600.18524
What steps will reproduce the problem?
(1) GOTO frames test page http://www.codertools.com/html_guide/realtime_online_html_editor.aspx?example=frames1&style=vert
(2) Drag to increase browser window width.
(3) NOTE the border is not drawn correctly
What is the expected result? The border should be drawn in the correct position
What happens instead? The border is drawn in the wrong position
Please provide any additional information below. Attach a screenshot if
possible.
,
Nov 29 2016
,
Nov 29 2016
This was not broken when using version 52.?.?
,
Nov 30 2016
Able to reproduce the issue on windows-7, Mac-10.11.6 using chrome stable version 54.0.2840.99 and canary 57.0.2936.0. This is regression issue broken in M54.Please find the bisect information as below Narrow Bisect:: =============== Good :54.0.2820.0 -- (build revision 409955) Bad:: 54.0.2821.0 -- (build revision 410228) ChangeLog: ================ https://chromium.googlesource.com/chromium/src/+log/75a77ebf006dffca4b545aac4f4f1ff6c3a03b18..8954d05887aba9640fa2621329622dfc2a0ba013 possible suspect ================== b7720c4c053a09050c9abab73b0af528150dd42c Review URL: https://codereview.chromium.org/2219663003 tapted@ could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue. Thanks.
,
Dec 1 2016
This is in blink. and Windows. https://codereview.chromium.org/2219663003 only affects Mac. Also it's behind flags. The only blink change in the changelog is https://codereview.chromium.org/2202173002 - it's a refactor. I suppose it's possible that data() is overridden at some point so that it doesn't return m_data, but I poked around a bit and I don't think that's the case. There are 273 changes in the "narrow" bisect, but the ChangeLog only links to 3. This needs to be bisected again.
,
Dec 1 2016
,
Dec 1 2016
Here you go You are probably looking for a change made after 409964 (known good), but no later than 409969 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/3a6cbe4c1dab38c5e9094a3ce6164b902c319bf2..bf18c4ea1428f95d8dcb33d4e9828df7f9a2eeac bdd41f4 Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with paintedOutputOfObjectHasNoEffect by wangxianzhu ยท 4 months ago
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc09797d2841a0da450266e2fd004d9e12c7b020 commit fc09797d2841a0da450266e2fd004d9e12c7b020 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Thu Dec 01 21:41:13 2016 Fix under-invalidation of frameset on resize Previously frameset had two problems: 1. (m-54 regression caused by https://codereview.chromium.org/2203933002) LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() returned true for frameset causing no invalidation when a frameset is resized. 2. (Not a regression) frameset should not do incremental invalidation. This didn't cause problem because the raster invalidation rects of the frames cover changed part of the frameset. BUG= 669327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2544743002 Cr-Commit-Position: refs/heads/master@{#435724} [add] https://crrev.com/fc09797d2841a0da450266e2fd004d9e12c7b020/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-frameset-expected.html [add] https://crrev.com/fc09797d2841a0da450266e2fd004d9e12c7b020/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-frameset-expected.txt [add] https://crrev.com/fc09797d2841a0da450266e2fd004d9e12c7b020/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-frameset.html [modify] https://crrev.com/fc09797d2841a0da450266e2fd004d9e12c7b020/third_party/WebKit/Source/core/layout/LayoutFrameSet.h [modify] https://crrev.com/fc09797d2841a0da450266e2fd004d9e12c7b020/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
,
Dec 3 2016
,
Dec 3 2016
,
Dec 3 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2410bcdc2a9f86a75a2ed5235e8f21cdc792d31a commit 2410bcdc2a9f86a75a2ed5235e8f21cdc792d31a Author: wangxianzhu <wangxianzhu@chromium.org> Date: Sat Dec 03 03:40:17 2016 Fix under-invalidation of frameset on resize Previously frameset had two problems: 1. (m-54 regression caused by https://codereview.chromium.org/2203933002) LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() returned true for frameset causing no invalidation when a frameset is resized. 2. (Not a regression) frameset should not do incremental invalidation. This didn't cause problem because the raster invalidation rects of the frames cover changed part of the frameset. BUG= 669327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 NOTRY=true NOPRESUBMIT=true TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2544743002 Review-Url: https://codereview.chromium.org/2546173003 Cr-Original-Commit-Position: refs/heads/master@{#435724} Cr-Commit-Position: refs/branch-heads/2924@{#315} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [add] https://crrev.com/2410bcdc2a9f86a75a2ed5235e8f21cdc792d31a/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-frameset-expected.html [add] https://crrev.com/2410bcdc2a9f86a75a2ed5235e8f21cdc792d31a/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-frameset-expected.txt [add] https://crrev.com/2410bcdc2a9f86a75a2ed5235e8f21cdc792d31a/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-frameset.html [modify] https://crrev.com/2410bcdc2a9f86a75a2ed5235e8f21cdc792d31a/third_party/WebKit/Source/core/layout/LayoutFrameSet.h [modify] https://crrev.com/2410bcdc2a9f86a75a2ed5235e8f21cdc792d31a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
,
Dec 3 2016
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31a69618a214eb36bad90baa1a4f4d6bc15d008e commit 31a69618a214eb36bad90baa1a4f4d6bc15d008e Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Dec 05 23:42:48 2016 Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting Checks that nothing should be painted if paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to catch under-invalidations caused by it. The verification also works during the first paint, so the existing layout tests have enough coverage for the function. Also fixed some check failures: - LayoutDetailsMarker: was actual under-invalidation. - LayoutView: as display item client of frame scroll corner. Was not an actual under-invalidation because scroll controls are invalidated separately, but change code to avoid the check failure. This is not applicable to rootLayerScrolling. - LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume there is always SVG effects. Objects painted in SkPictureBuilder are not checked. One example is LayoutSVGResourceClipper which doesn't have any painting on the backing, but may output paint operations in SkPictureBuilder for the clipped object. BUG= 669327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2549553002 Cr-Commit-Position: refs/heads/master@{#436455} [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.h [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/Source/core/layout/LayoutView.cpp [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/Source/core/layout/LayoutView.h [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/Source/platform/graphics/paint/PaintController.h [modify] https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e/third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.cpp
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6231f793a5e42804598473806f3f43046ac1fbc commit f6231f793a5e42804598473806f3f43046ac1fbc Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue Dec 06 01:03:04 2016 Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #8 id:140001 of https://codereview.chromium.org/2549553002/ ) Reason for revert: Breaks the following webkit_unit_tests: TableCellPainterTest.CollapsedBorderAndOverflow TablePainterTest.CollapsedBorderInterestRectChange All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/0 All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/2 All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/2 All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/0 on WebKit Win x64 Builder (dbg) https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/99618 Original issue's description: > Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting > > Checks that nothing should be painted if > paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to > catch under-invalidations caused by it. > > The verification also works during the first paint, so the existing > layout tests have enough coverage for the function. > > Also fixed some check failures: > - LayoutDetailsMarker: was actual under-invalidation. > - LayoutView: as display item client of frame scroll corner. Was not an > actual under-invalidation because scroll controls are invalidated > separately, but change code to avoid the check failure. This is not > applicable to rootLayerScrolling. > - LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume > there is always SVG effects. > > Objects painted in SkPictureBuilder are not checked. One example is > LayoutSVGResourceClipper which doesn't have any painting on the backing, > but may output paint operations in SkPictureBuilder for the clipped > object. > > BUG= 669327 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e > Cr-Commit-Position: refs/heads/master@{#436455} TBR=chrishtr@chromium.org,pdr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 669327 Review-Url: https://codereview.chromium.org/2550333002 Cr-Commit-Position: refs/heads/master@{#436476} [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.h [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/Source/core/layout/LayoutView.cpp [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/Source/core/layout/LayoutView.h [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/Source/platform/graphics/paint/PaintController.h [modify] https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc/third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.cpp
,
Dec 6 2016
#14 and #15 don't affect the status of this bug.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f64b7c27bc9a8757977498ee748c641bfe7247e commit 8f64b7c27bc9a8757977498ee748c641bfe7247e Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue Dec 06 03:58:21 2016 Reland of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #1 id:1 of https://codereview.chromium.org/2550333002/ ) Reason for revert: The failures were because of conflict with https://codereview.chromium.org/2502353003/ which has been reverted. Original issue's description: > Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #8 id:140001 of https://codereview.chromium.org/2549553002/ ) > > Reason for revert: > Breaks the following webkit_unit_tests: > TableCellPainterTest.CollapsedBorderAndOverflow > TablePainterTest.CollapsedBorderInterestRectChange > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/0 > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/2 > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/2 > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/0 > on WebKit Win x64 Builder (dbg) > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/99618 > > Original issue's description: > > Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting > > > > Checks that nothing should be painted if > > paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to > > catch under-invalidations caused by it. > > > > The verification also works during the first paint, so the existing > > layout tests have enough coverage for the function. > > > > Also fixed some check failures: > > - LayoutDetailsMarker: was actual under-invalidation. > > - LayoutView: as display item client of frame scroll corner. Was not an > > actual under-invalidation because scroll controls are invalidated > > separately, but change code to avoid the check failure. This is not > > applicable to rootLayerScrolling. > > - LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume > > there is always SVG effects. > > > > Objects painted in SkPictureBuilder are not checked. One example is > > LayoutSVGResourceClipper which doesn't have any painting on the backing, > > but may output paint operations in SkPictureBuilder for the clipped > > object. > > > > BUG= 669327 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > Committed: https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e > > Cr-Commit-Position: refs/heads/master@{#436455} > > TBR=chrishtr@chromium.org,pdr@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 669327 > > Committed: https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc > Cr-Commit-Position: refs/heads/master@{#436476} TBR=chrishtr@chromium.org,pdr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 669327 Review-Url: https://codereview.chromium.org/2554763002 Cr-Commit-Position: refs/heads/master@{#436518} [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.h [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/Source/core/layout/LayoutView.cpp [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/Source/core/layout/LayoutView.h [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/Source/platform/graphics/paint/PaintController.h [modify] https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e/third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.cpp
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f26eb8a561510d386054ad75a4a77bcb515f4f2 commit 4f26eb8a561510d386054ad75a4a77bcb515f4f2 Author: haraken <haraken@chromium.org> Date: Tue Dec 06 07:07:18 2016 Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #1 id:1 of https://codereview.chromium.org/2554763002/ ) Reason for revert: Reason for revert: A lot of css tests started failing after this CL: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6264 Original issue's description: > Reland of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #1 id:1 of https://codereview.chromium.org/2550333002/ ) > > Reason for revert: > The failures were because of conflict with https://codereview.chromium.org/2502353003/ which > has been reverted. > > Original issue's description: > > Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #8 id:140001 of https://codereview.chromium.org/2549553002/ ) > > > > Reason for revert: > > Breaks the following webkit_unit_tests: > > TableCellPainterTest.CollapsedBorderAndOverflow > > TablePainterTest.CollapsedBorderInterestRectChange > > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/0 > > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/2 > > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/2 > > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/0 > > on WebKit Win x64 Builder (dbg) > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/99618 > > > > Original issue's description: > > > Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting > > > > > > Checks that nothing should be painted if > > > paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to > > > catch under-invalidations caused by it. > > > > > > The verification also works during the first paint, so the existing > > > layout tests have enough coverage for the function. > > > > > > Also fixed some check failures: > > > - LayoutDetailsMarker: was actual under-invalidation. > > > - LayoutView: as display item client of frame scroll corner. Was not an > > > actual under-invalidation because scroll controls are invalidated > > > separately, but change code to avoid the check failure. This is not > > > applicable to rootLayerScrolling. > > > - LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume > > > there is always SVG effects. > > > > > > Objects painted in SkPictureBuilder are not checked. One example is > > > LayoutSVGResourceClipper which doesn't have any painting on the backing, > > > but may output paint operations in SkPictureBuilder for the clipped > > > object. > > > > > > BUG= 669327 > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > > > Committed: https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e > > > Cr-Commit-Position: refs/heads/master@{#436455} > > > > TBR=chrishtr@chromium.org,pdr@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG= 669327 > > > > Committed: https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc > > Cr-Commit-Position: refs/heads/master@{#436476} > > TBR=chrishtr@chromium.org,pdr@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 669327 > > Committed: https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e > Cr-Commit-Position: refs/heads/master@{#436518} TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 669327 Review-Url: https://codereview.chromium.org/2550373002 Cr-Commit-Position: refs/heads/master@{#436542} [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.h [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/Source/core/layout/LayoutView.cpp [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/Source/core/layout/LayoutView.h [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/Source/platform/graphics/paint/PaintController.h [modify] https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2/third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.cpp
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2deb8a493b29be6ba619e0e34b921e4e9339bbe7 commit 2deb8a493b29be6ba619e0e34b921e4e9339bbe7 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue Dec 06 17:09:50 2016 Reland of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #1 id:1 of https://codereview.chromium.org/2550373002/ ) Reason for revert: The reland is good. The failure was because of a conflicting CL https://codereview.chromium.org/2502353003/ that had been reverted before this revert. Original issue's description: > Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #1 id:1 of https://codereview.chromium.org/2554763002/ ) > > Reason for revert: > Reason for revert: > A lot of css tests started failing after this CL: > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6264 > > Original issue's description: > > Reland of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #1 id:1 of https://codereview.chromium.org/2550333002/ ) > > > > Reason for revert: > > The failures were because of conflict with https://codereview.chromium.org/2502353003/ which > > has been reverted. > > > > Original issue's description: > > > Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #8 id:140001 of https://codereview.chromium.org/2549553002/ ) > > > > > > Reason for revert: > > > Breaks the following webkit_unit_tests: > > > TableCellPainterTest.CollapsedBorderAndOverflow > > > TablePainterTest.CollapsedBorderInterestRectChange > > > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/0 > > > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/2 > > > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/2 > > > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/0 > > > on WebKit Win x64 Builder (dbg) > > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/99618 > > > > > > Original issue's description: > > > > Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting > > > > > > > > Checks that nothing should be painted if > > > > paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to > > > > catch under-invalidations caused by it. > > > > > > > > The verification also works during the first paint, so the existing > > > > layout tests have enough coverage for the function. > > > > > > > > Also fixed some check failures: > > > > - LayoutDetailsMarker: was actual under-invalidation. > > > > - LayoutView: as display item client of frame scroll corner. Was not an > > > > actual under-invalidation because scroll controls are invalidated > > > > separately, but change code to avoid the check failure. This is not > > > > applicable to rootLayerScrolling. > > > > - LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume > > > > there is always SVG effects. > > > > > > > > Objects painted in SkPictureBuilder are not checked. One example is > > > > LayoutSVGResourceClipper which doesn't have any painting on the backing, > > > > but may output paint operations in SkPictureBuilder for the clipped > > > > object. > > > > > > > > BUG= 669327 > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > > > > > Committed: https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e > > > > Cr-Commit-Position: refs/heads/master@{#436455} > > > > > > TBR=chrishtr@chromium.org,pdr@chromium.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG= 669327 > > > > > > Committed: https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc > > > Cr-Commit-Position: refs/heads/master@{#436476} > > > > TBR=chrishtr@chromium.org,pdr@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG= 669327 > > > > Committed: https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e > > Cr-Commit-Position: refs/heads/master@{#436518} > > TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 669327 > > Committed: https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2 > Cr-Commit-Position: refs/heads/master@{#436542} TBR=chrishtr@chromium.org,pdr@chromium.org,haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 669327 Review-Url: https://codereview.chromium.org/2550223003 Cr-Commit-Position: refs/heads/master@{#436622} [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-scrollable-iframe-expected.txt [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.h [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/Source/core/layout/LayoutView.cpp [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/Source/core/layout/LayoutView.h [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/Source/platform/graphics/paint/PaintController.h [modify] https://crrev.com/2deb8a493b29be6ba619e0e34b921e4e9339bbe7/third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.cpp |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jarkko.v...@gmail.com
, Nov 29 2016