New issue
Advanced search Search tips

Issue 669308 link

Starred by 0 users

Issue metadata

Status: Archived
Owner: ----
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 550684



Sign in to add a comment

Add index support to Dungeon Master

Project Member Reported by iannucci@chromium.org, Nov 29 2016

Issue description

The goal is to be able to index all data in Attempt objects (including inside their JSON payloads), ordered by Attempt creation timestamp.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/dd65e8b8494aedf0eafff0ac6894a0c99e0a62ba

commit dd65e8b8494aedf0eafff0ac6894a0c99e0a62ba
Author: iannucci <iannucci@chromium.org>
Date: Tue Nov 29 02:23:24 2016

Add base128 encoding library.

This will be used to safely encode datastore Key string ids, which are
supposedly UTF8 encoded. This base128 implementation only ever uses the lower 7
bits, and so should always roundtrip through UTF8 without any drama.

This is also designed to retain sort-order between sorted and unsorted forms
(that is: the data encoded and unencoded should memcmp sort the same way).
Unfortunately other schemes (such as base64/ascii85) don't preserve this
property.

R=dnj@chromium.org, vadimsh@chromium.org
BUG= 669308 

Review-Url: https://codereview.chromium.org/2538553003

[add] https://crrev.com/dd65e8b8494aedf0eafff0ac6894a0c99e0a62ba/common/data/base128/base128.go
[add] https://crrev.com/dd65e8b8494aedf0eafff0ac6894a0c99e0a62ba/common/data/base128/base128_test.go

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/dd65e8b8494aedf0eafff0ac6894a0c99e0a62ba

commit dd65e8b8494aedf0eafff0ac6894a0c99e0a62ba
Author: iannucci <iannucci@chromium.org>
Date: Tue Nov 29 02:23:24 2016

Add base128 encoding library.

This will be used to safely encode datastore Key string ids, which are
supposedly UTF8 encoded. This base128 implementation only ever uses the lower 7
bits, and so should always roundtrip through UTF8 without any drama.

This is also designed to retain sort-order between sorted and unsorted forms
(that is: the data encoded and unencoded should memcmp sort the same way).
Unfortunately other schemes (such as base64/ascii85) don't preserve this
property.

R=dnj@chromium.org, vadimsh@chromium.org
BUG= 669308 

Review-Url: https://codereview.chromium.org/2538553003

[add] https://crrev.com/dd65e8b8494aedf0eafff0ac6894a0c99e0a62ba/common/data/base128/base128.go
[add] https://crrev.com/dd65e8b8494aedf0eafff0ac6894a0c99e0a62ba/common/data/base128/base128_test.go

Comment 3 by iannu...@google.com, May 10 2017

Owner: iannu...@google.com
bulk reassign to my google account

Comment 4 by iannu...@google.com, May 10 2017

Cc: iannu...@google.com
Owner: ----
Status: Available (was: Untriaged)
Project Member

Comment 5 by sheriffbot@chromium.org, May 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by no...@chromium.org, May 11 2018

Status: Archived (was: Untriaged)
let's reopen when it is relevant

Sign in to add a comment