New issue
Advanced search Search tips

Issue 669293 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 669250



Sign in to add a comment

Implement Enterprise Icon for printers in UI

Project Member Reported by weifangsun@chromium.org, Nov 29 2016

Issue description

In the Print Dialog, printers which have been set up as managed printers should have an enterprise icon displayed.
 
Components: Internals>Printing>CUPS

Comment 3 by x...@chromium.org, Jan 12 2017

Per request, attached the screenshot for different device scale factors. 
device-scale-factor=1.png
65.6 KB View Download
device-scale-factor=2.png
96.8 KB View Download

Comment 4 by dbeam@chromium.org, Jan 14 2017

does this help you notice the difference?
2017-01-13-162030_386x261_scrot.png
13.3 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4ceb8d03a240ef6399b09711eea8518c838d141

commit b4ceb8d03a240ef6399b09711eea8518c838d141
Author: xdai <xdai@chromium.org>
Date: Fri Jan 20 01:00:43 2017

[CUPS] Implement the enterprise icon for printers in Print Preview Dialog.

BUG= 669293 
TEST=Define the enterpise printers policy in DMServer and open Print Preview
dialog (Ctrl+P), test that the enterprise printer shows up with the correct icon.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2618313004
Cr-Commit-Position: refs/heads/master@{#444906}

[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chrome/browser/browser_resources.grd
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chrome/browser/chromeos/printing/printer_pref_manager_unittest.cc
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chrome/browser/resources/print_preview/data/local_parsers.js
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chrome/browser/ui/webui/print_preview/printer_capabilities.cc
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/chromeos/printing/printer_translator.cc
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/printing/backend/print_backend_consts.cc
[modify] https://crrev.com/b4ceb8d03a240ef6399b09711eea8518c838d141/printing/backend/print_backend_consts.h

Comment 6 by x...@chromium.org, Jan 20 2017

Status: Fixed (was: Assigned)

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment