New issue
Advanced search Search tips

Issue 669290 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 660994



Sign in to add a comment

Replace aura::client::kCanMaximize/Minimize/Resize with kResizeBehaviorKey.

Project Member Reported by sky@chromium.org, Nov 29 2016

Issue description

A single property is easier for the mus side to avoid lots of little IPC calls.
 

Comment 1 by msw@chromium.org, Nov 29 2016

Owner: msw@chromium.org
Status: Assigned (was: Untriaged)
I'll try fixing this.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b00a80d7cbcb9dc12278a13bd56b41a008cb978b

commit b00a80d7cbcb9dc12278a13bd56b41a008cb978b
Author: msw <msw@chromium.org>
Date: Wed Nov 30 20:17:06 2016

Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.

Change the default value to allow resize (matches old properties).

Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

Fix NativeWidgetMus::ConfigurePropertiesForNewWindow casting.
(primitive property types should be serialized as int64_t)

TODO: Add ui::mojom::kResizeBehaviorAll?
TODO: Remove maximize from CreateTestWindowWithDelegateAndType?

BUG= 669290 
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2542493002
Cr-Commit-Position: refs/heads/master@{#435395}

[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/BUILD.gn
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/DEPS
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/common/wm/window_state.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/test/BUILD.gn
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/test/ash_test_base.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/chrome/browser/chromeos/login/ui/login_web_dialog_browsertest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/aura/client/aura_constants.h
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/aura/test/test_windows.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/BUILD.gn
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/mus/desktop_window_tree_host_mus.h
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/mus/mus_client.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/widget/desktop_aura/x11_window_event_filter.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/widget/native_widget_aura_unittest.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/widget/widget_delegate.cc
[modify] https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b/ui/views/widget/widget_delegate.h

Comment 3 by msw@chromium.org, Dec 1 2016

Status: Fixed (was: Assigned)

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment